X-Git-Url: http://git.efficios.com/?a=blobdiff_plain;f=sound%2Fcore%2Fpcm_compat.c;h=9630e9f72b7ba2ad77f50a516ecc559c0c200975;hb=43c54b8c7cfe22f868a751ba8a59abf1724160b1;hp=b48b434444ed0e0239936887a891d15da0054e00;hpb=1836ac856e4fb446e48afa4f8cae897d4856b06c;p=deliverable%2Flinux.git

diff --git a/sound/core/pcm_compat.c b/sound/core/pcm_compat.c
index b48b434444ed..9630e9f72b7b 100644
--- a/sound/core/pcm_compat.c
+++ b/sound/core/pcm_compat.c
@@ -255,10 +255,15 @@ static int snd_pcm_ioctl_hw_params_compat(struct snd_pcm_substream *substream,
 	if (! (runtime = substream->runtime))
 		return -ENOTTY;
 
-	/* only fifo_size is different, so just copy all */
-	data = memdup_user(data32, sizeof(*data32));
-	if (IS_ERR(data))
-		return PTR_ERR(data);
+	data = kmalloc(sizeof(*data), GFP_KERNEL);
+	if (!data)
+		return -ENOMEM;
+
+	/* only fifo_size (RO from userspace) is different, so just copy all */
+	if (copy_from_user(data, data32, sizeof(*data32))) {
+		err = -EFAULT;
+		goto error;
+	}
 
 	if (refine)
 		err = snd_pcm_hw_refine(substream, data);