metag: cpu hotplug: route_irq: preserve irq mask
authorJames Hogan <james.hogan@imgtec.com>
Mon, 1 Jul 2013 14:36:38 +0000 (15:36 +0100)
committerJames Hogan <james.hogan@imgtec.com>
Tue, 2 Jul 2013 13:12:22 +0000 (14:12 +0100)
commit8b8b2412994fffd5a8ab3b9209fa0aa9f0fcee4c
tree81b1d11fc31cefafe40ca39811d033a821be5285
parentf6b30d32d242243a967993789c4cf550d840727e
metag: cpu hotplug: route_irq: preserve irq mask

The route_irq() function needs to preserve the irq mask by using the
_irqsave/irqrestore variants of raw spin lock functions instead of the
_irq variants. This is because it is called from __cpu_disable() (via
migrate_irqs()), which is called with IRQs disabled, so using the _irq
variants re-enables IRQs.

This appears to have been causing occasional hits of the
BUG_ON(!irqs_disabled()) in __irq_work_run() during CPU hotplug soak
testing:
  BUG: failure at kernel/irq_work.c:122/__irq_work_run()!

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
arch/metag/kernel/irq.c
This page took 0.039261 seconds and 5 git commands to generate.