[AArch64] Remove useless and incorrect assertion
authorJiong Wang <jiong.wang@arm.com>
Mon, 3 Jul 2017 16:15:26 +0000 (17:15 +0100)
committerJiong Wang <jiong.wang@arm.com>
Tue, 4 Jul 2017 08:24:10 +0000 (09:24 +0100)
commit564e46b795ea9ef95ec662f01139a97717de1603
treeb84ed01719012cf740270ee0380daf1fdea30419
parent0041f7df741692954ebc112c69e5326afb0115ba
[AArch64] Remove useless and incorrect assertion

The outer caller elf_link_output_extsym in elflink.c is a traverse function on
all external symbol, and it will only call *finish_dynamic_symbol if some
conditions is meet.  It is executed conditionally.

If the condition to trigger that assertion is satisified, it then won't satify
the outer check in finish_dynamic_symbol, so *finish_dynamic_symbol won't be
called that the assertion is expected to be dead code.

If elf_link_output_extsym is a traverse function that unconditionally called
on external symbols decided to be exported, then an assertion to make sure these
symbols are in sane status might make sense.

bfd/
        * elfnn-aarch64.c (elfNN_aarch64_finish_dynamic_symbol): Remove the
        sanity check at the head of this function.
bfd/ChangeLog
bfd/elfnn-aarch64.c
This page took 0.024169 seconds and 4 git commands to generate.