Rename VERBOSE log level to TRACE
authorPhilippe Proulx <eeppeliteloop@gmail.com>
Thu, 20 Jun 2019 18:23:39 +0000 (14:23 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Thu, 18 Jul 2019 15:53:32 +0000 (11:53 -0400)
commitc9ecaa780cbfa7020b33fecb6910b5825b46af2c
tree81d947159aa1b830a0cde7576553f213cf791678
parenta9ee0e7b2ebbd2dbf78f6f51af543b8af8c16d04
Rename VERBOSE log level to TRACE

Some people reported that they have a hard time guessing whether the
VERBOSE log level is more or less verbose than the DEBUG log level.

The existing logging frameworks I looked at (Apache Log4j 2, SLF4J,
`java.util.logging`, syslog, Python, Ruby, Boost.Test, ASP.NET Core, to
name a few popular ones) do not have the VERBOSE level; they almost
always have the DEBUG level, and sometimes the TRACE level.

To conform with the common practice, let's use TRACE instead of VERBOSE.
It is my wish that DEBUG vs. TRACE will speak to more developers than
DEBUG vs. VERBOSE.

This means that BT_LOGV() and its variants become BT_LOGT(). Also,
the log level environment variables and the CLI's `--log-level` parameter
accept `T` and `TRACE` instead of `V` and `VERBOSE`. In the log output,
the messages contain `T` instead of `V`:

    06-20 14:31:23.356  3612  3612 T PLUGIN/CTF/BFCR
    read_unsigned_bitfield@bfcr.c:483 [N/A] Read unsigned bit array:
    cur=32, size=8, bo=1, val=33

`CONTRIBUTING.adoc` is updated to document the TRACE level instead of
the VERBOSE level.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Change-Id: I20460c4569f8b755440511c6621a68a1ef6424fc
Reviewed-on: https://review.lttng.org/c/babeltrace/+/1524
CI-Build: Simon Marchi <simon.marchi@efficios.com>
CI-Build: Jonathan Rajotte Julien <jonathan.rajotte-julien@efficios.com>
Reviewed-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Tested-by: jenkins <jenkins@lttng.org>
46 files changed:
CONTRIBUTING.adoc
configure.ac
doc/man/babeltrace2.1.txt
include/babeltrace2/logging.h
src/bindings/python/bt2/bt2/logging.py
src/bindings/python/bt2/bt2/native_bt_logging.i
src/bindings/python/bt2/bt2/utils.py
src/cli/babeltrace2-cfg-cli-args.c
src/cli/babeltrace2.c
src/common/common.h
src/ctf-writer/clock-class.c
src/ctf-writer/event-class.c
src/ctf-writer/event-class.h
src/ctf-writer/event.c
src/ctf-writer/event.h
src/ctf-writer/field-types.c
src/ctf-writer/fields.c
src/ctf-writer/fields.h
src/ctf-writer/object-pool.h
src/ctf-writer/object.h
src/ctf-writer/resolve.c
src/ctf-writer/stream-class.c
src/ctf-writer/stream-class.h
src/ctf-writer/stream.c
src/ctf-writer/stream.h
src/ctf-writer/trace.c
src/ctf-writer/utils.c
src/ctf-writer/validation.c
src/ctf-writer/values.c
src/lib/logging.h
src/lib/object-pool.h
src/lib/object.h
src/lib/value.c
src/logging/log.c
src/logging/log.h
src/plugins/comp-logging.h
src/plugins/ctf/common/bfcr/bfcr.c
src/plugins/ctf/common/metadata/ctf-meta-resolve.c
src/plugins/ctf/common/metadata/decoder.c
src/plugins/ctf/common/metadata/lexer.l
src/plugins/ctf/common/metadata/logging.h
src/plugins/ctf/common/metadata/parser.y
src/plugins/ctf/common/metadata/visitor-generate-ir.c
src/plugins/ctf/common/msg-iter/msg-iter.c
src/plugins/lttng-utils/debug-info/trace-ir-data-copy.c
src/plugins/utils/muxer/muxer.c
This page took 0.032292 seconds and 4 git commands to generate.