drm/i915: properly wait for SBI status
authorEugeni Dodonov <eugeni.dodonov@intel.com>
Fri, 8 Jun 2012 19:43:19 +0000 (16:43 -0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 18 Jun 2012 07:57:07 +0000 (09:57 +0200)
commit39fb50f6178d7dbd70142b25193d722ebf3f8193
treee6dbd47956146d41db3e364108a21021de431da7
parentaaa377302b2994fcc2c66741b47da33feb489dca
drm/i915: properly wait for SBI status

Somehow this went unnoticed in the past reviews, but the condition would
never timeout properly.

This was initially introduced in the v2 of original SBI enabling patch.
Highly embarrassing.

Note that we now actually time out for the read, which resulted in gcc
complaining that we can now return unitialized garbage if that
happens. There's not much we can do here because there's not much
point in thread -EIO all the way down through these functions. Hence
simply shut up the compiler.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
[danvet: Added note and squashed uninitialized value shut-up into this
patch.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c
This page took 0.039292 seconds and 5 git commands to generate.