PCI: Keep original resource if we fail to expand it
authorGuo Chao <yan@linux.vnet.ibm.com>
Fri, 4 Jul 2014 00:30:29 +0000 (18:30 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 4 Jul 2014 00:30:29 +0000 (18:30 -0600)
commitc33377082dd9ede1e998f7ce416077e4b1c2276c
treec35e9737d43a3087fd8afa4253049045fe7c8745
parent7171511eaec5bf23fb06078f59784a3a0626b38f
PCI: Keep original resource if we fail to expand it

If we have space assigned to a resource, we try to expand the resource
(e.g., to accommodate SR-IOV resources), and the expansion attempt fails,
we should keep the original assignment.

After bd064f0a231a ("PCI: Mark resources as IORESOURCE_UNSET if we can't
assign them"), we left the resource marked IORESOURCE_UNSET when the
expansion failed, even if it had originally been set.  That caused errors
like this:

  pci 0003:00:00.0: can't enable device: BAR 15 [mem size 0x0c000000 64bit pref] not assigned
  pci 0003:00:00.0: Error enabling bridge (-22), continuing

Fix this by restoring the original flags when reassignment fails.

[bhelgaas: reworked to simplify, changelog]
Fixes: bd064f0a231a ("PCI: Mark resources as IORESOURCE_UNSET if we can't assign them")
Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: stable@vger.kernel.org # v3.15+
drivers/pci/setup-res.c
This page took 0.026246 seconds and 5 git commands to generate.