spi: bitbang: Replace spinlock by mutex
authorNicolas Boichat <drinkcat@chromium.org>
Mon, 17 Aug 2015 03:52:54 +0000 (11:52 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 17 Sep 2015 11:13:40 +0000 (12:13 +0100)
commitc15f6ed3a18f10cdc33f64906ab353f17a6df114
treed31632b7d325d16e602437062832c01eabae2451
parent6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f
spi: bitbang: Replace spinlock by mutex

chipselect (in the case of spi-gpio: spi_gpio_chipselect, which
calls gpiod_set_raw_value_cansleep) can sleep, so we should not
hold a spinlock while calling it from spi_bitbang_setup.

This issue was introduced by this commit, which converted spi-gpio
to cansleep variants:
d9dda5a191 "spi: spi-gpio: Use 'cansleep' variants to access GPIO"

Replacing the lock variable by a mutex fixes the issue: This is
safe as all instances where the lock is used are called from
contexts that can sleep.

Finally, update spi-ppc4xx and and spi-s3c24xx to use mutex
functions, as they directly hold the lock for similar purpose.

Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-bitbang.c
drivers/spi/spi-ppc4xx.c
drivers/spi/spi-s3c24xx.c
include/linux/spi/spi_bitbang.h
This page took 0.041327 seconds and 5 git commands to generate.