[SCSI] target: Fix multi task->task_sg[] chaining logic bug
authorNicholas Bellinger <nab@linux-iscsi.org>
Fri, 20 May 2011 03:19:09 +0000 (20:19 -0700)
committerJames Bottomley <jbottomley@parallels.com>
Tue, 24 May 2011 16:56:58 +0000 (12:56 -0400)
commit97868c8905a1537153d406c4a3aa39a503a5c299
tree3814892385b463a3ba14d81bf4101285855300f6
parent3eef6257de48ff84a5d98ca533685df8a3beaeb8
[SCSI] target: Fix multi task->task_sg[] chaining logic bug

This patch fixes a bug in transport_do_task_sg_chain() used by HW target
mode modules with sg_chain() to provide a single sg_next() walkable memory
layout for use with pci_map_sg() and friends.  This patch addresses an
issue with mapping multiple small block max_sector tasks across multiple
struct se_task->task_sg[] mappings for HW target mode operation.

This was causing OOPs with (cmd->t_task->t_tasks_no > 1) I/O traffic for
HW target drivers using transport_do_task_sg_chain(), and has been tested
so far with tcm_fc(openfcoe), tcm_qla2xxx, and ib_srpt fabrics with
t_tasks_no > 1 IBLOCK backends using a smaller max_sectors to trigger the
original issue.

Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Acked-by: Kiran Patil <kiran.patil@intel.com>
Cc: stable@kernel.org
Signed-off-by: James Bottomley <jbottomley@parallels.com>
drivers/target/target_core_transport.c
This page took 0.024633 seconds and 5 git commands to generate.