Code cleanup: compile: func_addr -> func_sym
authorJan Kratochvil <jan.kratochvil@redhat.com>
Sat, 16 May 2015 12:20:45 +0000 (14:20 +0200)
committerJan Kratochvil <jan.kratochvil@redhat.com>
Sat, 16 May 2015 12:43:42 +0000 (14:43 +0200)
commit83d3415ef530c41af7e1ae98a7add97adb0cf5e0
treefc15cecb5125e57c9f3a510af94f343b0c10f6d5
parent3a9558c494e9b461f752ce26382701d4446f0958
Code cleanup: compile: func_addr -> func_sym

Currently the code fetches _gdb_expr address/types at multiple places, guessing
its parameters at multiple places etc.

Fetch it once, verify it has expected type and then rely on it.

While the patch tries to clean up the code it is still horrible due to the
missing C++ sub-classing.

gdb/ChangeLog
2015-05-16  Jan Kratochvil  <jan.kratochvil@redhat.com>

* compile/compile-object-load.c (get_regs_type): Add parameter func_sym.
Rely on its parameter count.
(compile_object_load): Replace lookup_minimal_symbol_text by
lookup_global_symbol_from_objfile.  Verify FUNC_SYM.  Set it in the
return value.
* compile/compile-object-load.h (struct compile_module): Replace
func_addr by func_sym.
* compile/compile-object-run.c: Include block.h.
(compile_object_run): Reset module variable after it is freed.  Use
FUNC_SYM instead of FUNC_ADDR.  Rely on it.
gdb/ChangeLog
gdb/compile/compile-object-load.c
gdb/compile/compile-object-load.h
gdb/compile/compile-object-run.c
This page took 0.028084 seconds and 4 git commands to generate.