Unset gdbarch significant_addr_bit by default
authorOmair Javaid <omair.javaid@linaro.org>
Sat, 26 May 2018 00:58:51 +0000 (05:58 +0500)
committerOmair Javaid <omair.javaid@linaro.org>
Thu, 31 May 2018 02:31:21 +0000 (07:31 +0500)
commit5969f0dba74e17c694faf333b120f1e0b95783ed
tree5b1969d7d5c41099b6e0ec201fbad028b264b4f3
parent0034eed03a7428c4902244a33a286763bca65016
Unset gdbarch significant_addr_bit by default

This patch fixes a bug introduced by fix to AArch64 pointer tagging.

In our fix for tagged pointer support our agreed approach was to sign
extend user-space address after clearing tag bits. This is not same
for all architectures and this patch allows sign extension for
addresses on targets which specifically set significant_addr_bit.

More information about patch that caused the issues and discussion
around tagged pointer support can be found in links below:

https://sourceware.org/ml/gdb-patches/2018-05/msg00000.html
https://sourceware.org/ml/gdb-patches/2017-12/msg00159.html

gdb/ChangeLog:

2018-05-31  Omair Javaid  <omair.javaid@linaro.org>

PR gdb/23210
* gdbarch.sh (significant_addr_bit): Default to zero when
not set by target architecture.
* gdbarch.c: Re-generated.
* utils.c (address_significant): Update.
gdb/ChangeLog
gdb/gdbarch.c
gdb/gdbarch.sh
gdb/utils.c
This page took 0.038904 seconds and 4 git commands to generate.