Use a distinguishing name for minidebug objfile
authorTom Tromey <tom@tromey.com>
Tue, 14 Jun 2016 11:46:56 +0000 (12:46 +0100)
committerTom Tromey <tom@tromey.com>
Wed, 16 May 2018 17:15:25 +0000 (11:15 -0600)
commit921222e2e8e8427c6a609b1ff66265dceb0d07eb
tree40ccb1e90d96105b1510c6806f20ff13fd7d9def
parent3acb7083a675fb3077739a2ae41a4a4cd6ef9cc3
Use a distinguishing name for minidebug objfile

One part of PR cli/19551 is that the mini debug info objfile reuses the
name of the main objfile from which it comes.  This can be seen because
gdb claims to be reading symbols from the same file two times, like:

Reading symbols from /bin/gdb...Reading symbols from /bin/gdb...(no debugging symbols found)...done.

I think this would be less confusing if the minidebug objfile were given
a different name.  That is what this patch implements.  It also arranges
for the minidebug objfile to be marked OBJF_NOT_FILENAME.

After this patch the output looks like:

Reading symbols from /bin/gdb...Reading symbols from .gnu_debugdata for /usr/libexec/gdb...(no debugging symbols found)...done.

Tested by the buildbot.

gdb/ChangeLog
2018-05-16  Tom Tromey  <tom@tromey.com>

PR cli/19551:
* symfile-add-flags.h (enum symfile_add_flags)
<SYMFILE_NOT_FILENAME>: New constant.
* symfile.c (read_symbols): Use SYMFILE_NOT_FILENAME.  Get
objfile name from BFD.
(symbol_file_add_with_addrs): Check SYMFILE_NOT_FILENAME.
* minidebug.c (find_separate_debug_file_in_section): Put
".gnu_debugdata" into BFD's file name.
gdb/ChangeLog
gdb/minidebug.c
gdb/symfile-add-flags.h
gdb/symfile.c
This page took 0.027836 seconds and 4 git commands to generate.