Fix "ERROR: no fileid for" in the testsuite.
authorJan Kratochvil <jan.kratochvil@redhat.com>
Sun, 16 Feb 2014 20:49:40 +0000 (21:49 +0100)
committerJan Kratochvil <jan.kratochvil@redhat.com>
Sun, 16 Feb 2014 20:49:40 +0000 (21:49 +0100)
commit0b10be4faf97396c88746f932b55bc3d2fb2d907
treee59b2b1304416b3c11d6cae3303b548cdb3095dd
parent6e03f3da7df9ec3c2852d50d4c4039dc80d606f6
Fix "ERROR: no fileid for" in the testsuite.

If GDB has crashed then gdb_spawn_id still exists (although it does not work).
So my patch does not change anything.  And also currently it will leave the
stale gdbserver running anyway.

In general if gdb_spawn_id does not exist then send_gdb + gdb_expect just do
not make sense anyway.  So this patch just prevents the error in such case.

The killing of stale gdbserver could be improved multiple ways (also as
suggested by Pedro in the original thread) but that is IMO outside of the
scope of this patch.  Apparently if there is no good response from GDB then
gdb_finish() should try to call gdb_start just to kill that gdbserver, IIUC.

gdb/testsuite/
2014-02-16  Jan Kratochvil  <jan.kratochvil@redhat.com>

Fix "ERROR: no fileid for" in the testsuite.
* lib/gdb.exp (gdb_finish): Check gdb_spawn_id.

Message-ID: <20140206205814.GA18495@host2.jankratochvil.net>
gdb/testsuite/ChangeLog
gdb/testsuite/lib/gdb.exp
This page took 0.026143 seconds and 4 git commands to generate.