Fix some error-handling bugs in python frame filters
authorTom Tromey <tom@tromey.com>
Mon, 31 Oct 2016 17:10:35 +0000 (11:10 -0600)
committerTom Tromey <tom@tromey.com>
Tue, 8 Nov 2016 16:10:57 +0000 (09:10 -0700)
commit30a7bb833cbd848b1814f18b91dfdafba4e86839
tree50efadf7d1b250680cf09cbfd1783580f9cd9cd5
parente8b24d9ff5b9419fc079f5fe975fac6f499f8bfb
Fix some error-handling bugs in python frame filters

While writing a Python frame filter, I found a few bugs in the current
frame filter code.  In particular:

* One spot converts a Python long to a CORE_ADDR using PyLong_AsLong.
  However, this can fail on overflow.  I changed this to use
  get_addr_from_python.

* Another spot is doing the same but with PyLong_AsUnsignedLongLong; I
  changed this as well just for consistency.

* Converting line numbers can print "-1" if conversion from long
  fails.  This isn't fatal but just a bit ugly.

I've included a test case for the first issue.  The line number one
didn't seem important enough to bother with.

2016-11-08  Tom Tromey  <tom@tromey.com>

* python/py-framefilter.c (py_print_frame): Use
get_addr_from_python.  Check for errors when getting line number.

2016-11-08  Tom Tromey  <tom@tromey.com>

* gdb.python/py-framefilter.py (ElidingFrameDecorator.address):
New method.
gdb/ChangeLog
gdb/python/py-framefilter.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.python/py-framefilter.py
This page took 0.02635 seconds and 4 git commands to generate.