[Ada] Fix handling of array renamings
authorPierre-Marie de Rodat <derodat@adacore.com>
Tue, 1 Sep 2015 14:18:40 +0000 (16:18 +0200)
committerPierre-Marie de Rodat <derodat@adacore.com>
Wed, 23 Sep 2015 20:14:18 +0000 (22:14 +0200)
commite6c2c623f7736175e52fce2b61aab60c60eccdf5
tree96702023fcb262163ec07db66506e92c3a8030a3
parentb6518b3871859f9eeb7653bf2f3baaa43fa0a5d0
[Ada] Fix handling of array renamings

Compilers can materialize renamings of arrays (or of accesses to arrays)
in Ada into variables whose types are references to the actual array
types.  Before this change, trying to use such an array renaming yielded
an error in GDB:

    (gdb) print my_array(1)
    cannot subscript or call a record
    (gdb) print my_array_ptr(1)
    cannot subscript or call something of type `(null)'

This behavior comes from bad handling for array renamings, in particular
the OP_FUNCALL expression operator handling from ada-lang.c
(ada_evaluate_subexp): in one place we turn the reference into a
pointer, but the code that follows expect the value to be an array.

This patch fixes how we handle references in call/subscript evaluation
so that we turn these references into the actual array values instead of
pointers to them.

gdb/ChangeLog:

* ada-lang.c (ada_evaluate_subexp) <OP_FUNCALL>: When the input
value is a reference, actually dereference it in order to get
the underlying value.

gdb/testsuite/ChangeLog:

* gdb.ada/array_ptr_renaming.exp: New testcase.
* gdb.ada/array_ptr_renaming/foo.adb: New file.
* gdb.ada/array_ptr_renaming/pack.ads: New file.

Tested on x86_64-linux, no regression.
gdb/ChangeLog
gdb/ada-lang.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.ada/array_ptr_renaming.exp [new file with mode: 0644]
gdb/testsuite/gdb.ada/array_ptr_renaming/foo.adb [new file with mode: 0644]
gdb/testsuite/gdb.ada/array_ptr_renaming/pack.ads [new file with mode: 0644]
This page took 0.025526 seconds and 4 git commands to generate.