gdbserver_spawn "" rather than gdbserver_spawn ${binfile}
authorYao Qi <yao.qi@linaro.org>
Tue, 23 Aug 2016 13:24:03 +0000 (14:24 +0100)
committerYao Qi <yao.qi@linaro.org>
Tue, 23 Aug 2016 13:24:03 +0000 (14:24 +0100)
commite9d9abd7470ea500eb4e82567fff68e87a30efb9
treeb8077f96df3f982fcd91c427adcf21fbb58c2d7d
parent3589529e3cec4a5a72cd161959055d1e48dcf129
gdbserver_spawn "" rather than gdbserver_spawn ${binfile}

Hi,
I happen to see gdbserver is spawned like this in gdb.log,

spawn /scratch/yao/gdb/build-git/x86_64/gdb/testsuite/../../gdb/gdbserver/gdbserver --once :2346 /scratch/yao/gdb/build-git/x86_64/gdb/testsuite/outputs/gdb.s
erver/connect-stopped-target/connect-stopped-target /scratch/yao/gdb/build-git/x86_64/gdb/testsuite/outputs/gdb.server/connect-stopped-target/connect-stopped-t
arget

spawn /scratch/yao/gdb/build-git/x86_64/gdb/testsuite/../../gdb/gdbserver/gdbserver --once :2347 /scratch/yao/gdb/build-git/x86_64/gdb/testsuite/outputs/gdb.s
erver/connect-stopped-target/connect-stopped-target /scratch/yao/gdb/build-git/x86_64/gdb/testsuite/outputs/gdb.server/connect-stopped-target/connect-stopped-t
arget

as we can see, there are two instances of connect-stopped-target or
connect-stopped-target in the command line spawning gdbserver, but
none of these gets parameters from command line.  In these two
tests, gdbserver is spawned via "gdbserver_spawn ${binfile}".  However,
the argument of gdbserver_spawn is the argument passed the child
inferior, not the program itself.

 # Start a gdbserver process running SERVER_EXEC, and connect GDB
 # to it.  CHILD_ARGS are passed to the inferior.
 #
 # Returns the target protocol and socket to connect to.

proc gdbserver_spawn { child_args } {
    set target_exec [gdbserver_download_current_prog]

GDBserver gets the program via last_loaded_file, which is set by
gdb_file_cmd.  In each test, we don't need to pass ${binfile}.

gdb/testsuite:

2016-08-23  Yao Qi  <yao.qi@linaro.org>

* gdb.server/connect-stopped-target.exp (do_test): Pass "" to
gdbserver_spawn.
* gdb.server/connect-without-multi-process.exp (do_test):
Likewise.
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.server/connect-stopped-target.exp
gdb/testsuite/gdb.server/connect-without-multi-process.exp
This page took 0.029721 seconds and 4 git commands to generate.