gdb_test_multiple: return -1 on internal error
authorPedro Alves <palves@redhat.com>
Mon, 2 Mar 2015 20:05:25 +0000 (20:05 +0000)
committerPedro Alves <palves@redhat.com>
Mon, 2 Mar 2015 20:05:25 +0000 (20:05 +0000)
commit28054d694f6794d2866d22073117897e372803f2
treeeaff37f00c150ceb826dec1547918198e3096c86
parent2c7b626ceef8ee50d6ef6fb575cfe55b93ef7a0f
gdb_test_multiple: return -1 on internal error

gdb_test_multiple is supposed to return -1 on internal error:

  # Returns:
  #    1 if the test failed, according to a built-in failure pattern
  #    0 if only user-supplied patterns matched
  #   -1 if there was an internal error.

But alas, that's broken, it returns success...  It looks like the code
is assuming an earlier 'set result -1' is still in effect, but
'result' is set to 0 at the end, just before we call gdb_expect:

    set result 0
    set code [catch {gdb_expect $code} string]

gdb/testsuite/
2015-03-02  Pedro Alves  <palves@redhat.com>

* lib/gdb.exp (gdb_test_multiple) <internal error>: Set result to
-1.
gdb/testsuite/ChangeLog
gdb/testsuite/lib/gdb.exp
This page took 0.025537 seconds and 4 git commands to generate.