tmf: Don't import uneeded entries in FunctionNameMapper
authorAlexandre Montplaisir <alexmonthy@voxpopuli.im>
Wed, 11 Feb 2015 22:34:16 +0000 (17:34 -0500)
committerAlexandre Montplaisir <alexmonthy@voxpopuli.im>
Thu, 12 Feb 2015 19:24:57 +0000 (14:24 -0500)
commite5ecc9ace4ceca32d658e69d56e8936a5be93fda
treed3ce5f9e08ac48a56c2c12d7f58d9b97fb1dbc7d
parent318c06c9f03a9e7e76e6344ef5c546efacd8fd51
tmf: Don't import uneeded entries in FunctionNameMapper

Lines from a 'nm' output file that represent non-static symbols
(so for which we don't have adresses) would create an entry in
the function map with an empty string as address.

This is because String.split(" ") would split the series of spaces
at the beginning of the line into many sub-strings. Simply doing
String.trim() first avoids that.

In practice it did not matter much because no entry in the view would
use the empty string key. Still, it's cleaner to fix it.

Change-Id: I4a3ac452aedd8d8cf4ff85db982ccd2c9fdf5693
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41687
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/internal/tmf/core/callstack/FunctionNameMapper.java
This page took 0.035301 seconds and 5 git commands to generate.