pinctrl: sh-pfc: only use dummy states for non-DT platforms
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Mon, 7 Mar 2016 18:40:57 +0000 (19:40 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 30 Mar 2016 08:57:51 +0000 (10:57 +0200)
commit0129801be4b87226bf502f18f5a9eabd356d1058
treed3b58ef9a573f8a65efc1a27a6c3fd62cc965731
parentf55532a0c0b8bb6148f4e07853b876ef73bc69ca
pinctrl: sh-pfc: only use dummy states for non-DT platforms

If pinctrl_provide_dummies() is used unconditionally, then the dummy
state will be used even on DT platforms when the "init" state was
intentionally left out. Instead of "default", the dummy "init" state
will then be used during probe. Thus, when probing an I2C controller on
cold boot, communication triggered by bus notifiers broke because the
pins were not initialized.

Do it like OMAP2: use the dummy state only for non-DT platforms.

Cc: stable@vger.kernel.org
Fixes: ef0eebc05130 ("drivers/pinctrl: Add the concept of an "init" state")
Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/sh-pfc/core.c
This page took 0.024641 seconds and 5 git commands to generate.