Fix a GDB assert failure on windows
authorYuanhui Zhang <asmwarrior@gmail.com>
Mon, 24 Feb 2014 07:22:10 +0000 (15:22 +0800)
committerYao Qi <yao@codesourcery.com>
Mon, 24 Feb 2014 07:49:33 +0000 (15:49 +0800)
commit0837c976950e347cc48a1c55c6c8d60fc710c168
tree1ddb8b00f293c2204db9d6528c578364d5f2216d
parentbc113b4e3e6a47e0a5f351a3b9406fa0b1584dbe
Fix a GDB assert failure on windows

A GDB internal error is found on native mingw32 target.

(gdb) run
../../binutils-gdb/gdb/target.c:1483: internal-error:
target_xfer_partial: Assertion `*xfered_len > 0' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n)

This error was introduced by the following snippet in commit
9b409511d07fe375284701af34909fb539029caf

> @@ -2536,27 +2538,30 @@ windows_xfer_shared_libraries (struct target_ops *ops,
>      }
>
>    obstack_free (&obstack, NULL);
> -  return len;
> +  *xfered_len = (ULONGEST) len;
> +  return TARGET_XFER_OK;
>  }

In the original code, len is returned, which could be 0, but after that
commit, only TARGET_XFER_OK is returned, which is wrong.  If len is 0,
TARGET_XFER_EOF should be returned.  (it is 0 in enum
target_xfer_status declaration).

gdb:

2014-02-24  Yuanhui Zhang  <asmwarrior@gmail.com>

* windows-nat.c (windows_xfer_shared_libraries): Return
TARGET_XFER_EOF if LEN is zero to fix an assert failure when
requested object is TARGET_OBJECT_LIBRARIES.
gdb/ChangeLog
gdb/windows-nat.c
This page took 0.0474 seconds and 4 git commands to generate.