Btrfs: don't wait for all the writers circularly during the transaction commit
authorMiao Xie <miaox@cn.fujitsu.com>
Wed, 15 May 2013 07:48:27 +0000 (07:48 +0000)
committerJosef Bacik <jbacik@fusionio.com>
Fri, 14 Jun 2013 15:29:46 +0000 (11:29 -0400)
commit0860adfdb21c87c73afab4d143e7195603b3e883
tree887543d6bce0adeda2f9677a92edc324c6e9a7d1
parent25d8c284c7d9b9d536a1334f6b670645da971a19
Btrfs: don't wait for all the writers circularly during the transaction commit

btrfs_commit_transaction has the following loop before we commit the
transaction.

do {
    // attempt to do some useful stuff and/or sleep
} while (atomic_read(&cur_trans->num_writers) > 1 ||
 (should_grow && cur_trans->num_joined != joined));

This is used to prevent from the TRANS_START to get in the way of a
committing transaction. But it does not prevent from TRANS_JOIN, that
is we would do this loop for a long time if some writers JOIN the
current transaction endlessly.

Because we need join the current transaction to do some useful stuff,
we can not block TRANS_JOIN here. So we introduce a external writer
counter, which is used to count the TRANS_USERSPACE/TRANS_START writers.
If the external writer counter is zero, we can break the above loop.

In order to make the code more clear, we don't use enum variant
to define the type of the transaction handle, use bitmask instead.

Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
fs/btrfs/transaction.c
fs/btrfs/transaction.h
This page took 0.024652 seconds and 5 git commands to generate.