xfs: remove xfs_cancel_ioend
authorDave Chinner <dchinner@redhat.com>
Mon, 15 Feb 2016 06:21:12 +0000 (17:21 +1100)
committerDave Chinner <david@fromorbit.com>
Mon, 15 Feb 2016 06:21:12 +0000 (17:21 +1100)
commit150d5be09ce49a9bed6feb7b7dc4e5ae188778ec
tree1f0ca744ee28a36980955f53e008e529a4e8e7a3
parent988ef927926aa3481cbf144f235c0cefd7deb9e4
xfs: remove xfs_cancel_ioend

We currently have code to cancel ioends being built because we
change bufferhead state as we build the ioend. On error, this needs
to be unwound and so we have cancelling code that walks the buffers
on the ioend chain and undoes these state changes.

However, the IO submission path already handles state changes for
buffers when a submission error occurs, so we don't really need a
separate cancel function to do this - we can simply submit the
ioend chain with the specific error and it will be cancelled rather
than submitted.

Hence we can remove the explicit cancel code and just rely on
submission to deal with the error correctly.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_aops.c
This page took 0.025774 seconds and 5 git commands to generate.