mmc: block: fix ABI regression of mmc_blk_ioctl
authorShawn Lin <shawn.lin@rock-chips.com>
Wed, 16 Mar 2016 10:15:47 +0000 (18:15 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 17 Mar 2016 13:54:42 +0000 (14:54 +0100)
commit83c742c344c08c2bbe338d45c6ec63110e9d5e3d
tree5f491563321cc39266c1d5993085f08ff3620e16
parent93c77d2999b09f2084b033ea6489915e0104ad9c
mmc: block: fix ABI regression of mmc_blk_ioctl

If mmc_blk_ioctl returns -EINVAL, blkdev_ioctl continues to
work without returning err to user-space. But now we check
CAP_SYS_RAWIO firstly, so we return -EPERM to blkdev_ioctl,
which make blkdev_ioctl return -EPERM to user-space directly.
So this will break all the ioctl with BLKROSET. Now we find
Android-adb suffer it for the following log:

remount of /system failed;
couldn't make block device writable: Operation not permitted
openat(AT_FDCWD, "/dev/block/platform/ff420000.dwmmc/by-name/system", O_RDONLY) = 3
ioctl(3, BLKROSET, 0)  = -1 EPERM (Operation not permitted)

Fixes: a5f5774c55a2 ("mmc: block: Add new ioctl to send multi commands")
Cc: stable@vger.kernel.org
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/card/block.c
This page took 0.030523 seconds and 5 git commands to generate.