ctf: remove field list from constructor of StructDefinition
authorMatthew Khouzam <matthew.khouzam@ericsson.com>
Fri, 15 May 2015 19:51:52 +0000 (15:51 -0400)
committerMatthew Khouzam <matthew.khouzam@ericsson.com>
Fri, 15 May 2015 21:40:56 +0000 (17:40 -0400)
commit8e0c9d81efac35bf8b97e04a27a261f3349b22db
treefdf518494c291b28cafb3c78ef2d5c7ad2b7f768
parentb8b1ba25e49f68f66fc956f1c45b49824cf59942
ctf: remove field list from constructor of StructDefinition

This makes no sense to have as structs have the field list internally.
Moreover this leads to more complicated and error prone struct initialization.
It also hides potential bugs in the tests. As highlighted in CTFEventDefinitionTest

Change-Id: I25bf18bf9be23fb2af17f52de9cf677bea1b4833
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/47992
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
12 files changed:
org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/event/CTFEventDefinitionTest.java
org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/event/CTFEventFieldTest.java
org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/trace/CTFStreamInputReaderTest.java
org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/SequenceDeclaration2Test.java
org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/SequenceDefinition2Test.java
org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/VariantDeclarationTest.java
org.eclipse.tracecompass.ctf.core.tests/src/org/eclipse/tracecompass/ctf/core/tests/types/VariantDefinitionTest.java
org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/EventDefinition.java
org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/StructDeclaration.java
org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/event/types/StructDefinition.java
org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/ctf/core/trace/CTFStreamInputPacketReader.java
org.eclipse.tracecompass.ctf.core/src/org/eclipse/tracecompass/internal/ctf/core/event/EventDeclaration.java
This page took 0.02686 seconds and 5 git commands to generate.