drm/exynos: fix lockdep for event_lock wrt. vbl_time_lock
authorImre Deak <imre.deak@intel.com>
Fri, 2 Nov 2012 11:30:49 +0000 (13:30 +0200)
committerInki Dae <daeinki@gmail.com>
Thu, 29 Nov 2012 11:30:34 +0000 (03:30 -0800)
commit9fb7dff5ec238c8f71ef9b06256957a0db585c04
tree20ea8f26cc5b8eafb90a70d4b47cd13d2d647e19
parente1f48ee58a90ddf84f514334b5d395a358596492
drm/exynos: fix lockdep for event_lock wrt. vbl_time_lock

Currently the exynos driver calls drm_vblank_off() with the event_lock
held, while drm_vblank_off() will lock vbl_time and vblank_time_lock.
This lock dependency chain conflicts with the one in drm_handle_vblank()
where we first lock vblank_time_lock and then the event_lock.

Fix this by removing the above drm_vblank_off() calls which are in fact
never executed: drm_dev->vblank_disable_allowed is only ever non-zero
during driver init, until it's set in {fimd,vidi}_subdrv_probe. Both the
driver init and open code is protected by drm_global_mutex, so the
earliest page flip ioctl can happen only after vblank_disable_allowed is
set to 1. Thus {fimd,vidi}_finish_pageflip - with pending flip events -
will always get called with vblank_disable_allowed being 1.

Signed-off-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
drivers/gpu/drm/exynos/exynos_drm_fimd.c
drivers/gpu/drm/exynos/exynos_drm_vidi.c
This page took 0.026012 seconds and 5 git commands to generate.