mfd: core: Fix platform-device name collisions
authorJohan Hovold <johan@kernel.org>
Wed, 25 Mar 2015 11:07:05 +0000 (12:07 +0100)
committerLee Jones <lee.jones@linaro.org>
Mon, 30 Mar 2015 07:19:57 +0000 (08:19 +0100)
commita77c50b44cfb663ad03faba9800fec19bdf83577
treef6f2a917f1f7980ba0c1732a02caf5eea4ccbf0d
parentbafc1face21f34005d34b72010ad6d7235bd448e
mfd: core: Fix platform-device name collisions

Since commit 6e3f62f0793e ("mfd: core: Fix platform-device id
generation") we honour PLATFORM_DEVID_AUTO and PLATFORM_DEVID_NONE when
registering mfd-devices.

Unfortunately, some mfd-drivers rely on the old behaviour of generating
platform-device ids by adding the cell id also to the special value of
PLATFORM_DEVID_NONE. The resulting platform ids are not only used to
generate device-unique names, but are also used instead of the cell id
to identify cells when probing subdevices.

These drivers should be updated to use PLATFORM_DEVID_AUTO, which would
also allow more than one device to be registered without resorting to
hacks (see for example wm831x), but lets fix the regression first by
partially reverting the above mentioned commit with respect to
PLATFORM_DEVID_NONE.

Fixes: 6e3f62f0793e ("mfd: core: Fix platform-device id generation")
Cc: stable <stable@vger.kernel.org> # v3.19
Reported-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/mfd-core.c
This page took 0.04838 seconds and 5 git commands to generate.