gdb: Use string_printf to format int fields instead of a fixed size buffer
authorAndrew Burgess <andrew.burgess@embecosm.com>
Tue, 20 Nov 2018 13:36:49 +0000 (13:36 +0000)
committerAndrew Burgess <andrew.burgess@embecosm.com>
Tue, 20 Nov 2018 23:01:42 +0000 (23:01 +0000)
commitd63095c426f704f75d943a7481189628403ed58f
treee3974ee4d9d3fa46da651e1de06834fba41f3fbd
parent1871a62daf0561da0880ba1ad39e8191bc3cf1ac
gdb: Use string_printf to format int fields instead of a fixed size buffer

This patch removes a FIXME comment from cli-out.c, now instead of
formatting integers into a fixed size buffer we build a std::string
and extract the formatted integer from that.

The old code using a fixed size buffer was probably fine (the integer
was not going to overflow it) and probably slightly more efficient
(avoids building a std::string) however, given we already have utility
code in GDB that will allow the 'FIXME' comment to be removed, it
seems like an easy improvement.

gdb/ChangeLog:

* cli-out.c (cli_ui_out::do_field_int): Use string_printf rather
than a fixed size buffer.
gdb/ChangeLog
gdb/cli-out.c
This page took 0.023558 seconds and 4 git commands to generate.