f2fs: get victim segment again after new cp
authorYunlei He <heyunlei@huawei.com>
Fri, 22 Jul 2016 11:08:31 +0000 (19:08 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Fri, 22 Jul 2016 18:55:31 +0000 (11:55 -0700)
commitfe94793e555f650fab656649521fc38aaab4874e
tree3eda71fb06e91cf9cb5712e89e9dd950fe5bd11a
parent6f3ec9952c13f0adf632e89456df43946cec6525
f2fs: get victim segment again after new cp

Previous selected segment may become free after write_checkpoint,
if we do garbage collect on this segment, and then new_curseg happen
to reuse it, it may cause f2fs_bug_on as below.

panic+0x154/0x29c
do_garbage_collect+0x15c/0xaf4
f2fs_gc+0x2dc/0x444
f2fs_balance_fs.part.22+0xcc/0x14c
f2fs_balance_fs+0x28/0x34
f2fs_map_blocks+0x5ec/0x790
f2fs_preallocate_blocks+0xe0/0x100
f2fs_file_write_iter+0x64/0x11c
new_sync_write+0xac/0x11c
vfs_write+0x144/0x1e4
SyS_write+0x60/0xc0

Here, maybe we check sit and ssa type during reset_curseg. So, we check
segment is stale or not, and select a new victim to avoid this.

Signed-off-by: Yunlei He <heyunlei@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/gc.c
This page took 0.025475 seconds and 5 git commands to generate.