Fixing some nits I've found while reading this file.
Mostly no behavior changed, except shortcut a loop and removing a useless test.
Change-Id: Iaa2db0f7fc6cf72a3b87b0f67763a4dbf073cf57
Signed-off-by: Etienne Bergeron <etienne.bergeron@gmail.com>
Reviewed-on: https://git.eclipse.org/r/18454
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
/** Filter object */
String FILTER_OBJ = "$fltr_obj"; //$NON-NLS-1$
/** Filter object */
String FILTER_OBJ = "$fltr_obj"; //$NON-NLS-1$
String TIMESTAMP = "$time"; //$NON-NLS-1$
/** Rank */
String TIMESTAMP = "$time"; //$NON-NLS-1$
/** Rank */
}
} else {
broadcast(new TmfTimeSynchSignal(TmfEventsTable.this, ts, fSelectedBeginTimestamp));
}
} else {
broadcast(new TmfTimeSynchSignal(TmfEventsTable.this, ts, fSelectedBeginTimestamp));
- if (fStatusLineManager != null) {
- updateStatusLine(fSelectedBeginTimestamp.getDelta(ts));
- }
+ updateStatusLine(fSelectedBeginTimestamp.getDelta(ts));
fRawViewer.setVisible(true);
fSashForm.layout();
final int index = fTable.getSelectionIndex();
fRawViewer.setVisible(true);
fSashForm.layout();
final int index = fTable.getSelectionIndex();
fRawViewer.selectAndReveal(index - 1);
}
}
fRawViewer.selectAndReveal(index - 1);
}
}
private int fSelectedBeginRank = -1; // Global rank of the selected begin event
private boolean fPendingSelection = false; // Pending selection update
private int fSelectedBeginRank = -1; // Global rank of the selected begin event
private boolean fPendingSelection = false; // Pending selection update
- private int fTableItemCount = 0;
+ private int fTableItemCount = 0;
// The slider
private Slider fSlider;
// The slider
private Slider fSlider;
// Implement a "fake" tooltip
final String TOOLTIP_DATA_KEY = "_TABLEITEM"; //$NON-NLS-1$
// Implement a "fake" tooltip
final String TOOLTIP_DATA_KEY = "_TABLEITEM"; //$NON-NLS-1$
- final Listener labelListener = new Listener () {
+ final Listener labelListener = new Listener() {
@Override
public void handleEvent (Event event) {
@Override
public void handleEvent (Event event) {
- Label label = (Label)event.widget;
- Shell shell = label.getShell ();
+ Label label = (Label) event.widget;
+ Shell shell = label.getShell();
switch (event.type) {
case SWT.MouseDown:
switch (event.type) {
case SWT.MouseDown:
- Event e = new Event ();
- e.item = (TableItem) label.getData (TOOLTIP_DATA_KEY);
+ Event e = new Event();
+ e.item = (TableItem) label.getData(TOOLTIP_DATA_KEY);
// Assuming table is single select, set the selection as if
// the mouse down event went through to the table
// Assuming table is single select, set the selection as if
// the mouse down event went through to the table
- fTable.setSelection (new TableItem [] {(TableItem) e.item});
- fTable.notifyListeners (SWT.Selection, e);
- shell.dispose ();
+ fTable.setSelection(new TableItem [] {(TableItem) e.item});
+ fTable.notifyListeners(SWT.Selection, e);
+ shell.dispose();
fTable.setFocus();
break;
case SWT.MouseExit:
case SWT.MouseWheel:
fTable.setFocus();
break;
case SWT.MouseExit:
case SWT.MouseWheel:
- Listener tableListener = new Listener () {
+ Listener tableListener = new Listener() {
Shell tip = null;
Label label = null;
@Override
Shell tip = null;
Label label = null;
@Override
- public void handleEvent (Event event) {
+ public void handleEvent(Event event) {
switch (event.type) {
case SWT.Dispose:
case SWT.KeyDown:
switch (event.type) {
case SWT.Dispose:
case SWT.KeyDown:
if (tip == null) {
break;
}
if (tip == null) {
break;
}
tip = null;
label = null;
break;
}
case SWT.MouseHover: {
tip = null;
label = null;
break;
}
case SWT.MouseHover: {
- TableItem item = fTable.getItem (new Point(event.x, event.y));
+ TableItem item = fTable.getItem(new Point(event.x, event.y));
- for (int i=0; i < fTable.getColumnCount(); i++) {
+ for (int i = 0; i < fTable.getColumnCount(); i++) {
Rectangle bounds = item.getBounds(i);
Rectangle bounds = item.getBounds(i);
- if (bounds.contains(event.x,event.y)){
+ if (bounds.contains(event.x, event.y)) {
if (tip != null && !tip.isDisposed()) {
tip.dispose();
}
if (tip != null && !tip.isDisposed()) {
tip.dispose();
}
Point pt = fTable.toDisplay(bounds.x, bounds.y);
tip.setBounds(pt.x, pt.y, size.x, size.y);
tip.setVisible(true);
Point pt = fTable.toDisplay(bounds.x, bounds.y);
tip.setBounds(pt.x, pt.y, size.x, size.y);
tip.setVisible(true);
+
+ // Item found, leave loop.
+ break;
@Override
public void handleEvent(Event event) {
if (doubleClickListener != null) {
@Override
public void handleEvent(Event event) {
if (doubleClickListener != null) {
- TableItem item = fTable.getItem (new Point (event.x, event.y));
+ TableItem item = fTable.getItem(new Point (event.x, event.y));
- for(int i=0;i<fTable.getColumnCount();i++){
+ for (int i = 0; i < fTable.getColumnCount(); i++){
Rectangle bounds = item.getBounds(i);
Rectangle bounds = item.getBounds(i);
- if (bounds.contains(event.x,event.y)){
+ if (bounds.contains(event.x, event.y)){
doubleClickListener.handleDoubleClick(TmfVirtualTable.this, item, i);
break;
}
doubleClickListener.handleDoubleClick(TmfVirtualTable.this, item, i);
break;
}
fTable.addKeyListener(listener);
}
fTable.addKeyListener(listener);
}
/**
* Method addMouseListener.
* @param listener MouseListener
/**
* Method addMouseListener.
* @param listener MouseListener
- if (fPendingSelection && done) {
+ if (fPendingSelection) {
fPendingSelection = false;
TableItem item = null;
if (fSelectedEventRank >= 0 && fSelectedEventRank < fFrozenRowCount) {
fPendingSelection = false;
TableItem item = null;
if (fSelectedEventRank >= 0 && fSelectedEventRank < fFrozenRowCount) {