Fix "ERROR: no fileid for" in the testsuite.

If GDB has crashed then gdb_spawn_id still exists (although it does not work).
So my patch does not change anything.  And also currently it will leave the
stale gdbserver running anyway.

In general if gdb_spawn_id does not exist then send_gdb + gdb_expect just do
not make sense anyway.  So this patch just prevents the error in such case.

The killing of stale gdbserver could be improved multiple ways (also as
suggested by Pedro in the original thread) but that is IMO outside of the
scope of this patch.  Apparently if there is no good response from GDB then
gdb_finish() should try to call gdb_start just to kill that gdbserver, IIUC.

gdb/testsuite/
2014-02-16  Jan Kratochvil  <jan.kratochvil@redhat.com>

	Fix "ERROR: no fileid for" in the testsuite.
	* lib/gdb.exp (gdb_finish): Check gdb_spawn_id.

Message-ID: <20140206205814.GA18495@host2.jankratochvil.net>

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 682ac2f80692f0016b5dfb45a0ffd0dc843a38a4..33788ad1faf54721706c6052c138d4f20ce5744e 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2014-02-16  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+       Fix "ERROR: no fileid for" in the testsuite.
+       * lib/gdb.exp (gdb_finish): Check gdb_spawn_id.
+
 2014-02-12  Doug Evans  <dje@google.com>
 
        * gdb.dwarf2/Makefile.in (EXECUTABLES): Add dwp-symlink.

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 66dc8f7d9c6373aa4185e68edcbe09f51de90fd8..9e14da96b25939374fc99ff7117a5c324ac42d9f 100644 (file)
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3711,7 +3711,8 @@ proc gdb_finish { } {
     global cleanfiles
 
     # Give persistent gdbserver a chance to terminate before GDB is killed.
-    if {[info exists gdbserver_reconnect_p] && $gdbserver_reconnect_p} {
+    if {[info exists gdbserver_reconnect_p] && $gdbserver_reconnect_p
+       && [info exists gdb_spawn_id]} {
        send_gdb "kill\n";
        gdb_expect 10 {
            -re "y or n" {