rtc: rtc-sh: Fix up oops in early periodic freq assignment.

With the reordered init order, the rtc device is not registered until
later, while sh_rtc_irq_set_freq() was attempting to assign ->irq_freq
directly, resulting in an oops. This is handled by the upper layers for
us, so just kill off the problematic dereference completely.

Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>

diff --git a/drivers/rtc/rtc-sh.c b/drivers/rtc/rtc-sh.c
index 39a2fcd98c2d85df814ead98b6d930c47b13b9ce..e6ed5404bca0e8d32d4623bd123c6d0b8e6a1b54 100644 (file)
--- a/drivers/rtc/rtc-sh.c
+++ b/drivers/rtc/rtc-sh.c
@@ -283,10 +283,8 @@ static int sh_rtc_irq_set_freq(struct device *dev, int freq)
                ret = -ENOTSUPP;
        }
 
-       if (ret == 0) {
+       if (ret == 0)
                rtc->periodic_freq |= tmp;
-               rtc->rtc_dev->irq_freq = freq;
-       }
 
        spin_unlock_irq(&rtc->lock);
        return ret;