lttng.control: Replacing isKernel with an enum for the domain type
authorBruno Roy <bruno.roy@ericsson.com>
Mon, 6 Jun 2016 18:54:22 +0000 (14:54 -0400)
committerMarc-Andre Laperle <marc-andre.laperle@ericsson.com>
Thu, 7 Jul 2016 15:13:25 +0000 (11:13 -0400)
Since we are adding a support for a new domain (JUL) the boolean value
isKernel is not enough anymore. I changed it for a enum type
TraceDomainType.

Change-Id: Id7e9bb5f739e93255a6770bc5813a2822dcb085d
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74798
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
43 files changed:
lttng/org.eclipse.tracecompass.lttng2.control.core/META-INF/MANIFEST.MF
lttng/org.eclipse.tracecompass.lttng2.control.core/src/org/eclipse/tracecompass/internal/lttng2/control/core/model/IDomainInfo.java
lttng/org.eclipse.tracecompass.lttng2.control.core/src/org/eclipse/tracecompass/internal/lttng2/control/core/model/TraceDomainType.java
lttng/org.eclipse.tracecompass.lttng2.control.core/src/org/eclipse/tracecompass/internal/lttng2/control/core/model/impl/DomainInfo.java
lttng/org.eclipse.tracecompass.lttng2.control.core/src/org/eclipse/tracecompass/lttng2/control/core/session/SessionConfigGenerator.java
lttng/org.eclipse.tracecompass.lttng2.control.ui.tests/src/org/eclipse/tracecompass/lttng2/control/ui/tests/model/component/TraceControlKernelSessionTest.java
lttng/org.eclipse.tracecompass.lttng2.control.ui.tests/src/org/eclipse/tracecompass/lttng2/control/ui/tests/model/component/TraceControlTreeModelTest.java
lttng/org.eclipse.tracecompass.lttng2.control.ui.tests/src/org/eclipse/tracecompass/lttng2/control/ui/tests/model/component/TraceControlUstProviderTest.java
lttng/org.eclipse.tracecompass.lttng2.control.ui.tests/src/org/eclipse/tracecompass/lttng2/control/ui/tests/model/component/TraceControlUstSession2Test.java
lttng/org.eclipse.tracecompass.lttng2.control.ui.tests/src/org/eclipse/tracecompass/lttng2/control/ui/tests/model/component/TraceControlUstSessionTest.java
lttng/org.eclipse.tracecompass.lttng2.control.ui.tests/src/org/eclipse/tracecompass/lttng2/control/ui/tests/service/LTTngControlServiceTest.java
lttng/org.eclipse.tracecompass.lttng2.control.ui.tests/stubs/org/eclipse/tracecompass/internal/lttng2/control/stubs/dialogs/EnableChannelDialogStub.java
lttng/org.eclipse.tracecompass.lttng2.control.ui.tests/stubs/org/eclipse/tracecompass/internal/lttng2/control/stubs/dialogs/EnableEventsDialogStub.java
lttng/org.eclipse.tracecompass.lttng2.control.ui.tests/stubs/org/eclipse/tracecompass/internal/lttng2/control/stubs/dialogs/GetEventInfoDialogStub.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/dialogs/EnableChannelDialog.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/dialogs/EnableEventsDialog.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/dialogs/EnableKernelEventComposite.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/dialogs/EnableUstEventsComposite.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/dialogs/GetEventInfoDialog.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/dialogs/IEnableChannelDialog.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/dialogs/IEnableEventsDialog.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/dialogs/IGetEventInfoDialog.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/AssignEventHandler.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/BaseEnableChannelHandler.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/BaseEnableEventHandler.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/ChangeChannelStateHandler.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/ChangeEventStateHandler.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/EnableChannelOnDomainHandler.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/EnableChannelOnSessionHandler.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/EnableEventOnChannelHandler.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/EnableEventOnDomainHandler.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/handlers/EnableEventOnSessionHandler.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/model/impl/BaseEventComponent.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/model/impl/NullControlService.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/model/impl/TargetNodeComponent.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/model/impl/TraceChannelComponent.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/model/impl/TraceDomainComponent.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/model/impl/TraceEventComponent.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/model/impl/TraceProviderGroup.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/model/impl/TraceSessionComponent.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/service/ILttngControlService.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/service/LTTngControlService.java
lttng/org.eclipse.tracecompass.lttng2.control.ui/src/org/eclipse/tracecompass/internal/lttng2/control/ui/views/service/LTTngControlServiceMI.java

index 397a7269a3e2c2fae855d05d901d58456604c860..f352c50acc6af47beb9ed6f160d4ffb8b27bf41e 100644 (file)
@@ -12,7 +12,7 @@ Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.tracecompass.ctf.core,
  org.eclipse.tracecompass.tmf.core,
  org.eclipse.tracecompass.tmf.ctf.core
-Export-Package: org.eclipse.tracecompass.internal.lttng2.control.core;x-friends:="org.eclipse.tracecompass.lttng2.control.core.tests,org.eclipse.tracecompass.lttng2.control.ui",
+Export-Package: org.eclipse.tracecompass.internal.lttng2.control.core;x-friends:="org.eclipse.tracecompass.lttng2.control.core.tests,org.eclipse.tracecompass.lttng2.control.ui,org.eclipse.tracecompass.lttng2.control.ui.tests",
  org.eclipse.tracecompass.internal.lttng2.control.core.model;
   x-friends:="org.eclipse.tracecompass.lttng2.control.ui,
    org.eclipse.tracecompass.lttng2.control.ui.tests,
index 70b399e356db390c1515830bc0baeab511b7a3f0..b097659709c2bb31f1fdfdd683a9ce5c1577c921 100644 (file)
@@ -42,15 +42,15 @@ public interface IDomainInfo extends ITraceInfo {
     void addChannel(IChannelInfo channel);
 
     /**
-     * @return true if domain is kernel, false for UST
+     * @return the domain type ({@link TraceDomainType})
      */
-    boolean isKernel();
+    TraceDomainType getDomain();
 
     /**
-     * Sets whether domain is  Kernel domain or UST
-     * @param isKernel true for kernel, false for UST
+     * Sets the domain type.
+     * @param domain - the domain type ({@link TraceDomainType})
      */
-    void setIsKernel(boolean isKernel);
+    void setDomain(TraceDomainType domain);
 
     /**
      * @return Information about the buffer type
index 3cd690f3fb635c1babbdeb205b36327a54f0458c..eeb623ccc09180e52aa79c5955673030fb6d2607 100644 (file)
@@ -1,5 +1,5 @@
 /**********************************************************************
- * Copyright (c) 2014 Ericsson
+ * Copyright (c) 2014, 2016 Ericsson
  *
  * All rights reserved. This program and the accompanying materials are
  * made available under the terms of the Eclipse Public License v1.0 which
@@ -9,7 +9,6 @@
  * Contributors:
  *   Jonathan Rajotte - Initial API and implementation
  **********************************************************************/
-
 package org.eclipse.tracecompass.internal.lttng2.control.core.model;
 
 /**
@@ -18,13 +17,17 @@ package org.eclipse.tracecompass.internal.lttng2.control.core.model;
  * @author Jonathan Rajotte
  */
 public enum TraceDomainType {
-    /** Domain type : ust */
-    UST("ust"), //$NON-NLS-1$
-    /** Domain type : kernel */
+    /** Linux kernel domain */
     KERNEL("kernel"), //$NON-NLS-1$
-    /** Domain type : jul */
-    JUL("jul"), //$NON-NLS-1$
-    /** Unknown domain type */
+    /** user space domain */
+    UST("ust"), //$NON-NLS-1$
+    /** java.util.logging (JUL) domain */
+    JUL("jul"), //$NON-NLS-1$s
+    /** log4j domain */
+    LOG4J("log4j"), //$NON-NLS-1$
+    /** python domain */
+    PYTHON("python"), //$NON-NLS-1$
+    /** Unknown domain */
     UNKNOWN("Unknown domain type"); //$NON-NLS-1$
 
     private final String fInName;
@@ -61,4 +64,4 @@ public enum TraceDomainType {
         // Unknown domain
         return UNKNOWN;
     }
-}
\ No newline at end of file
+}
index 5f77cd0409be2d5bc4a2d70bf449a28554c2196b..af52b749bbff5d6b705adf88564593c79cbdbca9 100644 (file)
@@ -15,6 +15,7 @@ import java.util.ArrayList;
 import java.util.Iterator;
 import java.util.List;
 
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IChannelInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IDomainInfo;
 
@@ -35,7 +36,7 @@ public class DomainInfo extends TraceInfo implements IDomainInfo {
      * The channels information of the domain.
      */
     private final List<IChannelInfo> fChannels = new ArrayList<>();
-    private boolean fIsKernel = false;
+    private TraceDomainType fDomain = TraceDomainType.UST;
     private BufferType fBufferType = BufferType.BUFFER_TYPE_UNKNOWN;
 
     // ------------------------------------------------------------------------
@@ -62,18 +63,18 @@ public class DomainInfo extends TraceInfo implements IDomainInfo {
                 fChannels.add(other.fChannels.get(i));
             }
         }
-        fIsKernel = other.fIsKernel;
+        fDomain = other.getDomain();
         fBufferType = other.fBufferType;
     }
 
     @Override
-    public boolean isKernel() {
-        return fIsKernel;
+    public TraceDomainType getDomain() {
+        return fDomain;
     }
 
     @Override
-    public void setIsKernel(boolean isKernel) {
-        fIsKernel = isKernel;
+    public void setDomain(TraceDomainType domain) {
+        fDomain = domain;
     }
 
     // ------------------------------------------------------------------------
@@ -104,7 +105,7 @@ public class DomainInfo extends TraceInfo implements IDomainInfo {
         final int prime = 31;
         int result = super.hashCode();
         result = prime * result + fChannels.hashCode();
-        result = prime * result + (fIsKernel ? 1231 : 1237);
+        result = prime * result + ((fDomain == null) ? 0 : (fDomain.ordinal() + 1));
         result = prime * result + ((fBufferType == null) ? 0 : (fBufferType.ordinal() + 1));
         return result;
     }
@@ -124,7 +125,11 @@ public class DomainInfo extends TraceInfo implements IDomainInfo {
         if (!fChannels.equals(other.fChannels)) {
             return false;
         }
-        if (fIsKernel != other.fIsKernel) {
+        if (fDomain == null) {
+            if (other.fDomain != null) {
+                return false;
+            }
+        } else if (!fDomain.equals(other.fDomain)) {
             return false;
         }
         if (fBufferType != other.fBufferType) {
@@ -135,7 +140,7 @@ public class DomainInfo extends TraceInfo implements IDomainInfo {
 
     @Override
     public BufferType getBufferType() {
-        if (fIsKernel) {
+        if (fDomain.equals(TraceDomainType.KERNEL)) {
             return BufferType.BUFFER_SHARED;
         }
         return fBufferType;
@@ -162,7 +167,7 @@ public class DomainInfo extends TraceInfo implements IDomainInfo {
                 }
             }
             output.append(",isKernel=");
-            output.append(String.valueOf(fIsKernel));
+            output.append(String.valueOf(fDomain.equals(TraceDomainType.KERNEL)));
             if ((fBufferType != null) && !fBufferType.equals(BufferType.BUFFER_TYPE_UNKNOWN) && !fBufferType.equals(BufferType.BUFFER_SHARED)) {
                 output.append(",BufferType=");
                 output.append(fBufferType);
index be4479e77c293c44a1acf5a28cd1b41849399d1a..1c8921bc3b2f330000d12d6df58ee9c4b46b15ff 100644 (file)
@@ -38,6 +38,7 @@ import org.eclipse.core.runtime.Status;
 import org.eclipse.jdt.annotation.NonNull;
 import org.eclipse.osgi.util.NLS;
 import org.eclipse.tracecompass.internal.lttng2.control.core.Activator;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IChannelInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IDomainInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IEventInfo;
@@ -225,13 +226,23 @@ public final class SessionConfigGenerator {
         for (IDomainInfo domain : session.getDomains()) {
             Element domainElement = document.createElement(SessionConfigStrings.CONFIG_ELEMENT_DOMAIN);
 
-            /*
-             * Add everything specific to a domain
-             *
-             * TODO: We suppose here that domain is either kernel or UST. It
-             * will have to change if other domains are supported
-             */
-            String domainType = domain.isKernel() ? SessionConfigStrings.CONFIG_DOMAIN_TYPE_KERNEL : SessionConfigStrings.CONFIG_DOMAIN_TYPE_UST;
+            String domainType = null;
+            switch (domain.getDomain()) {
+            case KERNEL:
+                domainType = SessionConfigStrings.CONFIG_DOMAIN_TYPE_KERNEL;
+                break;
+            case UST:
+                domainType = SessionConfigStrings.CONFIG_DOMAIN_TYPE_UST;
+                break;
+            // TODO: Add the following cases when more domains are supported
+            case JUL:
+            case LOG4J:
+            case PYTHON:
+            case UNKNOWN:
+            default:
+                break;
+
+            }
             addElementContent(document, domainElement, SessionConfigStrings.CONFIG_ELEMENT_TYPE, domainType);
 
             String bufferType = null;
@@ -252,7 +263,7 @@ public final class SessionConfigGenerator {
             addElementContent(document, domainElement, SessionConfigStrings.CONFIG_ELEMENT_DOMAIN_BUFFER_TYPE, bufferType);
 
             /* Add the channels */
-            domainElement.appendChild(getChannelsElement(document, domain.isKernel(), domain.getChannels()));
+            domainElement.appendChild(getChannelsElement(document, domain.getDomain(), domain.getChannels()));
             domainsElement.appendChild(domainElement);
         }
 
@@ -289,13 +300,13 @@ public final class SessionConfigGenerator {
      *
      * @param document
      *            The document in which the nodes are being added
-     * @param isKernel
-     *            Is it a kernel domain type
+     * @param domain
+     *            The domain type ({@link TraceDomainType})
      * @param channels
      *            The channels to be added as elements
      * @return The channels element as an XML element
      */
-    private static Element getChannelsElement(Document document, boolean isKernel, IChannelInfo[] channels) {
+    private static Element getChannelsElement(Document document, TraceDomainType domain, IChannelInfo[] channels) {
         Element channelsElement = document.createElement(SessionConfigStrings.CONFIG_ELEMENT_CHANNELS);
 
         for (IChannelInfo channel : channels) {
@@ -327,7 +338,7 @@ public final class SessionConfigGenerator {
             addElementContent(document, channelElement, SessionConfigStrings.CONFIG_ELEMENT_LIVE_TIMER_INTERVAL, SessionConfigStrings.CONFIG_STRING_ZERO);
 
             /* Add the events */
-            channelElement.appendChild(getEventsElement(document, isKernel, channel.getEvents()));
+            channelElement.appendChild(getEventsElement(document, domain, channel.getEvents()));
             channelsElement.appendChild(channelElement);
         }
 
@@ -340,13 +351,13 @@ public final class SessionConfigGenerator {
      *
      * @param document
      *            The document in which the nodes are being added
-     * @param isKernel
-     *            Is the domain type kernel
+     * @param domain
+     *            The domain type ({@link TraceDomainType})
      * @param events
      *            The event informations to be added
      * @return An element containing all the event informations as XML elements
      */
-    private static Element getEventsElement(Document document, boolean isKernel, IEventInfo[] events) {
+    private static Element getEventsElement(Document document, TraceDomainType domain, IEventInfo[] events) {
         Element eventsElement = document.createElement(SessionConfigStrings.CONFIG_ELEMENT_EVENTS);
 
         for (IEventInfo event : events) {
@@ -366,7 +377,7 @@ public final class SessionConfigGenerator {
             }
 
             /* Specific to UST session config: the log level */
-            if (!isKernel && !event.getLogLevel().equals(TraceLogLevel.LEVEL_UNKNOWN)) {
+            if (domain.equals(TraceDomainType.UST) && !event.getLogLevel().equals(TraceLogLevel.LEVEL_UNKNOWN)) {
                 addElementContent(document, eventElement, SessionConfigStrings.CONFIG_ELEMENT_LOGLEVEL, event.getLogLevel().ordinal());
             }
 
index 620debe48a3e5203d5caa2525877cadaa158600a..1cbbdcc927ad7d0872eeabfd963eeb5df8237327 100644 (file)
@@ -29,6 +29,7 @@ import org.eclipse.core.runtime.FileLocator;
 import org.eclipse.core.runtime.Path;
 import org.eclipse.jdt.annotation.NonNull;
 import org.eclipse.remote.core.IRemoteConnection;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TargetNodeState;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceChannelOutputType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceEnablement;
@@ -165,7 +166,7 @@ public class TraceControlKernelSessionTest {
         // Enable channel on session
         // ------------------------------------------------------------------------
         EnableChannelDialogStub channelStub = new EnableChannelDialogStub();
-        channelStub.setIsKernel(true);
+        channelStub.setDomain(TraceDomainType.KERNEL);
         TraceControlDialogFactory.getInstance().setEnableChannelDialog(channelStub);
 
         fFacility.executeCommand(session, "enableChannelOnSession");
@@ -236,7 +237,7 @@ public class TraceControlKernelSessionTest {
         events.add("sched_kthread_stop");
         events.add("sched_kthread_stop_ret");
         eventsDialogStub.setNames(events);
-        eventsDialogStub.setIsKernel(true);
+        eventsDialogStub.setDomain(TraceDomainType.KERNEL);
         TraceControlDialogFactory.getInstance().setEnableEventsDialog(eventsDialogStub);
 
         // ------------------------------------------------------------------------
index 60cd336c2046b1f6bd2313c73de0e427eb06a02c..3e83fd699027146522cab04d09968ffbdff59c8c 100644 (file)
@@ -15,7 +15,6 @@
 package org.eclipse.tracecompass.lttng2.control.ui.tests.model.component;
 
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNotSame;
 import static org.junit.Assert.assertNull;
@@ -29,6 +28,7 @@ import org.eclipse.core.runtime.Path;
 import org.eclipse.jdt.annotation.NonNull;
 import org.eclipse.remote.core.IRemoteConnection;
 import org.eclipse.swt.graphics.Image;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.LogLevelType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TargetNodeState;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceChannelOutputType;
@@ -507,12 +507,20 @@ public class TraceControlTreeModelTest {
 
     private static void verifyDomainGettersSetters(TraceDomainComponent domain) {
         // save original values
-        boolean isKernel = domain.isKernel();
-
-        domain.setIsKernel(false);
-        assertFalse(domain.isKernel());
-        domain.setIsKernel(true);
-        assertTrue(domain.isKernel());
+        TraceDomainType tmpDomain = domain.getDomain();
+
+        domain.setDomain(TraceDomainType.KERNEL);
+        assertEquals(domain.getDomain(), TraceDomainType.KERNEL);
+        domain.setDomain(TraceDomainType.UST);
+        assertEquals(domain.getDomain(), TraceDomainType.UST);
+        domain.setDomain(TraceDomainType.JUL);
+        assertEquals(domain.getDomain(), TraceDomainType.JUL);
+        domain.setDomain(TraceDomainType.LOG4J);
+        assertEquals(domain.getDomain(), TraceDomainType.LOG4J);
+        domain.setDomain(TraceDomainType.PYTHON);
+        assertEquals(domain.getDomain(), TraceDomainType.PYTHON);
+        domain.setDomain(TraceDomainType.UNKNOWN);
+        assertEquals(domain.getDomain(), TraceDomainType.UNKNOWN);
 
         ITraceControlComponent[] children = domain.getChildren();
         TraceChannelComponent[] channels = domain.getChannels();
@@ -527,7 +535,7 @@ public class TraceControlTreeModelTest {
         assertEquals(TARGET_NODE_NAME, nodeName);
 
         // restore original values
-        domain.setIsKernel(isKernel);
+        domain.setDomain(tmpDomain);
     }
 
     private static void verifyBaseEventGettersSetters(BaseEventComponent event) {
index e3d9af1afbeda36b15b66e39786ded857dd5665f..bf0a9b981173fdd70808119d18b2e55e8d70e097 100644 (file)
@@ -25,6 +25,7 @@ import org.eclipse.core.runtime.FileLocator;
 import org.eclipse.core.runtime.Path;
 import org.eclipse.jdt.annotation.NonNull;
 import org.eclipse.remote.core.IRemoteConnection;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TargetNodeState;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceChannelOutputType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceEnablement;
@@ -175,7 +176,7 @@ public class TraceControlUstProviderTest {
         // ------------------------------------------------------------------------
         fProxy.setScenario(SCEN_SCENARIO2_TEST);
         EnableChannelDialogStub channelDialogStub = new EnableChannelDialogStub();
-        channelDialogStub.setIsKernel(false);
+        channelDialogStub.setDomain(TraceDomainType.UST);
         channelDialogStub.getChannelInfo().setOverwriteMode(false);
         channelDialogStub.getChannelInfo().setSwitchTimer(200);
         channelDialogStub.getChannelInfo().setReadTimer(100);
index 707eb0060030080ea08d9163aa1dace3f5a1d905..d7a20f4f2ed9f1dcb828da3fb7272ee19f0b6314 100644 (file)
@@ -24,6 +24,7 @@ import org.eclipse.core.runtime.FileLocator;
 import org.eclipse.core.runtime.Path;
 import org.eclipse.jdt.annotation.NonNull;
 import org.eclipse.remote.core.IRemoteConnection;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TargetNodeState;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.impl.BufferType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.impl.ChannelInfo;
@@ -147,7 +148,7 @@ public class TraceControlUstSession2Test {
         // Enable default channel on created session above
         // ------------------------------------------------------------------------
         EnableChannelDialogStub channelStub = new EnableChannelDialogStub();
-        channelStub.setIsKernel(false);
+        channelStub.setDomain(TraceDomainType.UST);
         ChannelInfo info = (ChannelInfo)channelStub.getChannelInfo();
         info.setName("mychannel");
         info.setOverwriteMode(false);
index 4409d7fc95a5cae4acf9f360b716c69d188741e5..d7482767e944cc5d777e7c261b84044cd907e4e1 100644 (file)
@@ -30,6 +30,7 @@ import org.eclipse.core.runtime.IStatus;
 import org.eclipse.core.runtime.Path;
 import org.eclipse.jdt.annotation.NonNull;
 import org.eclipse.remote.core.IRemoteConnection;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.LogLevelType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TargetNodeState;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceChannelOutputType;
@@ -165,7 +166,7 @@ public class TraceControlUstSessionTest {
         // Enable default channel on created session above
         // ------------------------------------------------------------------------
         EnableChannelDialogStub channelStub = new EnableChannelDialogStub();
-        channelStub.setIsKernel(false);
+        channelStub.setDomain(TraceDomainType.UST);
         TraceControlDialogFactory.getInstance().setEnableChannelDialog(channelStub);
 
         fFacility.executeCommand(session, "enableChannelOnSession");
@@ -287,7 +288,7 @@ public class TraceControlUstSessionTest {
         List<String> events = new ArrayList<>();
         events.add("ust_tests_hello:tptest_sighandler");
         eventsDialogStub.setNames(events);
-        eventsDialogStub.setIsKernel(false);
+        eventsDialogStub.setDomain(TraceDomainType.UST);
         TraceControlDialogFactory.getInstance().setEnableEventsDialog(eventsDialogStub);
 
         fFacility.executeCommand(session, "enableEventOnSession");
index 69b26b21233b397a5f984e6b4e254dfa287bf85b..baca3ac087b579e4480defa2da95a13e77b1e556 100644 (file)
@@ -43,6 +43,7 @@ import org.eclipse.tracecompass.internal.lttng2.control.core.model.ISnapshotInfo
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IUstProviderInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.LogLevelType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceChannelOutputType;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceEnablement;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceEventType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceLogLevel;
@@ -106,7 +107,7 @@ public class LTTngControlServiceTest {
     private static final String SCEN_DESTROY_SESSION_VERBOSE = "DestroySessionVerbose";
     private static final String SCEN_CHANNEL_HANDLING = "ChannelHandling";
     private static final String SCEN_EVENT_HANDLING = "EventHandling";
-    private static final String SCEN_EVENT_EXLUDED = "EventExcluded";
+    private static final String SCEN_EVENT_EXCLUDED = "EventExcluded";
     private static final String SCEN_CONTEXT_HANDLING = "ContextHandling";
     private static final String SCEN_CONTEXT_ERROR_HANDLING = "ContextErrorHandling";
     private static final String SCEN_CREATE_SESSION_2_1 = "CreateSessionLttng2.1";
@@ -964,7 +965,7 @@ public class LTTngControlServiceTest {
             chanInfo.setNumberOfSubBuffers(2);
             chanInfo.setMaxNumberTraceFiles(10);
             chanInfo.setMaxSizeTraceFiles(0);
-            fService.enableChannels(sessionName, list, true, chanInfo, new NullProgressMonitor());
+            fService.enableChannels(sessionName, list, TraceDomainType.KERNEL, chanInfo, new NullProgressMonitor());
 
             // Create/enable/configure 1 UST channel
             list.clear();
@@ -978,7 +979,7 @@ public class LTTngControlServiceTest {
             chanInfo.setNumberOfSubBuffers(1);
             chanInfo.setMaxNumberTraceFiles(20);
             chanInfo.setMaxSizeTraceFiles(0);
-            fService.enableChannels(sessionName, list, false, chanInfo, new NullProgressMonitor());
+            fService.enableChannels(sessionName, list, TraceDomainType.UST, chanInfo, new NullProgressMonitor());
             ((LTTngControlService)fService).setVersion("2.0.0");
 
         } catch (ExecutionException e) {
@@ -1005,7 +1006,7 @@ public class LTTngControlServiceTest {
             chanInfo.setMaxNumberTraceFiles(20);
             chanInfo.setMaxSizeTraceFiles(0);
             chanInfo.setBufferType(BufferType.BUFFER_PER_UID);
-            fService.enableChannels(sessionName, list, false, chanInfo, new NullProgressMonitor());
+            fService.enableChannels(sessionName, list, TraceDomainType.UST, chanInfo, new NullProgressMonitor());
             ((LTTngControlService)fService).setVersion("2.0.0");
 
         } catch (ExecutionException e) {
@@ -1034,7 +1035,7 @@ public class LTTngControlServiceTest {
             chanInfo.setMaxSizeTraceFiles(-1);
             chanInfo.setBufferType(BufferType.BUFFER_PER_PID);
 
-            fService.enableChannels(sessionName, list, false, chanInfo, new NullProgressMonitor());
+            fService.enableChannels(sessionName, list, TraceDomainType.UST, chanInfo, new NullProgressMonitor());
             ((LTTngControlService)fService).setVersion("2.0.0");
 
         } catch (ExecutionException e) {
@@ -1054,11 +1055,11 @@ public class LTTngControlServiceTest {
             list.add(kernelChannel1);
 
             fShell.setScenario(SCEN_CHANNEL_HANDLING);
-            fService.disableChannels(sessionName, list, true, new NullProgressMonitor());
+            fService.disableChannels(sessionName, list, TraceDomainType.KERNEL, new NullProgressMonitor());
 
             list.clear();
             list.add("ustChannel");
-            fService.disableChannels(sessionName, list, false, new NullProgressMonitor());
+            fService.disableChannels(sessionName, list, TraceDomainType.UST, new NullProgressMonitor());
 
         } catch (ExecutionException e) {
             fail(e.toString());
@@ -1077,13 +1078,13 @@ public class LTTngControlServiceTest {
             list.add(kernelChannel1);
 
             fShell.setScenario(SCEN_CHANNEL_HANDLING);
-            fService.enableChannels(sessionName, list, true, null, new NullProgressMonitor());
+            fService.enableChannels(sessionName, list, TraceDomainType.KERNEL, null, new NullProgressMonitor());
 
             // Create/enable/configure 1 UST channel
             list.clear();
             list.add("ustChannel");
 
-            fService.enableChannels(sessionName, list, false, null, new NullProgressMonitor());
+            fService.enableChannels(sessionName, list, TraceDomainType.UST, null, new NullProgressMonitor());
 
         } catch (ExecutionException e) {
             fail(e.toString());
@@ -1112,37 +1113,37 @@ public class LTTngControlServiceTest {
             eventList.add(eventName0);
             eventList.add(eventName1);
             eventList.add(eventName2);
-            fService.enableEvents(sessionName, null, eventList, true, null, null, new NullProgressMonitor());
+            fService.enableEvents(sessionName, null, eventList, TraceDomainType.KERNEL, null, null, new NullProgressMonitor());
 
             // 2) session name, channel = mychannel, event name= null, kernel
-            fService.enableEvents(sessionName, channelName, null, true, null, null, new NullProgressMonitor());
+            fService.enableEvents(sessionName, channelName, null, TraceDomainType.KERNEL, null, null, new NullProgressMonitor());
 
             // 3) session name, channel = mychannel, 1 event name, ust, no filter
             eventList.clear();
             eventList.add(ustEventName0);
-            fService.enableEvents(sessionName, channelName, eventList, false, null, null, new NullProgressMonitor());
+            fService.enableEvents(sessionName, channelName, eventList, TraceDomainType.UST, null, null, new NullProgressMonitor());
 
             // 4) session name, channel = mychannel, no event name, ust, with filter
-            fService.enableEvents(sessionName, channelName, eventList, false, "intfield==10", null, new NullProgressMonitor());
+            fService.enableEvents(sessionName, channelName, eventList, TraceDomainType.UST, "intfield==10", null, new NullProgressMonitor());
 
             // 5) session name, channel = mychannel, no event name, ust, no filter
             eventList.clear();
-            fService.enableEvents(sessionName, channelName, eventList, false, null, null, new NullProgressMonitor());
+            fService.enableEvents(sessionName, channelName, eventList, TraceDomainType.UST, null, null, new NullProgressMonitor());
 
             // 6) session name, channel = null,
-            fService.enableEvents(sessionName, null, ILttngControlService.ALL_EVENTS, true, null, null, new NullProgressMonitor());
+            fService.enableEvents(sessionName, null, ILttngControlService.ALL_EVENTS, TraceDomainType.KERNEL, null, null, new NullProgressMonitor());
 
             // 7) session name, channel = mychannel, all events, ust, exclude 1 event
             excludeList.add(ustEventName0);
-            fService.enableEvents(sessionName, channelName, null, false, null, excludeList, new NullProgressMonitor());
+            fService.enableEvents(sessionName, channelName, null, TraceDomainType.UST, null, excludeList, new NullProgressMonitor());
 
             // 8) session name, channel = mychannel, all events, ust, exclude 2 events
             excludeList.add(ustEventName1);
-            fService.enableEvents(sessionName, channelName, null, false, null, excludeList, new NullProgressMonitor());
+            fService.enableEvents(sessionName, channelName, null, TraceDomainType.UST, null, excludeList, new NullProgressMonitor());
 
             // 9) session name, channel = mychannel, enable 'ust*', ust, exclude 2 events
             eventList.add(ustEventWildcard);
-            fService.enableEvents(sessionName, channelName, eventList, false, null, excludeList, new NullProgressMonitor());
+            fService.enableEvents(sessionName, channelName, eventList, TraceDomainType.UST, null, excludeList, new NullProgressMonitor());
 
         } catch (ExecutionException e) {
             fail(e.toString());
@@ -1164,12 +1165,12 @@ public class LTTngControlServiceTest {
 
             @NonNull
             LttngVersion version = fService.getVersion();
-            fShell.setScenario(SCEN_EVENT_EXLUDED);
+            fShell.setScenario(SCEN_EVENT_EXCLUDED);
 
             // 1) 1 event excluded
             eventList.add(ustEventWildcard);
             excludeList.add(ustEventName0);
-            fService.enableEvents(sessionName, channelName, eventList, false, null, excludeList, new NullProgressMonitor());
+            fService.enableEvents(sessionName, channelName, eventList, TraceDomainType.UST, null, excludeList, new NullProgressMonitor());
 
             @Nullable
             ISessionInfo session = fService.getSession(sessionName, new NullProgressMonitor());
@@ -1185,7 +1186,7 @@ public class LTTngControlServiceTest {
 
             // 2) 2 events excluded
             excludeList.add(ustEventName1);
-            fService.enableEvents(sessionName, channelName, eventList, false, null, excludeList, new NullProgressMonitor());
+            fService.enableEvents(sessionName, channelName, eventList, TraceDomainType.UST, null, excludeList, new NullProgressMonitor());
 
             session = fService.getSession(sessionName, new NullProgressMonitor());
             assertNotNull(session);
@@ -1308,7 +1309,7 @@ public class LTTngControlServiceTest {
             assertTrue(expectedContexts.containsAll(availContexts));
 
             // 1) session name, channel = null, event name, loglevel-only, TRACE_DEBUG
-            fService.addContexts(sessionName, channelName, eventName, false, contexts, new NullProgressMonitor());
+            fService.addContexts(sessionName, channelName, eventName, TraceDomainType.UST, contexts, new NullProgressMonitor());
 
         } catch (ExecutionException e) {
             fail(e.toString());
@@ -1334,7 +1335,7 @@ public class LTTngControlServiceTest {
         }
         try {
             // 1) session name, channel = null, event name, loglevel-only, TRACE_DEBUG
-            fService.addContexts(sessionName, channelName, eventName, false, contexts, new NullProgressMonitor());
+            fService.addContexts(sessionName, channelName, eventName, TraceDomainType.UST, contexts, new NullProgressMonitor());
             fail("No exeption generated");
         } catch (ExecutionException e) {
             // success
index 570f0a77f694443dd6a29a6f1fba7a2333481249..6a9365a55cb4ed19116de6e215d200ea2e036c37 100644 (file)
@@ -11,6 +11,7 @@
  **********************************************************************/
 package org.eclipse.tracecompass.internal.lttng2.control.stubs.dialogs;
 
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IChannelInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.impl.BufferType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.impl.ChannelInfo;
@@ -27,9 +28,9 @@ public class EnableChannelDialogStub implements IEnableChannelDialog {
     // ------------------------------------------------------------------------
     // Attributes
     // ------------------------------------------------------------------------
-    private TraceDomainComponent fDomain;
+    private TraceDomainComponent fDomainComponent;
     private ChannelInfo fChannelInfo;
-    private boolean fIsKernel;
+    private TraceDomainType fDomain;
 
     // ------------------------------------------------------------------------
     // Constructor
@@ -46,9 +47,6 @@ public class EnableChannelDialogStub implements IEnableChannelDialog {
     // ------------------------------------------------------------------------
     // Accessors
     // ------------------------------------------------------------------------
-    public void setIsKernel(boolean isKernel) {
-        fIsKernel = isKernel;
-    }
 
     @Override
     public IChannelInfo getChannelInfo() {
@@ -57,9 +55,9 @@ public class EnableChannelDialogStub implements IEnableChannelDialog {
 
     @Override
     public void setDomainComponent(TraceDomainComponent domain) {
-        fDomain = domain;
-        if (fDomain != null) {
-            fIsKernel = fDomain.isKernel();
+        fDomainComponent = domain;
+        if (fDomainComponent != null) {
+            fDomain = fDomainComponent.getDomain();
         }
     }
 
@@ -69,8 +67,12 @@ public class EnableChannelDialogStub implements IEnableChannelDialog {
     }
 
     @Override
-    public boolean isKernel() {
-        return fIsKernel;
+    public TraceDomainType getDomain() {
+        return fDomain;
+    }
+
+    public void setDomain(TraceDomainType domain) {
+        fDomain = domain;
     }
 
     @Override
index 106a31cf506820d0b857cb10d136471d2e1075d1..0a4964b83228cfcaf8d3795c7cfd3428cd7ba31c 100644 (file)
@@ -14,6 +14,7 @@ package org.eclipse.tracecompass.internal.lttng2.control.stubs.dialogs;
 import java.util.ArrayList;
 import java.util.List;
 
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.LogLevelType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceLogLevel;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.dialogs.IEnableEventsDialog;
@@ -29,7 +30,6 @@ public class EnableEventsDialogStub implements IEnableEventsDialog {
     // ------------------------------------------------------------------------
     // Attributes
     // ------------------------------------------------------------------------
-    private boolean fIsKernel;
     private boolean fIsTracePoints;
     private boolean fIsAllEvents;
     private boolean fIsAllTracePoints;
@@ -49,12 +49,13 @@ public class EnableEventsDialogStub implements IEnableEventsDialog {
     private String fFilter;
     private List<String> fNames = new ArrayList<>();
     private List<String> fExcludedEvents;
+    private TraceDomainType fDomain;
 
     // ------------------------------------------------------------------------
     // Accessors
     // ------------------------------------------------------------------------
-    public void setIsKernel(boolean isKernel) {
-        fIsKernel = isKernel;
+    public void setDomain(TraceDomainType domain) {
+        fDomain = domain;
     }
 
     public void setIsAllEvents(boolean isAllEvents) {
@@ -220,8 +221,8 @@ public class EnableEventsDialogStub implements IEnableEventsDialog {
     }
 
     @Override
-    public boolean isKernel() {
-        return fIsKernel;
+    public TraceDomainType getDomain() {
+        return fDomain;
     }
 
     @Override
index c08978ec987d1d9c2458d2c472e83a9008f3c438..9e28ae78b260acd84e1e0626f4732add2e9d8184 100644 (file)
@@ -13,6 +13,7 @@ package org.eclipse.tracecompass.internal.lttng2.control.stubs.dialogs;
 
 import java.util.Arrays;
 
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.dialogs.IGetEventInfoDialog;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.model.impl.TraceChannelComponent;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.model.impl.TraceSessionComponent;
@@ -36,7 +37,7 @@ public class GetEventInfoDialogStub implements IGetEventInfoDialog {
     }
 
     @Override
-    public void setIsKernel(boolean isKernel) {
+    public void setDomain(TraceDomainType domain) {
     }
 
     @Override
index 5a4194026c37ffff15e100a358cd127d18ea1360..6e44925995553aa4e8b1acd4c63f9b56430d95dd 100644 (file)
@@ -31,6 +31,7 @@ import org.eclipse.swt.widgets.Group;
 import org.eclipse.swt.widgets.Label;
 import org.eclipse.swt.widgets.Shell;
 import org.eclipse.swt.widgets.Text;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IChannelInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.impl.BufferType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.impl.ChannelInfo;
@@ -105,7 +106,7 @@ public class EnableChannelDialog extends Dialog implements IEnableChannelDialog
      * The parent domain component where the channel node should be added.
      * Null in case of creation on session level.
      */
-    private TraceDomainComponent fDomain = null;
+    private TraceDomainComponent fDomainComponent = null;
     /**
      * The target node component
      */
@@ -123,9 +124,9 @@ public class EnableChannelDialog extends Dialog implements IEnableChannelDialog
      */
     private IChannelInfo fChannelInfo = null;
     /**
-     * Output domain information. True in case of Kernel domain. False for UST.
+     * Domain type ({@link TraceDomainType})
      */
-    private boolean fIsKernel;
+    private TraceDomainType fDomain = null;
     /**
      *  Flag which indicates whether Kernel domain is available or not
      */
@@ -169,7 +170,7 @@ public class EnableChannelDialog extends Dialog implements IEnableChannelDialog
      */
     public EnableChannelDialog(Shell shell) {
        super(shell);
-       fIsKernel = true;
+       fDomain = TraceDomainType.KERNEL;
 
         // Common verify listener
         fVerifyListener = new VerifyListener() {
@@ -216,25 +217,25 @@ public class EnableChannelDialog extends Dialog implements IEnableChannelDialog
 
     @Override
     public void setDomainComponent(TraceDomainComponent domain) {
-        fDomain = domain;
-        if (fDomain != null) {
-            fIsKernel = fDomain.isKernel();
+        fDomainComponent = domain;
+        if (fDomainComponent != null) {
+            fDomain = fDomainComponent.getDomain();
         } else {
-            fIsKernel = true;
+            fDomain = TraceDomainType.KERNEL;
         }
     }
 
     @Override
-    public boolean isKernel() {
-        return fIsKernel;
+    public TraceDomainType getDomain() {
+        return fDomain;
     }
 
     @Override
     public void setHasKernel(boolean hasKernel) {
-        if (fDomain != null) {
-            fIsKernel = fDomain.isKernel();
+        if (fDomainComponent != null) {
+            fDomain = fDomainComponent.getDomain();
         } else {
-            fIsKernel = hasKernel;
+            fDomain = hasKernel ? TraceDomainType.KERNEL : TraceDomainType.UST;
         }
 
         fHasKernel = hasKernel;
@@ -364,10 +365,10 @@ public class EnableChannelDialog extends Dialog implements IEnableChannelDialog
 
         fKernelButton = new Button(domainGroup, SWT.RADIO);
         fKernelButton.setText(Messages.TraceControl_KernelDomainDisplayName);
-        fKernelButton.setSelection(fIsKernel);
+        fKernelButton.setSelection(fDomain.equals(TraceDomainType.KERNEL));
         fUstButton = new Button(domainGroup, SWT.RADIO);
         fUstButton.setText(Messages.TraceControl_UstDisplayName);
-        fUstButton.setSelection(!fIsKernel);
+        fUstButton.setSelection(fDomain.equals(TraceDomainType.UST));
 
         if (fTargetNodeComponent.isBufferTypeConfigSupported()) {
             Group bufferTypeGroup = new Group(dialogComposite, SWT.SHADOW_NONE);
@@ -381,7 +382,7 @@ public class EnableChannelDialog extends Dialog implements IEnableChannelDialog
 
             fSharedBuffersButton = new Button(bufferTypeGroup, SWT.RADIO);
             fSharedBuffersButton.setText(Messages.TraceControl_SharedBuffersDisplayName);
-            fSharedBuffersButton.setSelection(fIsKernel);
+            fSharedBuffersButton.setSelection(fDomain.equals(TraceDomainType.KERNEL));
             fSharedBuffersButton.setEnabled(false);
 
             fPIDBuffersButton = new Button(bufferTypeGroup, SWT.RADIO);
@@ -394,8 +395,8 @@ public class EnableChannelDialog extends Dialog implements IEnableChannelDialog
             fUIDBuffersButton.setToolTipText(Messages.TraceControl_PerPidBuffersTooltip);
             fUIDBuffersButton.setSelection(false);
 
-            fUIDBuffersButton.setEnabled(!fIsKernel);
-            fPIDBuffersButton.setEnabled(!fIsKernel);
+            fUIDBuffersButton.setEnabled(fDomain.equals(TraceDomainType.UST));
+            fPIDBuffersButton.setEnabled(fDomain.equals(TraceDomainType.UST));
 
             // Update buffers type buttons depending on UST or Kernel
             fUstButton.addSelectionListener(new SelectionAdapter() {
@@ -418,7 +419,7 @@ public class EnableChannelDialog extends Dialog implements IEnableChannelDialog
             });
         }
 
-        if ((fDomain != null) || (!fHasKernel)) {
+        if ((fDomainComponent != null) || (!fHasKernel)) {
             fKernelButton.setEnabled(false);
             fUstButton.setEnabled(false);
 
@@ -512,7 +513,12 @@ public class EnableChannelDialog extends Dialog implements IEnableChannelDialog
             }
         }
 
-        fIsKernel = fKernelButton.getSelection();
+        if (fKernelButton.getSelection()) {
+            fDomain = TraceDomainType.KERNEL;
+        }
+        else if (fUstButton.getSelection()) {
+            fDomain = TraceDomainType.UST;
+        }
 
         // Check for invalid names
         if (!channelInfo.getName().matches("^[a-zA-Z0-9\\-\\_]{1,}$")) { //$NON-NLS-1$
@@ -523,7 +529,7 @@ public class EnableChannelDialog extends Dialog implements IEnableChannelDialog
         }
 
         // Check for duplicate names
-        if (fDomain != null && fDomain.containsChild(channelInfo.getName())) {
+        if (fDomainComponent != null && fDomainComponent.containsChild(channelInfo.getName())) {
             MessageDialog.openError(getShell(),
                     Messages.TraceControl_EnableChannelDialogTitle,
                     Messages.TraceControl_ChannelAlreadyExistsError + " (" + channelInfo.getName() + ") \n");  //$NON-NLS-1$ //$NON-NLS-2$
@@ -574,8 +580,8 @@ public class EnableChannelDialog extends Dialog implements IEnableChannelDialog
     }
 
     private void setBufferTypeButtonSelection() {
-        if ((fDomain != null) && fDomain.getBufferType() != null) {
-            switch (fDomain.getBufferType()) {
+        if ((fDomainComponent != null) && fDomainComponent.getBufferType() != null) {
+            switch (fDomainComponent.getBufferType()) {
             case BUFFER_PER_PID:
                 fPIDBuffersButton.setSelection(true);
                 break;
index 0ada6b54bc383ade69872eb5fdd57514110f9353..9b386a9aaf35c6a6d0a69105892f8596b9ef18b5 100644 (file)
@@ -27,6 +27,7 @@ import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Control;
 import org.eclipse.swt.widgets.Group;
 import org.eclipse.swt.widgets.Shell;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.LogLevelType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceLogLevel;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.Activator;
@@ -84,11 +85,12 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
      * The parent domain component where the channel node should be added.
      * Null in case the domain is not known (i.e. on session level).
      */
-    private TraceDomainComponent fDomain;
+    private TraceDomainComponent fDomainComponent;
     /**
-     * Output domain information. True in case of Kernel domain. False for UST.
+     * The domain type ({@link TraceDomainType})
      */
-    private boolean fIsKernel;
+    private TraceDomainType fDomain;
+
 
     // ------------------------------------------------------------------------
     // Constructors
@@ -107,7 +109,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
     // ------------------------------------------------------------------------
     @Override
     public boolean isAllEvents() {
-        if (fIsKernel) {
+        if (fDomain.equals(TraceDomainType.KERNEL)) {
             return fKernelComposite.isAllEvents();
         }
         return false;
@@ -115,7 +117,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public boolean isTracepoints() {
-        if (fIsKernel) {
+        if (fDomain.equals(TraceDomainType.KERNEL)) {
             return fKernelComposite.isTracepoints();
         }
         return fUstComposite.isTracepoints();
@@ -123,7 +125,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public boolean isAllTracePoints() {
-        if (fIsKernel) {
+        if (fDomain.equals(TraceDomainType.KERNEL)) {
             return fKernelComposite.isAllTracePoints();
         }
         return fUstComposite.isAllTracePoints();
@@ -131,7 +133,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public boolean isSysCalls() {
-        if (fIsKernel) {
+        if (fDomain.equals(TraceDomainType.KERNEL)) {
             return fKernelComposite.isSysCalls();
         }
         return false;
@@ -139,7 +141,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public boolean isAllSysCalls() {
-        if (fIsKernel) {
+        if (fDomain.equals(TraceDomainType.KERNEL)) {
             return fKernelComposite.isSysCalls();
         }
         return false;
@@ -147,7 +149,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public List<String> getEventNames() {
-        if (fIsKernel) {
+        if (fDomain.equals(TraceDomainType.KERNEL)) {
             return fKernelComposite.getEventNames();
         }
         return fUstComposite.getEventNames();
@@ -155,7 +157,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public boolean isDynamicProbe() {
-        if (fIsKernel) {
+        if (fDomain.equals(TraceDomainType.KERNEL)) {
             return fKernelComposite.isDynamicProbe();
         }
         return false;
@@ -163,7 +165,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public String getProbeName() {
-        if (fIsKernel) {
+        if (fDomain.equals(TraceDomainType.KERNEL)) {
             return fKernelComposite.getProbeName();
         }
         return null;
@@ -171,7 +173,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public String getProbeEventName() {
-        if (fIsKernel) {
+        if (fDomain.equals(TraceDomainType.KERNEL)) {
             return fKernelComposite.getProbeEventName();
         }
         return null;
@@ -179,7 +181,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public boolean isDynamicFunctionProbe() {
-        if (fIsKernel) {
+        if (fDomain.equals(TraceDomainType.KERNEL)) {
             return fKernelComposite.isDynamicFunctionProbe();
         }
         return false;
@@ -187,7 +189,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public String getFunctionEventName() {
-        if (fIsKernel) {
+        if (fDomain.equals(TraceDomainType.KERNEL)) {
             return fKernelComposite.getFunctionEventName();
         }
         return null;
@@ -195,7 +197,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public String getFunction() {
-        if (fIsKernel) {
+        if (fDomain.equals(TraceDomainType.KERNEL)) {
             return fKernelComposite.getFunction();
         }
         return null;
@@ -203,7 +205,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public boolean isWildcard() {
-        if (!fIsKernel) {
+        if (fDomain.equals(TraceDomainType.UST)) {
             return fUstComposite.isWildcard();
         }
         return false;
@@ -211,7 +213,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public String getWildcard() {
-        if (!fIsKernel) {
+        if (fDomain.equals(TraceDomainType.UST)) {
             return fUstComposite.getWildcard();
         }
         return null;
@@ -219,7 +221,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public boolean isLogLevel() {
-        if (!fIsKernel) {
+        if (fDomain.equals(TraceDomainType.UST)) {
             return fUstComposite.isLogLevel();
         }
         return false;
@@ -227,7 +229,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public LogLevelType getLogLevelType() {
-        if (!fIsKernel) {
+        if (fDomain.equals(TraceDomainType.UST)) {
             return fUstComposite.getLogLevelType();
         }
         return null;
@@ -235,7 +237,7 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public TraceLogLevel getLogLevel() {
-        if (!fIsKernel) {
+        if (fDomain.equals(TraceDomainType.UST)) {
             return fUstComposite.getLogLevel();
         }
         return null;
@@ -243,15 +245,15 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public String getLogLevelEventName() {
-        if (!fIsKernel) {
+        if (fDomain.equals(TraceDomainType.UST)) {
             return fUstComposite.getLogLevelEventName();
         }
         return null;
     }
 
     @Override
-    public boolean isKernel() {
-        return fIsKernel;
+    public TraceDomainType getDomain() {
+        return fDomain;
     }
 
     @Override
@@ -261,25 +263,36 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     public void setTraceDomainComponent(TraceDomainComponent domain) {
-        fDomain = domain;
-        if (fDomain != null) {
-            fIsKernel = fDomain.isKernel();
+        fDomainComponent = domain;
+        if (fDomainComponent != null) {
+            fDomain = fDomainComponent.getDomain();
         } else {
-            fIsKernel = fProviderGroup != null ? fProviderGroup.hasKernelProvider() : true;
+            if (fProviderGroup != null) {
+                fDomain = fProviderGroup.hasKernelProvider() ? TraceDomainType.KERNEL : TraceDomainType.UST;
+            }
         }
     }
 
     @Override
     public String getFilterExpression() {
-        if (fIsKernel) {
+
+        switch (fDomain) {
+        case KERNEL:
             return fKernelComposite.getFilterExpression();
+        case UST:
+            return fUstComposite.getFilterExpression();
+        case JUL:
+        case LOG4J:
+        case PYTHON:
+        case UNKNOWN:
+        default:
+            return null;
         }
-        return fUstComposite.getFilterExpression();
     }
 
     @Override
     public List<String> getExcludedEvents() {
-        if (!fIsKernel) {
+        if (fDomain.equals(TraceDomainType.UST)) {
             return fUstComposite.getExcludedEvents();
         }
         return null;
@@ -315,12 +328,25 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
         fKernelButton = new Button(domainGroup, SWT.RADIO);
         fKernelButton.setText(Messages.TraceControl_KernelDomainDisplayName);
-        fKernelButton.setSelection(fIsKernel);
         fUstButton = new Button(domainGroup, SWT.RADIO);
         fUstButton.setText(Messages.TraceControl_UstDisplayName);
-        fUstButton.setSelection(!fIsKernel);
 
-        if ((fDomain != null) || ((fProviderGroup != null) && (!fProviderGroup.hasKernelProvider()))) {
+        switch (fDomain) {
+        case KERNEL:
+            fKernelButton.setSelection(true);
+            break;
+        case UST:
+            fUstButton.setSelection(true);
+            break;
+        case JUL:
+        case LOG4J:
+        case PYTHON:
+        case UNKNOWN:
+        default:
+            break;
+        }
+
+        if ((fDomainComponent != null) || ((fProviderGroup != null) && (!fProviderGroup.hasKernelProvider()))) {
             fKernelButton.setEnabled(false);
             fUstButton.setEnabled(false);
         }
@@ -339,11 +365,21 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
         // ------------------------------------------------------------------------
         fUstComposite = null;
         fKernelComposite = null;
-        if (fIsKernel) {
+
+        switch (fDomain) {
+
+        case KERNEL:
             createKernelComposite();
-            fUstComposite = null;
-        } else {
+            break;
+        case UST:
             createUstComposite();
+            break;
+        case JUL:
+        case LOG4J:
+        case PYTHON:
+        case UNKNOWN:
+        default:
+            break;
         }
 
         fKernelButton.addSelectionListener(new SelectionAdapter() {
@@ -381,7 +417,12 @@ public class EnableEventsDialog extends Dialog implements IEnableEventsDialog  {
 
     @Override
     protected void okPressed() {
-        fIsKernel = fKernelButton.getSelection();
+
+        if (fKernelButton.getSelection()) {
+            fDomain = TraceDomainType.KERNEL;
+        } else if (fUstButton.getSelection()){
+            fDomain = TraceDomainType.UST;
+        }
 
         // Validate kernel composite in case of kernel domain
         if (fKernelComposite != null && !fKernelComposite.isValid()) {
index 4f5a73b5947c435ba508a59be787a69c6faa9da1..e400b60c2111349ac5eeb1875d514d1ce52f5620 100644 (file)
@@ -33,6 +33,7 @@ import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Group;
 import org.eclipse.swt.widgets.Label;
 import org.eclipse.swt.widgets.Text;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.messages.Messages;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.model.ITraceControlComponent;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.model.impl.BaseEventComponent;
@@ -359,7 +360,7 @@ public class EnableKernelEventComposite extends Composite implements IEnableKern
 
         // initialize filter with null
         fFilterExpression = null;
-        if (fProviderGroup.isEventFilteringSupported(true)) {
+        if (fProviderGroup.isEventFilteringSupported(TraceDomainType.KERNEL)) {
             String tempFilter = fFilterText.getText();
 
             if(!tempFilter.trim().isEmpty()) {
@@ -660,7 +661,7 @@ public class EnableKernelEventComposite extends Composite implements IEnableKern
     }
 
     private void createFilterGroup() {
-        if (fProviderGroup.isEventFilteringSupported(true)) {
+        if (fProviderGroup.isEventFilteringSupported(TraceDomainType.KERNEL)) {
             Group filterMainGroup = new Group(this, SWT.SHADOW_NONE);
             filterMainGroup.setText(Messages.TraceControl_EnableEventsFilterGroupName);
             GridLayout layout = new GridLayout(3, false);
index fd2a833bb5a6036711877f5d23d7fd4b6cd95644..eb38dccc59e239ff4b2bcbd06f92a4c4498d77bd 100644 (file)
@@ -36,6 +36,7 @@ import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Group;
 import org.eclipse.swt.widgets.Label;
 import org.eclipse.swt.widgets.Text;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.LogLevelType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceLogLevel;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.messages.Messages;
@@ -385,7 +386,7 @@ public class EnableUstEventsComposite extends Composite implements IEnableUstEve
 
         // initialize filter with null
         fFilterExpression = null;
-        if (fProviderGroup.isEventFilteringSupported(false)) {
+        if (fProviderGroup.isEventFilteringSupported(TraceDomainType.UST)) {
             String tempFilter = fFilterText.getText();
 
             if(!tempFilter.trim().isEmpty()) {
@@ -630,7 +631,7 @@ public class EnableUstEventsComposite extends Composite implements IEnableUstEve
     }
 
     void createFilterGroup() {
-        if (fProviderGroup.isEventFilteringSupported(false)) {
+        if (fProviderGroup.isEventFilteringSupported(TraceDomainType.UST)) {
             Group filterMainGroup = new Group(this, SWT.SHADOW_NONE);
             filterMainGroup.setText(Messages.TraceControl_EnableEventsFilterGroupName);
             GridLayout layout = new GridLayout(3, false);
index c4334b5f2ef7015ff4acf44d12391b4d3a436df3..e1e2943582596c6a7ba2d787d59c32b82d03f8a2 100644 (file)
@@ -29,6 +29,7 @@ import org.eclipse.swt.widgets.Control;
 import org.eclipse.swt.widgets.Group;
 import org.eclipse.swt.widgets.Shell;
 import org.eclipse.swt.widgets.Text;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.Activator;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.messages.Messages;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.model.impl.TraceChannelComponent;
@@ -72,9 +73,9 @@ public class GetEventInfoDialog extends Dialog implements IGetEventInfoDialog {
      */
     private TraceSessionComponent[] fSessions;
     /**
-     * True for kernel, false for UST.
+     * The domain type ({@link TraceDomainType})
      */
-    private boolean fIsKernel;
+    private TraceDomainType fDomain;
     /**
      * Index in session array (selected session).
      */
@@ -119,8 +120,8 @@ public class GetEventInfoDialog extends Dialog implements IGetEventInfoDialog {
     }
 
     @Override
-    public void setIsKernel(boolean isKernel) {
-        fIsKernel = isKernel;
+    public void setDomain(TraceDomainType domain) {
+        fDomain = domain;
     }
 
     @Override
@@ -194,7 +195,7 @@ public class GetEventInfoDialog extends Dialog implements IGetEventInfoDialog {
                     TraceDomainComponent[] domains = fSessions[fSessionIndex].getDomains();
                     for (int i = 0; i < domains.length; i++) {
 
-                        if (domains[i].isKernel() == fIsKernel) {
+                        if (domains[i].getDomain().equals(fDomain)) {
                             domain = domains[i];
                             break;
                         }
@@ -223,7 +224,7 @@ public class GetEventInfoDialog extends Dialog implements IGetEventInfoDialog {
         });
 
         // take first session to test whether events filtering is supported or not
-        if (fSessions[0].isEventFilteringSupported(fIsKernel)) {
+        if (fSessions[0].isEventFilteringSupported(fDomain)) {
             Group filterMainGroup = new Group(dialogComposite, SWT.SHADOW_NONE);
             filterMainGroup.setText(Messages.TraceControl_EnableEventsFilterGroupName);
             layout = new GridLayout(2, false);
@@ -268,7 +269,7 @@ public class GetEventInfoDialog extends Dialog implements IGetEventInfoDialog {
 
         // initialize filter with null
         fFilterExpression = null;
-        if (fSessions[0].isEventFilteringSupported(fIsKernel)) {
+        if (fSessions[0].isEventFilteringSupported(fDomain)) {
             String tempFilter = fFilterText.getText();
 
             if(!tempFilter.trim().isEmpty()) {
index d23174dd95f9920719408b05d13f81f82b256c4b..696e012c35ad99b2caa2a2c51057395149f97fe3 100644 (file)
@@ -11,6 +11,7 @@
  **********************************************************************/
 package org.eclipse.tracecompass.internal.lttng2.control.ui.views.dialogs;
 
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IChannelInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.model.impl.TargetNodeComponent;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.model.impl.TraceDomainComponent;
@@ -45,9 +46,9 @@ public interface IEnableChannelDialog {
     void setTargetNodeComponent(TargetNodeComponent node);
 
     /**
-     * @return true for Kernel domain. False for UST.
+     * @return The domain type ({@link TraceDomainType})
      */
-    boolean isKernel();
+    TraceDomainType getDomain();
 
     /**
      * Sets the whether dialog is for Kernel or UST
index f34837e3b2641dd477b8024f777b0f2bd66b7ce7..16ed92c08c661c33f05bd008b8dc133b13c8394f 100644 (file)
@@ -11,6 +11,7 @@
  **********************************************************************/
 package org.eclipse.tracecompass.internal.lttng2.control.ui.views.dialogs;
 
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.model.impl.TraceDomainComponent;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.model.impl.TraceProviderGroup;
 
@@ -27,9 +28,9 @@ public interface IEnableEventsDialog extends IEnableKernelEvents, IEnableUstEven
     // Accessors
     // ------------------------------------------------------------------------
     /**
-     * @return the session the events shall be enabled.
+     * @return the domain type ({@link TraceDomainType})
      */
-    boolean isKernel();
+    TraceDomainType getDomain();
 
     /**
      * Sets the trace provider group.
index 77c3c22417b606730d10826b4819657163360824..ad504debb96aa9dc954b6261ebc6c526296aa7b5 100644 (file)
@@ -12,6 +12,7 @@
  **********************************************************************/
 package org.eclipse.tracecompass.internal.lttng2.control.ui.views.dialogs;
 
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.model.impl.TraceChannelComponent;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.model.impl.TraceSessionComponent;
 
@@ -38,10 +39,10 @@ public interface IGetEventInfoDialog {
     TraceChannelComponent getChannel();
 
     /**
-     * Sets flag about domain.
-     * @param isKernel - true for kernel, false for UST
+     * Sets the domain type.
+     * @param domain domain type ({@link TraceDomainType})
      */
-    void setIsKernel(boolean isKernel);
+    void setDomain(TraceDomainType domain);
 
     /**
      * Sets available session.
index b6710a0c3b3945c7f8310d5f11ab0bcb27a151b8..dda75c68f1686e09ed3462e18cd69bb3ea568d9f 100644 (file)
@@ -29,6 +29,7 @@ import org.eclipse.jface.viewers.ISelection;
 import org.eclipse.jface.viewers.StructuredSelection;
 import org.eclipse.jface.window.Window;
 import org.eclipse.tracecompass.common.core.NonNullUtils;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.Activator;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.ControlView;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.dialogs.IGetEventInfoDialog;
@@ -85,7 +86,7 @@ public class AssignEventHandler extends BaseControlViewHandler {
 
         // Open dialog box to retrieve the session and channel where the events should be enabled in.
         final IGetEventInfoDialog dialog = TraceControlDialogFactory.getInstance().getGetEventInfoDialog();
-        dialog.setIsKernel(param.isKernel());
+        dialog.setDomain(param.getDomain());
         dialog.setSessions(param.getSessions());
 
         if (dialog.open() != Window.OK) {
@@ -110,7 +111,7 @@ public class AssignEventHandler extends BaseControlViewHandler {
                     TraceChannelComponent channel = dialog.getChannel();
                     if (channel == null) {
                         // enable events on default channel (which will be created by lttng-tools)
-                        session.enableEvents(eventNames, param.isKernel(), dialog.getFilterExpression(), null, monitor);
+                        session.enableEvents(eventNames, param.getDomain(), dialog.getFilterExpression(), null, monitor);
                     } else {
                         channel.enableEvents(eventNames, dialog.getFilterExpression(), null, monitor);
                     }
@@ -140,7 +141,7 @@ public class AssignEventHandler extends BaseControlViewHandler {
     public boolean isEnabled() {
         @NonNull ArrayList<@NonNull BaseEventComponent> events = new ArrayList<>();
         @NonNull TraceSessionComponent[] sessions = null;
-        Boolean isKernel = null;
+        TraceDomainType domain = null;
 
         // Get workbench page for the Control View
         IWorkbenchPage page = getWorkbenchPage();
@@ -160,19 +161,19 @@ public class AssignEventHandler extends BaseControlViewHandler {
                     ITraceControlComponent provider = event.getParent();
 
                     // check for kernel or UST provider
-                    boolean temp = false;
+                    TraceDomainType temp = null;
                     if (provider instanceof KernelProviderComponent) {
-                        temp = true;
+                        temp = TraceDomainType.KERNEL;
                     } else if (provider instanceof UstProviderComponent) {
-                        temp = false;
+                        temp = TraceDomainType.UST;
                     } else {
                         return false;
                     }
-                    if (isKernel == null) {
-                        isKernel = Boolean.valueOf(temp);
+                    if (domain == null) {
+                        domain = temp;
                     } else {
                         // don't mix events from Kernel and UST provider
-                        if (isKernel.booleanValue() != temp) {
+                        if (!domain.equals(temp)) {
                             return false;
                         }
                     }
@@ -191,7 +192,7 @@ public class AssignEventHandler extends BaseControlViewHandler {
         boolean isEnabled = ((!events.isEmpty()) && (sessions != null) && (sessions.length > 0));
 
         // To avoid compiler warnings check for null even if isKernel is always not null when used below
-        if (isKernel == null) {
+        if (domain == null) {
             return false;
         }
 
@@ -199,7 +200,7 @@ public class AssignEventHandler extends BaseControlViewHandler {
         try {
             fParam = null;
             if(isEnabled) {
-                fParam = new Parameter(NonNullUtils.checkNotNull(sessions), events, isKernel);
+                fParam = new Parameter(NonNullUtils.checkNotNull(sessions), events, domain);
             }
         } finally {
             fLock.unlock();
@@ -224,22 +225,22 @@ public class AssignEventHandler extends BaseControlViewHandler {
         private final @NonNull TraceSessionComponent[] fSessions;
 
         /**
-         * Flag for indicating Kernel or UST.
+         * The domain type ({@link TraceDomainType})
          */
-        private final boolean fIsKernel;
+        private final TraceDomainType fDomain;
 
         /**
          * Constructor
          *
          * @param sessions - a array of trace sessions
          * @param events - a lists of events to enable
-         * @param isKernel - domain (true for kernel or UST)
+         * @param domain - domain type ({@link TraceDomainType})
          */
-        public Parameter(@NonNull TraceSessionComponent[] sessions, List<BaseEventComponent> events, boolean isKernel) {
+        public Parameter(@NonNull TraceSessionComponent[] sessions, List<BaseEventComponent> events, TraceDomainType domain) {
             fSessions = NonNullUtils.checkNotNull(Arrays.copyOf(sessions, sessions.length));
             fEvents = new ArrayList<>();
             fEvents.addAll(events);
-            fIsKernel = isKernel;
+            fDomain = domain;
         }
 
         /**
@@ -247,7 +248,7 @@ public class AssignEventHandler extends BaseControlViewHandler {
          * @param other - a parameter to copy
          */
         public Parameter(Parameter other) {
-            this(other.fSessions, other.fEvents, other.fIsKernel);
+            this(other.fSessions, other.fEvents, other.fDomain);
         }
 
         public TraceSessionComponent[] getSessions() {
@@ -258,8 +259,8 @@ public class AssignEventHandler extends BaseControlViewHandler {
             return fEvents;
         }
 
-        public boolean isKernel() {
-            return fIsKernel;
+        public TraceDomainType getDomain() {
+            return fDomain;
         }
     }
 }
index 8eb382942b17a00046b237484ff0b099b083d95e..d2bf41c543ce7cf265010aab12014134e0aba917 100644 (file)
@@ -21,6 +21,7 @@ import org.eclipse.core.runtime.IStatus;
 import org.eclipse.core.runtime.Status;
 import org.eclipse.core.runtime.jobs.Job;
 import org.eclipse.jface.window.Window;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IChannelInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.Activator;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.dialogs.IEnableChannelDialog;
@@ -58,15 +59,15 @@ abstract class BaseEnableChannelHandler extends BaseControlViewHandler {
      * @param info
      *            - channel information to set for the channel (use null for
      *            default)
-     * @param isKernel
-     *            - a flag for indicating kernel or UST.
+     * @param domain
+     *            - indicate the domain type ({@link TraceDomainType})
      * @param monitor
      *            - a progress monitor
      * @throws ExecutionException
      *             If something goes wrong when enabling the channel
      */
     public abstract void enableChannel(CommandParameter param,
-            List<String> channelNames, IChannelInfo info, boolean isKernel,
+            List<String> channelNames, IChannelInfo info, TraceDomainType domain,
             IProgressMonitor monitor) throws ExecutionException;
 
     /**
@@ -109,7 +110,7 @@ abstract class BaseEnableChannelHandler extends BaseControlViewHandler {
                 channelNames.add(dialog.getChannelInfo().getName());
 
                 try {
-                    enableChannel(param, channelNames, dialog.getChannelInfo(), dialog.isKernel(), monitor);
+                    enableChannel(param, channelNames, dialog.getChannelInfo(), dialog.getDomain(), monitor);
                 } catch (ExecutionException e) {
                     error = e;
                 }
index 3caafa43a943783da4771b148e7ddd18a9f87803..a7bff9c0c4c750ea9cf83d842040af28bcdeccbb 100644 (file)
@@ -22,6 +22,7 @@ import org.eclipse.core.runtime.Status;
 import org.eclipse.core.runtime.jobs.Job;
 import org.eclipse.jdt.annotation.Nullable;
 import org.eclipse.jface.window.Window;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.LogLevelType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceLogLevel;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.Activator;
@@ -65,8 +66,8 @@ public abstract class BaseEnableEventHandler extends BaseControlViewHandler {
      *            - a parameter instance with data for the command execution
      * @param eventNames
      *            - list of event names
-     * @param isKernel
-     *            - true if kernel domain else false
+     * @param domain
+     *            - the domain type ({@link TraceDomainType})
      * @param filterExpression
      *            - a filter expression
      * @param excludedEvents
@@ -76,7 +77,7 @@ public abstract class BaseEnableEventHandler extends BaseControlViewHandler {
      * @throws ExecutionException
      *             If the command fails for some reason
      */
-    public abstract void enableEvents(CommandParameter param, List<String> eventNames, boolean isKernel, String filterExpression,  List<String> excludedEvents, IProgressMonitor monitor) throws ExecutionException;
+    public abstract void enableEvents(CommandParameter param, List<String> eventNames, TraceDomainType domain, String filterExpression,  List<String> excludedEvents, IProgressMonitor monitor) throws ExecutionException;
 
     /**
      * Enables all syscall events.
@@ -177,15 +178,15 @@ public abstract class BaseEnableEventHandler extends BaseControlViewHandler {
                 try {
                     String filter = dialog.getFilterExpression();
                     if (dialog.isAllEvents()) {
-                        enableEvents(param, ILttngControlService.ALL_EVENTS, dialog.isKernel(), filter, dialog.getExcludedEvents(), monitor);
+                        enableEvents(param, ILttngControlService.ALL_EVENTS, dialog.getDomain(), filter, dialog.getExcludedEvents(), monitor);
                     } else if (dialog.isTracepoints()) {
                         // Enable tracepoint events
                         if (dialog.isAllTracePoints()) {
-                            enableEvents(param, null, dialog.isKernel(), filter, dialog.getExcludedEvents(), monitor);
+                            enableEvents(param, null, dialog.getDomain(), filter, dialog.getExcludedEvents(), monitor);
                         } else {
                             List<String> eventNames = dialog.getEventNames();
                             if (!eventNames.isEmpty()) {
-                                enableEvents(param, eventNames, dialog.isKernel(), filter, dialog.getExcludedEvents(), monitor);
+                                enableEvents(param, eventNames, dialog.getDomain(), filter, dialog.getExcludedEvents(), monitor);
                             }
                         }
                     }
@@ -211,7 +212,7 @@ public abstract class BaseEnableEventHandler extends BaseControlViewHandler {
                         eventNames.add(dialog.getWildcard());
 
                         if (!eventNames.isEmpty()) {
-                            enableEvents(param, eventNames, dialog.isKernel(), filter, dialog.getExcludedEvents(), monitor);
+                            enableEvents(param, eventNames, dialog.getDomain(), filter, dialog.getExcludedEvents(), monitor);
                         }
                     }
 
index 98789be7ad56c1f224d0802fe858cd54fac7f12b..bd4528d758c80851b0c5a34d649d47de67f41d1c 100644 (file)
@@ -23,6 +23,7 @@ import org.eclipse.core.runtime.Status;
 import org.eclipse.core.runtime.jobs.Job;
 import org.eclipse.jface.viewers.ISelection;
 import org.eclipse.jface.viewers.StructuredSelection;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceEnablement;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.Activator;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.ControlView;
@@ -198,7 +199,7 @@ public abstract class ChangeChannelStateHandler extends BaseControlViewHandler {
                     }
 
                     if ((channel.getState() != getNewState())) {
-                        if (channel.isKernel()) {
+                        if (channel.getDomain().equals(TraceDomainType.KERNEL)) {
                             kernelChannels.add(channel);
                             if (kernelDomain == null) {
                                 kernelDomain = (TraceDomainComponent) channel.getParent();
index 4037640f564ec325616a2a964f43009f52cd8dcf..d885b8b8d0109ef7157838849fa0bafad0c5997f 100644 (file)
@@ -188,7 +188,7 @@ public abstract class ChangeEventStateHandler extends BaseControlViewHandler {
                     // Enable command only for events of same session, same channel and domain
                     if ((!sessionName.equals(event.getSessionName())) ||
                         (!channelName.equals(event.getChannelName())) ||
-                        (channel.isKernel() != event.isKernel())) {
+                        (!channel.getDomain().equals(event.getDomain()))) {
                         events.clear();
                         break;
                     }
index 6e40f2f5473ea4d3dbc8e8d81df5910620a9619d..36ed5f99062872ad93b3e9acf2432074bc433ee9 100644 (file)
@@ -20,6 +20,7 @@ import org.eclipse.core.commands.ExecutionException;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.jface.viewers.ISelection;
 import org.eclipse.jface.viewers.StructuredSelection;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IChannelInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceSessionState;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.ControlView;
@@ -45,7 +46,7 @@ public class EnableChannelOnDomainHandler extends BaseEnableChannelHandler {
     // ------------------------------------------------------------------------
 
     @Override
-    public void enableChannel(CommandParameter param, List<String> channelNames, IChannelInfo info, boolean isKernel, IProgressMonitor monitor) throws ExecutionException {
+    public void enableChannel(CommandParameter param, List<String> channelNames, IChannelInfo info, TraceDomainType domain, IProgressMonitor monitor) throws ExecutionException {
         if (param instanceof DomainCommandParameter) {
             ((DomainCommandParameter)param).getDomain().enableChannels(channelNames, info, monitor);
         }
index fbbb47d8bbc7762248e121463ff3f494959f91f8..674b926655731c5d6a296fe234e78b3e8606926d 100644 (file)
@@ -19,6 +19,7 @@ import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.jface.viewers.ISelection;
 import org.eclipse.jface.viewers.StructuredSelection;
 import org.eclipse.tracecompass.common.core.NonNullUtils;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IChannelInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceSessionState;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.ControlView;
@@ -41,8 +42,8 @@ public class EnableChannelOnSessionHandler extends BaseEnableChannelHandler {
     // ------------------------------------------------------------------------
 
     @Override
-    public void enableChannel(CommandParameter param, List<String> channelNames, IChannelInfo info, boolean isKernel, IProgressMonitor monitor) throws ExecutionException {
-        param.getSession().enableChannels(channelNames, info, isKernel, monitor);
+    public void enableChannel(CommandParameter param, List<String> channelNames, IChannelInfo info, TraceDomainType domain, IProgressMonitor monitor) throws ExecutionException {
+        param.getSession().enableChannels(channelNames, info, domain, monitor);
     }
 
     @Override
index 2f123c73fa417c72a0a7eb75694627f34dce329e..88b7424a4c53f975f98bc918af4110c7b899c68e 100644 (file)
@@ -21,6 +21,7 @@ import org.eclipse.core.commands.ExecutionException;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.jface.viewers.ISelection;
 import org.eclipse.jface.viewers.StructuredSelection;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.LogLevelType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceLogLevel;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.ControlView;
@@ -47,7 +48,7 @@ public class EnableEventOnChannelHandler extends BaseEnableEventHandler {
     // ------------------------------------------------------------------------
 
     @Override
-    public void enableEvents(CommandParameter param, List<String> eventNames, boolean isKernel, String filterExression, List<String> excludedEvents, IProgressMonitor monitor) throws ExecutionException {
+    public void enableEvents(CommandParameter param, List<String> eventNames, TraceDomainType domain, String filterExression, List<String> excludedEvents, IProgressMonitor monitor) throws ExecutionException {
         if (param instanceof ChannelCommandParameter) {
             ((ChannelCommandParameter)param).getChannel().enableEvents(eventNames, filterExression, excludedEvents, monitor);
         }
index f391f9e91e1ae6aab4fca4a206f7b6b4c00e8948..1e1719ffb3081cbe088a254ac05bd00ac63e51f9 100644 (file)
@@ -21,6 +21,7 @@ import org.eclipse.core.commands.ExecutionException;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.jface.viewers.ISelection;
 import org.eclipse.jface.viewers.StructuredSelection;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.LogLevelType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceLogLevel;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceSessionState;
@@ -44,7 +45,7 @@ public class EnableEventOnDomainHandler extends BaseEnableEventHandler {
     // ------------------------------------------------------------------------
 
     @Override
-    public void enableEvents(CommandParameter param, List<String> eventNames, boolean isKernel, String filterExression, List<String> excludedEvents, IProgressMonitor monitor) throws ExecutionException {
+    public void enableEvents(CommandParameter param, List<String> eventNames, TraceDomainType domain, String filterExression, List<String> excludedEvents, IProgressMonitor monitor) throws ExecutionException {
         if (param instanceof DomainCommandParameter) {
             ((DomainCommandParameter)param).getDomain().enableEvents(eventNames, filterExression, excludedEvents, monitor);
         }
index 9877cb7566227fb8c7997e48eb1c14d45a6f563a..a7b484c04e2d058a4f09b5880cf53c77ee10897c 100644 (file)
@@ -20,6 +20,7 @@ import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.jface.viewers.ISelection;
 import org.eclipse.jface.viewers.StructuredSelection;
 import org.eclipse.tracecompass.common.core.NonNullUtils;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.LogLevelType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceLogLevel;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceSessionState;
@@ -47,8 +48,8 @@ public class EnableEventOnSessionHandler extends BaseEnableEventHandler {
     // ------------------------------------------------------------------------
 
     @Override
-    public void enableEvents(CommandParameter param, List<String> eventNames, boolean isKernel, String filterExpression, List<String> excludedEvents, IProgressMonitor monitor) throws ExecutionException {
-        param.getSession().enableEvents(eventNames, isKernel, filterExpression, excludedEvents, monitor);
+    public void enableEvents(CommandParameter param, List<String> eventNames, TraceDomainType domain, String filterExpression, List<String> excludedEvents, IProgressMonitor monitor) throws ExecutionException {
+        param.getSession().enableEvents(eventNames, domain, filterExpression, excludedEvents, monitor);
     }
 
     @Override
index c6ed88459909dace67db20088a828d469dc07d18..b557d678bda4db969e1f96d1bc405558b8a648b4 100644 (file)
@@ -12,6 +12,7 @@
  **********************************************************************/
 package org.eclipse.tracecompass.internal.lttng2.control.ui.views.model.impl;
 
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IBaseEventInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IFieldInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceEventType;
@@ -153,10 +154,10 @@ public class BaseEventComponent extends TraceControlComponent {
     }
 
     /**
-     * @return if provider kernel or UST
+     * @return the domain type ({@link TraceDomainType})
      */
-    public boolean isKernel() {
-        return getParent() instanceof KernelProviderComponent;
+    public TraceDomainType getDomain() {
+        return getParent() instanceof KernelProviderComponent ? TraceDomainType.KERNEL : TraceDomainType.UST;
     }
 
     // ------------------------------------------------------------------------
index 935e2f537735dc61c36543f37feda0467a368e18..1d59088f99758e1b200ba700926d0a974a403cfe 100644 (file)
@@ -21,6 +21,7 @@ import java.util.List;
 import org.eclipse.core.commands.ExecutionException;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.jdt.annotation.Nullable;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IBaseEventInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IChannelInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.ISessionInfo;
@@ -96,15 +97,15 @@ class NullControlService implements ILttngControlService {
     }
 
     @Override
-    public void enableChannels(String sessionName, List<String> channelNames, boolean isKernel, IChannelInfo info, IProgressMonitor monitor) throws ExecutionException {
+    public void enableChannels(String sessionName, List<String> channelNames, TraceDomainType domain, IChannelInfo info, IProgressMonitor monitor) throws ExecutionException {
     }
 
     @Override
-    public void disableChannels(String sessionName, List<String> channelNames, boolean isKernel, IProgressMonitor monitor) throws ExecutionException {
+    public void disableChannels(String sessionName, List<String> channelNames, TraceDomainType domain, IProgressMonitor monitor) throws ExecutionException {
     }
 
     @Override
-    public void enableEvents(String sessionName, String channelName, List<String> eventNames, boolean isKernel, String filterExpression, List<String> excludedEvents, IProgressMonitor monitor) throws ExecutionException {
+    public void enableEvents(String sessionName, String channelName, List<String> eventNames, TraceDomainType domain, String filterExpression, List<String> excludedEvents, IProgressMonitor monitor) throws ExecutionException {
     }
 
     @Override
@@ -120,7 +121,7 @@ class NullControlService implements ILttngControlService {
     }
 
     @Override
-    public void disableEvent(String sessionName, String channelName, List<String> eventNames, boolean isKernel, IProgressMonitor monitor) throws ExecutionException {
+    public void disableEvent(String sessionName, String channelName, List<String> eventNames, TraceDomainType domain, IProgressMonitor monitor) throws ExecutionException {
     }
 
     @Override
@@ -129,7 +130,7 @@ class NullControlService implements ILttngControlService {
     }
 
     @Override
-    public void addContexts(String sessionName, String channelName, String eventName, boolean isKernel, List<String> contexts, IProgressMonitor monitor) throws ExecutionException {
+    public void addContexts(String sessionName, String channelName, String eventName, TraceDomainType domain, List<String> contexts, IProgressMonitor monitor) throws ExecutionException {
     }
 
     @Override
index 37da60e5aa6545a2627b194a32c3fa7931933f47..6fb3ed053052797627b5ed86e24bc1dedbefbe0a 100644 (file)
@@ -34,6 +34,7 @@ import org.eclipse.remote.core.IRemoteConnectionChangeListener;
 import org.eclipse.remote.core.RemoteConnectionChangeEvent;
 import org.eclipse.swt.graphics.Image;
 import org.eclipse.swt.widgets.Display;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TargetNodeState;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.Activator;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.messages.Messages;
@@ -222,11 +223,11 @@ public class TargetNodeComponent extends TraceControlComponent implements IRemot
 
     /**
      * Returns if node supports filtering of events
-     * @param isKernel - <code>true</code> for kernel provider else <code>false</code>
+     * @param domain - the domain type ({@link TraceDomainType})
      * @return <code>true</code> if node supports filtering else <code>false</code>
      */
-    public boolean isEventFilteringSupported(boolean isKernel) {
-        if (isKernel) {
+    public boolean isEventFilteringSupported(TraceDomainType domain) {
+        if (domain.equals(TraceDomainType.KERNEL)) {
             return getControlService().isVersionSupported("2.7.0"); //$NON-NLS-1$
         }
         return getControlService().isVersionSupported("2.1.0"); //$NON-NLS-1$
index a390cdf3742e5a9eebe2fea332fcb5e786c429fe..02e5f803d69db3cdee87579491d93d3d3c9d620a 100644 (file)
@@ -18,6 +18,7 @@ import java.util.List;
 import org.eclipse.core.commands.ExecutionException;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.swt.graphics.Image;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IChannelInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IEventInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.LogLevelType;
@@ -266,10 +267,10 @@ public class TraceChannelComponent extends TraceControlComponent {
     }
 
     /**
-     * @return if domain is kernel or UST
+     * @return the domain type ({@link TraceDomainType})
      */
-    public boolean isKernel() {
-        return ((TraceDomainComponent)getParent()).isKernel();
+    public TraceDomainType getDomain() {
+        return ((TraceDomainComponent)getParent()).getDomain();
     }
 
     /**
@@ -312,7 +313,7 @@ public class TraceChannelComponent extends TraceControlComponent {
      *             If the command fails
      */
     public void enableEvents(List<String> eventNames, String filterExpression, List<String> excludedEvents, IProgressMonitor monitor) throws ExecutionException {
-        getControlService().enableEvents(getSessionName(), getName(), eventNames, isKernel(), filterExpression, excludedEvents, monitor);
+        getControlService().enableEvents(getSessionName(), getName(), eventNames, getDomain(), filterExpression, excludedEvents, monitor);
     }
 
     /**
@@ -381,7 +382,7 @@ public class TraceChannelComponent extends TraceControlComponent {
     public void disableEvent(List<String> eventNames, IProgressMonitor monitor)
             throws ExecutionException {
         getControlService().disableEvent(getParent().getParent().getName(),
-                getName(), eventNames, isKernel(), monitor);
+                getName(), eventNames, getDomain(), monitor);
     }
 
     /**
@@ -397,6 +398,6 @@ public class TraceChannelComponent extends TraceControlComponent {
     public void addContexts(List<String> contexts, IProgressMonitor monitor)
             throws ExecutionException {
         getControlService().addContexts(getSessionName(), getName(), null,
-                isKernel(), contexts, monitor);
+                getDomain(), contexts, monitor);
     }
 }
index b8fc8905e22f3ac04565665351908e501a9bb0de..725806af3f593f957cdc46f0fdb90151d7b6a869 100644 (file)
@@ -16,6 +16,7 @@ import java.util.List;
 
 import org.eclipse.core.commands.ExecutionException;
 import org.eclipse.core.runtime.IProgressMonitor;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IChannelInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IDomainInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.LogLevelType;
@@ -106,18 +107,20 @@ public class TraceDomainComponent extends TraceControlComponent {
     }
 
     /**
-     * @return true if domain is kernel, false for UST
+     * @return the domain type ({@link TraceDomainType})
      */
-    public boolean isKernel() {
-        return fDomainInfo.isKernel();
+    public TraceDomainType getDomain() {
+        return fDomainInfo.getDomain();
     }
 
     /**
-     * Sets whether domain is  Kernel domain or UST
-     * @param isKernel true for kernel, false for UST
+     * Sets the domain type
+     *
+     * @param domain
+     *            the domain type ({@link TraceDomainType})
      */
-    public void setIsKernel(boolean isKernel) {
-        fDomainInfo.setIsKernel(isKernel);
+    public void setDomain(TraceDomainType domain) {
+        fDomainInfo.setDomain(domain);
     }
 
     /**
@@ -177,7 +180,7 @@ public class TraceDomainComponent extends TraceControlComponent {
     public void enableChannels(List<String> channelNames, IChannelInfo info,
             IProgressMonitor monitor) throws ExecutionException {
         getControlService().enableChannels(getParent().getName(), channelNames,
-                isKernel(), info, monitor);
+                getDomain(), info, monitor);
     }
 
     /**
@@ -193,7 +196,7 @@ public class TraceDomainComponent extends TraceControlComponent {
     public void disableChannels(List<String> channelNames,
             IProgressMonitor monitor) throws ExecutionException {
         getControlService().disableChannels(getParent().getName(),
-                channelNames, isKernel(), monitor);
+                channelNames, getDomain(), monitor);
     }
 
     /**
@@ -213,7 +216,7 @@ public class TraceDomainComponent extends TraceControlComponent {
     public void enableEvents(List<String> eventNames, String filterExpression, List<String> excludedEvents, IProgressMonitor monitor)
             throws ExecutionException {
         getControlService().enableEvents(getSessionName(), null, eventNames,
-                isKernel(), filterExpression, excludedEvents, monitor);
+                getDomain(), filterExpression, excludedEvents, monitor);
     }
 
     /**
@@ -286,7 +289,7 @@ public class TraceDomainComponent extends TraceControlComponent {
     public void addContexts(List<String> contexts, IProgressMonitor monitor)
             throws ExecutionException {
         getControlService().addContexts(getSessionName(), null, null,
-                isKernel(), contexts, monitor);
+                getDomain(), contexts, monitor);
     }
 
 }
index 99966ea31199c2dc51ffe0ca8643209460493c56..33b632f83dab97ec88606afd12c6f1b052044f25 100644 (file)
@@ -17,6 +17,7 @@ import java.util.List;
 import org.eclipse.core.commands.ExecutionException;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.swt.graphics.Image;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IEventInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.LogLevelType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceEnablement;
@@ -252,10 +253,10 @@ public class TraceEventComponent extends TraceControlComponent {
     }
 
     /**
-     * @return if domain is kernel or UST
+     * @return the domain type ({@link TraceDomainType})
      */
-    public boolean isKernel() {
-        return ((TraceChannelComponent)getParent()).isKernel();
+    public TraceDomainType getDomain() {
+        return ((TraceChannelComponent)getParent()).getDomain();
     }
 
     // ------------------------------------------------------------------------
@@ -275,6 +276,6 @@ public class TraceEventComponent extends TraceControlComponent {
     public void addContexts(List<String> contexts, IProgressMonitor monitor)
             throws ExecutionException {
         getControlService().addContexts(getSessionName(), getChannelName(),
-                getName(), isKernel(), contexts, monitor);
+                getName(), getDomain(), contexts, monitor);
     }
 }
index 86ec90d416ed02755ce1bc2a031ce53d9a1db0aa..9b2188d1a821478344ae534955995388aaee435c 100644 (file)
@@ -17,6 +17,7 @@ import java.util.List;
 
 import org.eclipse.core.commands.ExecutionException;
 import org.eclipse.core.runtime.IProgressMonitor;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IBaseEventInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IUstProviderInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.ui.views.messages.Messages;
@@ -99,11 +100,11 @@ public class TraceProviderGroup extends TraceControlComponent {
 
     /**
      * Returns if node supports filtering of events
-     * @param isKernel - <code>true</code> for kernel provider else <code>false</code>
+     * @param domain - the domain type ({@link TraceDomainType})
      * @return <code>true</code> if node supports filtering else <code>false</code>
      */
-    public boolean isEventFilteringSupported(boolean isKernel) {
-        return ((TargetNodeComponent)getParent()).isEventFilteringSupported(isKernel);
+    public boolean isEventFilteringSupported(TraceDomainType domain) {
+        return ((TargetNodeComponent)getParent()).isEventFilteringSupported(domain);
     }
 }
 
index 5c1f04bf48d5c62054c7e68cfb3375b77ddc5378..909745d56b0b67e82e0b7186d00ce66b5035d0e8 100644 (file)
@@ -18,6 +18,7 @@ import java.util.List;
 import org.eclipse.core.commands.ExecutionException;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.swt.graphics.Image;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IChannelInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IDomainInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.ISessionInfo;
@@ -272,11 +273,11 @@ public class TraceSessionComponent extends TraceControlComponent {
 
     /**
      * Returns if node supports filtering of events
-     * @param isKernel - <code>true</code> for kernel provider else <code>false</code>
+     * @param domain - the domain type ({@link TraceDomainType})
      * @return <code>true</code> if node supports filtering else <code>false</code>
      */
-    public boolean isEventFilteringSupported(boolean isKernel) {
-        return ((TargetNodeComponent)getParent().getParent()).isEventFilteringSupported(isKernel);
+    public boolean isEventFilteringSupported(TraceDomainType domain) {
+        return ((TargetNodeComponent)getParent().getParent()).isEventFilteringSupported(domain);
     }
 
     /**
@@ -354,17 +355,17 @@ public class TraceSessionComponent extends TraceControlComponent {
      * @param info
      *            - channel information to set for the channel (use null for
      *            default)
-     * @param isKernel
-     *            - a flag for indicating kernel or UST.
+     * @param domain
+     *            - indicate the domain type ({@link TraceDomainType})
      * @param monitor
      *            - a progress monitor
      * @throws ExecutionException
      *             If the command fails
      */
     public void enableChannels(List<String> channelNames, IChannelInfo info,
-            boolean isKernel, IProgressMonitor monitor)
+            TraceDomainType domain, IProgressMonitor monitor)
             throws ExecutionException {
-        getControlService().enableChannels(getName(), channelNames, isKernel,
+        getControlService().enableChannels(getName(), channelNames, domain,
                 info, monitor);
     }
 
@@ -373,8 +374,8 @@ public class TraceSessionComponent extends TraceControlComponent {
      *
      * @param eventNames
      *            - a list of event names to enabled.
-     * @param isKernel
-     *            - a flag for indicating kernel or UST.
+     * @param domain
+     *            - the type of the domain type ({@link TraceDomainType})
      * @param filterExpression
      *            - a filter expression
      * @param excludedEvents
@@ -384,9 +385,9 @@ public class TraceSessionComponent extends TraceControlComponent {
      * @throws ExecutionException
      *             If the command fails
      */
-    public void enableEvents(List<String> eventNames, boolean isKernel,
+    public void enableEvents(List<String> eventNames, TraceDomainType domain,
             String filterExpression, List<String> excludedEvents, IProgressMonitor monitor) throws ExecutionException {
-        getControlService().enableEvents(getName(), null, eventNames, isKernel,
+        getControlService().enableEvents(getName(), null, eventNames, domain,
                 filterExpression, excludedEvents, monitor);
     }
 
index d236436863080e1e738f0f864661cead8e1cbe2a..0cf1dac3769e1265a3565884d1b28244f2dcd35e 100644 (file)
@@ -19,6 +19,7 @@ import org.eclipse.core.commands.ExecutionException;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.jdt.annotation.NonNull;
 import org.eclipse.jdt.annotation.Nullable;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IBaseEventInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IChannelInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.ISessionInfo;
@@ -193,9 +194,8 @@ public interface ILttngControlService {
      *            - a session name to create
      * @param channelNames
      *            - a list of channel names to be enabled
-     * @param isKernel
-     *            - a flag to indicate Kernel or UST (true for Kernel, false for
-     *            UST)
+     * @param domain
+     *            - indicate the domain type ({@link TraceDomainType})
      * @param info
      *            - channel information used for creation of a channel (or null
      *            for default)
@@ -205,7 +205,7 @@ public interface ILttngControlService {
      *             If the command fails
      */
     void enableChannels(String sessionName, List<String> channelNames,
-            boolean isKernel, IChannelInfo info, IProgressMonitor monitor)
+            TraceDomainType domain, IChannelInfo info, IProgressMonitor monitor)
             throws ExecutionException;
 
     /**
@@ -216,16 +216,15 @@ public interface ILttngControlService {
      *            - a session name to create
      * @param channelNames
      *            - a list of channel names to be enabled
-     * @param isKernel
-     *            - a flag to indicate Kernel or UST (true for Kernel, false for
-     *            UST)
+     * @param domain
+     *            - indicate the domain type ({@link TraceDomainType})
      * @param monitor
      *            - a progress monitor
      * @throws ExecutionException
      *             If the command fails
      */
     void disableChannels(String sessionName, List<String> channelNames,
-            boolean isKernel, IProgressMonitor monitor)
+            TraceDomainType domain, IProgressMonitor monitor)
             throws ExecutionException;
 
     /**
@@ -238,8 +237,8 @@ public interface ILttngControlService {
      * @param eventNames
      *            - a list of event names to be enabled, or null (list of size =
      *            0)for all events .
-     * @param isKernel
-     *            - a flag for indicating kernel or UST.
+     * @param domain
+     *            - indicate the domain type ({@link TraceDomainType})
      * @param filterExpression
      *            - a filter expression
      * @param excludedEvents
@@ -250,7 +249,7 @@ public interface ILttngControlService {
      *             If the command fails
      */
     void enableEvents(String sessionName, String channelName,
-            List<String> eventNames, boolean isKernel, String filterExpression, List<String> excludedEvents,
+            List<String> eventNames, TraceDomainType domain, String filterExpression, List<String> excludedEvents,
             IProgressMonitor monitor)
             throws ExecutionException;
 
@@ -326,15 +325,15 @@ public interface ILttngControlService {
      *            - a channel name (null for default channel)
      * @param eventNames
      *            - a list of event names to enabled.
-     * @param isKernel
-     *            - a flag for indicating kernel or UST.
+     * @param domain
+     *            - indicate the domain type ({@link TraceDomainType})
      * @param monitor
      *            - a progress monitor
      * @throws ExecutionException
      *             If the command fails
      */
     void disableEvent(String sessionName, String channelName,
-            List<String> eventNames, boolean isKernel, IProgressMonitor monitor)
+            List<String> eventNames, TraceDomainType domain, IProgressMonitor monitor)
             throws ExecutionException;
 
     /**
@@ -358,8 +357,8 @@ public interface ILttngControlService {
      *            - a channel name (null for all channels)
      * @param eventName
      *            - a event name (null for all events)
-     * @param isKernel
-     *            - a flag for indicating kernel or UST.
+     * @param domain
+     *            - indicate the domain type ({@link TraceDomainType})
      * @param contexts
      *            - a list of name of contexts to add
      * @param monitor
@@ -368,7 +367,7 @@ public interface ILttngControlService {
      *             If the command fails
      */
     void addContexts(String sessionName, String channelName,
-            String eventName, boolean isKernel, List<String> contexts,
+            String eventName, TraceDomainType domain, List<String> contexts,
             IProgressMonitor monitor) throws ExecutionException;
 
     /**
index 8ce198ffd72ea402766d37285d8a7a5a5e6c77ea..b73c2d3ac3617224301a8e4b64598bfe3d2c1602 100644 (file)
@@ -30,6 +30,7 @@ import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.NullProgressMonitor;
 import org.eclipse.jdt.annotation.NonNull;
 import org.eclipse.jdt.annotation.Nullable;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IBaseEventInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IChannelInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IDomainInfo;
@@ -251,8 +252,8 @@ public class LTTngControlService implements ILttngControlService {
                 // Create Domain
                 IDomainInfo domainInfo = new DomainInfo(Messages.TraceControl_KernelDomainDisplayName);
 
-                // set kernel flag
-                domainInfo.setIsKernel(true);
+                // set kernel domain
+                domainInfo.setDomain(TraceDomainType.KERNEL);
 
                 // in domain kernel
                 ArrayList<IChannelInfo> channels = new ArrayList<>();
@@ -272,8 +273,8 @@ public class LTTngControlService implements ILttngControlService {
             if (matcher.matches()) {
                 IDomainInfo domainInfo = new DomainInfo(Messages.TraceControl_UstGlobalDomainDisplayName);
 
-                // set kernel flag
-                domainInfo.setIsKernel(false);
+                // set kernel domain
+                domainInfo.setDomain(TraceDomainType.UST);
 
                 // in domain UST
                 ArrayList<IChannelInfo> channels = new ArrayList<>();
@@ -668,7 +669,7 @@ public class LTTngControlService implements ILttngControlService {
     }
 
     @Override
-    public void enableChannels(String sessionName, List<String> channelNames, boolean isKernel, IChannelInfo info, IProgressMonitor monitor) throws ExecutionException {
+    public void enableChannels(String sessionName, List<String> channelNames, TraceDomainType domain, IChannelInfo info, IProgressMonitor monitor) throws ExecutionException {
 
         // no channels to enable
         if (channelNames.isEmpty()) {
@@ -679,10 +680,19 @@ public class LTTngControlService implements ILttngControlService {
 
         command.add(toCsv(channelNames));
 
-        if (isKernel) {
+        switch (domain) {
+        case KERNEL:
             command.add(LTTngControlServiceConstants.OPTION_KERNEL);
-        } else {
+            break;
+        case UST:
             command.add(LTTngControlServiceConstants.OPTION_UST);
+            break;
+        case JUL:
+        case LOG4J:
+        case PYTHON:
+        case UNKNOWN:
+        default:
+            break;
         }
 
         command.add(LTTngControlServiceConstants.OPTION_SESSION);
@@ -723,7 +733,7 @@ public class LTTngControlService implements ILttngControlService {
             if (isVersionSupported("2.2.0")) { //$NON-NLS-1$
                 // --buffers-uid Every application sharing the same UID use the
                 // same buffers --buffers-pid Buffers are allocated per PID
-                if (!isKernel) {
+                if (domain.equals(TraceDomainType.UST)) {
                     if (info.getBufferType() == BufferType.BUFFER_PER_PID) {
                         command.add(LTTngControlServiceConstants.OPTION_PER_PID_BUFFERS);
 
@@ -751,7 +761,7 @@ public class LTTngControlService implements ILttngControlService {
     }
 
     @Override
-    public void disableChannels(String sessionName, List<String> channelNames, boolean isKernel, IProgressMonitor monitor) throws ExecutionException {
+    public void disableChannels(String sessionName, List<String> channelNames, TraceDomainType domain, IProgressMonitor monitor) throws ExecutionException {
 
         // no channels to enable
         if (channelNames.isEmpty()) {
@@ -762,10 +772,20 @@ public class LTTngControlService implements ILttngControlService {
 
         command.add(toCsv(channelNames));
 
-        if (isKernel) {
+        switch (domain) {
+        case KERNEL:
             command.add(LTTngControlServiceConstants.OPTION_KERNEL);
-        } else {
+            break;
+        case UST:
             command.add(LTTngControlServiceConstants.OPTION_UST);
+            break;
+        case JUL:
+        case LOG4J:
+        case PYTHON:
+        case UNKNOWN:
+        default:
+            break;
+
         }
 
         command.add(LTTngControlServiceConstants.OPTION_SESSION);
@@ -775,7 +795,7 @@ public class LTTngControlService implements ILttngControlService {
     }
 
     @Override
-    public void enableEvents(String sessionName, String channelName, List<String> eventNames, boolean isKernel, String filterExpression, List<String> excludedEvents, IProgressMonitor monitor) throws ExecutionException {
+    public void enableEvents(String sessionName, String channelName, List<String> eventNames, TraceDomainType domain, String filterExpression, List<String> excludedEvents, IProgressMonitor monitor) throws ExecutionException {
 
         ICommandInput command = createCommand(LTTngControlServiceConstants.COMMAND_ENABLE_EVENT);
         boolean isAllEvents = ALL_EVENTS.equals(eventNames);
@@ -786,10 +806,19 @@ public class LTTngControlService implements ILttngControlService {
             command.add(toCsv(eventNames));
         }
 
-        if (isKernel) {
+        switch (domain) {
+        case KERNEL:
             command.add(LTTngControlServiceConstants.OPTION_KERNEL);
-        } else {
+            break;
+        case UST:
             command.add(LTTngControlServiceConstants.OPTION_UST);
+            break;
+        case JUL:
+        case LOG4J:
+        case PYTHON:
+        case UNKNOWN:
+        default:
+            break;
         }
 
         command.add(LTTngControlServiceConstants.OPTION_SESSION);
@@ -892,7 +921,7 @@ public class LTTngControlService implements ILttngControlService {
     }
 
     @Override
-    public void disableEvent(String sessionName, String channelName, List<String> eventNames, boolean isKernel, IProgressMonitor monitor) throws ExecutionException {
+    public void disableEvent(String sessionName, String channelName, List<String> eventNames, TraceDomainType domain, IProgressMonitor monitor) throws ExecutionException {
         ICommandInput command = createCommand(LTTngControlServiceConstants.COMMAND_DISABLE_EVENT);
 
         if (eventNames == null) {
@@ -914,10 +943,19 @@ public class LTTngControlService implements ILttngControlService {
             command.add(eventNameParameter.toString());
         }
 
-        if (isKernel) {
+        switch (domain) {
+        case KERNEL:
             command.add(LTTngControlServiceConstants.OPTION_KERNEL);
-        } else {
+            break;
+        case UST:
             command.add(LTTngControlServiceConstants.OPTION_UST);
+            break;
+        case JUL:
+        case LOG4J:
+        case PYTHON:
+        case UNKNOWN:
+        default:
+            break;
         }
 
         command.add(LTTngControlServiceConstants.OPTION_SESSION);
@@ -966,7 +1004,7 @@ public class LTTngControlService implements ILttngControlService {
     }
 
     @Override
-    public void addContexts(String sessionName, String channelName, String eventName, boolean isKernel, List<String> contextNames, IProgressMonitor monitor) throws ExecutionException {
+    public void addContexts(String sessionName, String channelName, String eventName, TraceDomainType domain, List<String> contextNames, IProgressMonitor monitor) throws ExecutionException {
         ICommandInput command = createCommand(LTTngControlServiceConstants.COMMAND_ADD_CONTEXT);
 
         command.add(LTTngControlServiceConstants.OPTION_SESSION);
@@ -982,10 +1020,19 @@ public class LTTngControlService implements ILttngControlService {
             command.add(eventName);
         }
 
-        if (isKernel) {
+        switch (domain) {
+        case KERNEL:
             command.add(LTTngControlServiceConstants.OPTION_KERNEL);
-        } else {
+            break;
+        case UST:
             command.add(LTTngControlServiceConstants.OPTION_UST);
+            break;
+        case JUL:
+        case LOG4J:
+        case PYTHON:
+        case UNKNOWN:
+        default:
+            break;
         }
 
         for (Iterator<String> iterator = contextNames.iterator(); iterator.hasNext();) {
@@ -1141,7 +1188,7 @@ public class LTTngControlService implements ILttngControlService {
         int index = currentIndex;
 
         // if kernel set the buffer type to shared
-        if (domainInfo.isKernel()) {
+        if (domainInfo.getDomain().equals(TraceDomainType.KERNEL)) {
             domainInfo.setBufferType(BufferType.BUFFER_SHARED);
         }
 
index b5a3b08f1d21e9ef8b2d245567a4624d64cb8a9c..2d18b6f226cf4fa4438807caede66ed197380419 100644 (file)
@@ -36,6 +36,7 @@ import org.eclipse.jdt.annotation.NonNull;
 import org.eclipse.jdt.annotation.Nullable;
 import org.eclipse.osgi.util.NLS;
 import org.eclipse.tracecompass.common.core.NonNullUtils;
+import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IBaseEventInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IChannelInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IDomainInfo;
@@ -46,7 +47,6 @@ import org.eclipse.tracecompass.internal.lttng2.control.core.model.ISessionInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.ISnapshotInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.IUstProviderInfo;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.LogLevelType;
-import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceDomainType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceEnablement;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceEventType;
 import org.eclipse.tracecompass.internal.lttng2.control.core.model.TraceLogLevel;
@@ -375,11 +375,11 @@ public class LTTngControlServiceMI extends LTTngControlService {
         switch (domainType) {
         case KERNEL:
             domain = new DomainInfo(Messages.TraceControl_KernelProviderDisplayName);
-            domain.setIsKernel(true);
+            domain.setDomain(TraceDomainType.KERNEL);
             break;
         case UST:
             domain = new DomainInfo(Messages.TraceControl_UstGlobalDomainDisplayName);
-            domain.setIsKernel(false);
+            domain.setDomain(TraceDomainType.UST);
             break;
         case JUL:
             /**
@@ -388,12 +388,13 @@ public class LTTngControlServiceMI extends LTTngControlService {
              * JUL domain only events. The channel is activated in UST Channel
              */
             domain = new DomainInfo(Messages.TraceControl_JULDomainDisplayName);
-            domain.setIsKernel(false);
+            domain.setDomain(TraceDomainType.JUL);
             break;
         case UNKNOWN:
             domain = new DomainInfo(Messages.TraceControl_UnknownDomainDisplayName);
-            domain.setIsKernel(false);
+            domain.setDomain(TraceDomainType.UNKNOWN);
             break;
+            //$CASES-OMITTED$
         default:
             throw new ExecutionException(Messages.TraceControl_MiInvalidElementError);
         }
This page took 0.073957 seconds and 5 git commands to generate.