Remove cleanups from link_callbacks_einfo

This removes a cleanup from link_callbacks_einfo by using std::string.

gdb/ChangeLog
2017-11-04  Tom Tromey  <tom@tromey.com>

	* compile/compile-object-load.c (link_callbacks_einfo): Use
	std::string.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f7d821c1e27055c584195406d998c314877a212a..af1ef2489e637297177ba7a546012dc066979dd9 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2017-11-04  Tom Tromey  <tom@tromey.com>
+
+       * compile/compile-object-load.c (link_callbacks_einfo): Use
+       std::string.
+
 2017-11-04  Tom Tromey  <tom@tromey.com>
 
        * dwarf2read.c (process_full_comp_unit, process_full_type_unit):

diff --git a/gdb/compile/compile-object-load.c b/gdb/compile/compile-object-load.c
index 41d5fc347fb7a55687c38d554bfe26c091f58920..8e55d3c2c9f22ab7b6132a6e9ecf4b1a519e3e9e 100644 (file)
--- a/gdb/compile/compile-object-load.c
+++ b/gdb/compile/compile-object-load.c
@@ -281,18 +281,13 @@ static void link_callbacks_einfo (const char *fmt, ...)
 static void
 link_callbacks_einfo (const char *fmt, ...)
 {
-  struct cleanup *cleanups;
   va_list ap;
-  char *str;
 
   va_start (ap, fmt);
-  str = xstrvprintf (fmt, ap);
+  std::string str = string_vprintf (fmt, ap);
   va_end (ap);
-  cleanups = make_cleanup (xfree, str);
-
-  warning (_("Compile module: warning: %s"), str);
 
-  do_cleanups (cleanups);
+  warning (_("Compile module: warning: %s"), str.c_str ());
 }
 
 /* Helper for bfd_get_relocated_section_contents.