tmf: Only keep the full constructor in TmfEventField
authorAlexandre Montplaisir <alexmonthy@voxpopuli.im>
Mon, 8 Apr 2013 19:43:23 +0000 (15:43 -0400)
committerAlexandre Montplaisir <alexmonthy@voxpopuli.im>
Mon, 22 Apr 2013 19:42:59 +0000 (15:42 -0400)
It's relatively risky to have two methods (in this case constructors)
where one uses 'Object' and the other 'ITmfEventField[]', since
an array is also an Object, so one constructor overloads the other.

We've had problems in the past with CtfTmfEventField, and it was
changed to only keep one constructor with all three arguments.
Propagate this change up to TmfEventField, and fixes all callers.
It's now much clearer what type of field we are constructing.

Change-Id: I3c19b9fffb53905f228f71b67200400c1ccc43ae
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11734

21 files changed:
org.eclipse.linuxtools.gdbtrace.core/src/org/eclipse/linuxtools/internal/gdbtrace/core/event/GdbTraceEventContent.java
org.eclipse.linuxtools.gdbtrace.ui/src/org/eclipse/linuxtools/internal/gdbtrace/ui/views/events/GdbEventsTable.java
org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/viewers/events/LTTng2EventsTable.java
org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/ctfadaptor/CtfTmfEventTypeTest.java
org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/event/TmfEventFieldTest.java
org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/event/TmfEventTest.java
org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/uml2sd/TmfAsyncSequenceDiagramEventTest.java
org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/uml2sd/TmfSyncSequenceDiagramEventTest.java
org.eclipse.linuxtools.tmf.core.tests/stubs/org/eclipse/linuxtools/tmf/tests/stubs/event/TmfEventTypeStub.java
org.eclipse.linuxtools.tmf.core.tests/stubs/org/eclipse/linuxtools/tmf/tests/stubs/trace/TmfEventParserStub.java
org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/CtfTmfEvent.java
org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/CtfTmfEventFactory.java
org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/event/TmfEventField.java
org.eclipse.linuxtools.tmf.ui.tests/src/org/eclipse/linuxtools/tmf/ui/tests/statistics/TmfBaseColumnDataProviderTest.java
org.eclipse.linuxtools.tmf.ui.tests/src/org/eclipse/linuxtools/tmf/ui/tests/statistics/TmfBaseStatisticsDataTest.java
org.eclipse.linuxtools.tmf.ui.tests/src/org/eclipse/linuxtools/tmf/ui/tests/statistics/TmfTreeContentProviderTest.java
org.eclipse.linuxtools.tmf.ui.tests/widgetStubs/org/eclipse/linuxtools/tmf/ui/tests/uml2sd/trace/TmfUml2SDTestTrace.java
org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomEvent.java
org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomEventContent.java
org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/parsers/custom/CustomEventType.java
org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsTable.java

index bac5fc8bd641ecb0dce1bdae900a73356ddeb6ee..13b5505186464df55319fd55e747d1b2666dedee 100644 (file)
@@ -47,9 +47,9 @@ public class GdbTraceEventContent extends TmfEventField {
         super(ITmfEventField.ROOT_FIELD_ID,
                 content.replaceAll("\r?\n", " | "), //$NON-NLS-1$ //$NON-NLS-2$
                 new ITmfEventField[] {
-                    new TmfEventField(TRACE_FRAME, frameNumber),
-                    new TmfEventField(TRACEPOINT, tracepointNumber)}
-                );
+                        new TmfEventField(TRACE_FRAME, frameNumber, null),
+                        new TmfEventField(TRACEPOINT, tracepointNumber, null)
+                });
 
         fTracepointNumber = tracepointNumber;
         fFrameNumber = frameNumber;
index 03b54d18f352a41fa83559a4ce133be7864434c4..f4e06c18e10e4c40764cd8583a99a7991a43e052 100644 (file)
@@ -115,10 +115,10 @@ public class GdbEventsTable extends TmfEventsTable {
         if (event != null) {
             GdbTraceEventContent content = (GdbTraceEventContent) event.getContent();
             fields = new TmfEventField[] {
-                    new TmfEventField(TRACE_FRAME_COLUMN, content.getFrameNumber()),
-                    new TmfEventField(TRACEPOINT_COLUMN, content.getTracepointNumber()),
-                    new TmfEventField(FILE_COLUMN, event.getReference()),
-                    new TmfEventField(CONTENT_COLUMN, content.toString())
+                    new TmfEventField(TRACE_FRAME_COLUMN, content.getFrameNumber(), null),
+                    new TmfEventField(TRACEPOINT_COLUMN, content.getTracepointNumber(), null),
+                    new TmfEventField(FILE_COLUMN, event.getReference(), null),
+                    new TmfEventField(CONTENT_COLUMN, content.toString(), null)
             };
         }
         return fields;
index a2420bd1d4a425f52eaa441ee2572e7e0b755660..9027bd732fd59fa4d6dd27c24c524407f4135fbf 100644 (file)
@@ -73,10 +73,10 @@ public class LTTng2EventsTable extends TmfEventsTable {
         ITmfEventField[] fields = new TmfEventField[0];
         if (event != null) {
             fields = new TmfEventField[] {
-                     new TmfEventField(ITmfEvent.EVENT_FIELD_TIMESTAMP, event.getTimestamp().toString()),
-                     new TmfEventField(ITmfEvent.EVENT_FIELD_REFERENCE, event.getReference()),
-                     new TmfEventField(ITmfEvent.EVENT_FIELD_TYPE, event.getType().getName()),
-                     new TmfEventField(ITmfEvent.EVENT_FIELD_CONTENT, event.getContent().toString())
+                     new TmfEventField(ITmfEvent.EVENT_FIELD_TIMESTAMP, event.getTimestamp().toString(), null),
+                     new TmfEventField(ITmfEvent.EVENT_FIELD_REFERENCE, event.getReference(), null),
+                     new TmfEventField(ITmfEvent.EVENT_FIELD_TYPE, event.getType().getName(), null),
+                     new TmfEventField(ITmfEvent.EVENT_FIELD_CONTENT, event.getContent().toString(), null)
                     };
         }
         return fields;
index 06753e7621fad9d0714d9d23889c946e2d1a0438..7c601b446053e5e134a04b06b2c83eac45a3b858 100644 (file)
@@ -36,7 +36,7 @@ public class CtfTmfEventTypeTest {
     @Test
     public void testCtfTmfEventType() {
         String eventName = "";
-        ITmfEventField content = new TmfEventField("", new ITmfEventField[] {});
+        ITmfEventField content = new TmfEventField("", null, new ITmfEventField[] {});
         CtfTmfEventType result = new CtfTmfEventType( eventName, content);
 
         assertNotNull(result);
@@ -50,7 +50,7 @@ public class CtfTmfEventTypeTest {
      */
     @Test
     public void testToString() {
-        ITmfEventField emptyField = new TmfEventField("", new ITmfEventField[] {});
+        ITmfEventField emptyField = new TmfEventField("", null, new ITmfEventField[] {});
         CtfTmfEventType fixture = new CtfTmfEventType("", emptyField);
 
         String result = fixture.toString();
index 97ee56b83120431dd1c4a13241b90a03a447a213..c615a8fb1a2b0f2f666d0aa62721385c26f9de3f 100644 (file)
@@ -41,21 +41,21 @@ public class TmfEventFieldTest {
     private final Object fValue1 = "Value";
     private final Object fValue2 = Integer.valueOf(10);
 
-    private final TmfEventField fField1 = new TmfEventField(fFieldName1, fValue1);
+    private final TmfEventField fField1 = new TmfEventField(fFieldName1, fValue1, null);
     private final TmfEventField fField2 = new TmfEventField(fFieldName2, fValue2, null);
     private final TmfEventField fField3 = new TmfEventField(fFieldName1, fValue2, null);
 
     private final String fStructRootFieldName = "Root-S";
     private final String[] fStructFieldNames = new String[] { fFieldName1, fFieldName2 };
-    private final TmfEventField fStructTerminalField1 = new TmfEventField(fFieldName1, null);
-    private final TmfEventField fStructTerminalField2 = new TmfEventField(fFieldName2, null);
-    private final TmfEventField fStructTerminalField3 = new TmfEventField(fFieldName1, null);
-    private final TmfEventField fStructRootField = new TmfEventField(fStructRootFieldName,
+    private final TmfEventField fStructTerminalField1 = new TmfEventField(fFieldName1, null, null);
+    private final TmfEventField fStructTerminalField2 = new TmfEventField(fFieldName2, null, null);
+    private final TmfEventField fStructTerminalField3 = new TmfEventField(fFieldName1, null, null);
+    private final TmfEventField fStructRootField = new TmfEventField(fStructRootFieldName, null,
             new ITmfEventField[] { fStructTerminalField1, fStructTerminalField2 });
 
     private final String fRootFieldName = "Root";
     private final String[] fFieldNames = new String[] { fFieldName1, fFieldName2 };
-    private final TmfEventField fRootField = new TmfEventField(fRootFieldName,
+    private final TmfEventField fRootField = new TmfEventField(fRootFieldName, null,
             new ITmfEventField[] { fField1, fField2 });
 
     // ------------------------------------------------------------------------
@@ -265,16 +265,16 @@ public class TmfEventFieldTest {
 
     @Test
     public void testNonEqualValues() {
-        final TmfEventField copy1 = new TmfEventField(fFieldName1, fValue1);
-        TmfEventField copy2 = new TmfEventField(fFieldName1, fValue1);
+        final TmfEventField copy1 = new TmfEventField(fFieldName1, fValue1, null);
+        TmfEventField copy2 = new TmfEventField(fFieldName1, fValue1, null);
         assertTrue("equals", copy1.equals(copy2));
         assertTrue("equals", copy2.equals(copy1));
 
-        copy2 = new TmfEventField(fFieldName1, fValue2);
+        copy2 = new TmfEventField(fFieldName1, fValue2, null);
         assertFalse("equals", copy1.equals(copy2));
         assertFalse("equals", copy2.equals(copy1));
 
-        copy2 = new TmfEventField(fFieldName1, null);
+        copy2 = new TmfEventField(fFieldName1, null, null);
         assertFalse("equals", copy1.equals(copy2));
         assertFalse("equals", copy2.equals(copy1));
     }
index ce9ffbc7516b31ac586b3af0678049bb6d48ec1f..5a22bc6b36e25cbbcf10b90c4c71a8ef89aebfed 100644 (file)
@@ -63,22 +63,22 @@ public class TmfEventTest {
 
     private final Object fValue1a = "Some string";
     private final Object fValue1b = Integer.valueOf(10);
-    private final ITmfEventField fField1a = new TmfEventField(fLabel1, fValue1a);
-    private final ITmfEventField fField1b = new TmfEventField(fLabel2, fValue1b);
+    private final ITmfEventField fField1a = new TmfEventField(fLabel1, fValue1a, null);
+    private final ITmfEventField fField1b = new TmfEventField(fLabel2, fValue1b, null);
     private final ITmfEventField[] fFields1 = new ITmfEventField[] { fField1a, fField1b };
     private final String fRawContent1 = fField1a.toString() + fField1b.toString();
-    private final ITmfEventField fContent1 = new TmfEventField(fRawContent1, fFields1);
+    private final ITmfEventField fContent1 = new TmfEventField(fRawContent1, null, fFields1);
     private final TmfTimestamp fTimestamp1 = new TmfTimestamp(12345, 2, 5);
     private final String fReference1 = "Some reference";
     private final ITmfEvent fEvent1 = new TmfEvent(null, 0, fTimestamp1, fSource, fType, fContent1, fReference1);
 
     private final Object fValue2a = "Another string";
     private final Object fValue2b = Integer.valueOf(-4);
-    private final ITmfEventField fField2a = new TmfEventField(fLabel1, fValue2a);
-    private final ITmfEventField fField2b = new TmfEventField(fLabel2, fValue2b);
+    private final ITmfEventField fField2a = new TmfEventField(fLabel1, fValue2a, null);
+    private final ITmfEventField fField2b = new TmfEventField(fLabel2, fValue2b, null);
     private final ITmfEventField[] fFields2 = new ITmfEventField[] { fField2a, fField2b };
     private final String fRawContent2 = fField2a.toString() + fField2b.toString();
-    private final ITmfEventField fContent2 = new TmfEventField(fRawContent2, fFields2);
+    private final ITmfEventField fContent2 = new TmfEventField(fRawContent2, null, fFields2);
     private final TmfTimestamp fTimestamp2 = new TmfTimestamp(12350, 2, 5);
     private final String fReference2 = "Some other reference";
     private final ITmfEvent fEvent2 = new TmfEvent(null, 1, fTimestamp2, fSource, fType, fContent2, fReference2);
index a47ee19db59936dcf434912b50a7a84d826fe663..8c0d54c6d74bf076d4be6baf46ed6c9d619de535 100644 (file)
@@ -54,10 +54,10 @@ public class TmfAsyncSequenceDiagramEventTest {
      * Constructor for the test case
      */
     public TmfAsyncSequenceDiagramEventTest() {
-        fContent1 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some content");
+        fContent1 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some content", null);
         fEvent1 = new TmfEvent(null, fTimestamp1, fSource, fType, fContent1, fReference);
 
-        fContent2 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some other content");
+        fContent2 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some other content", null);
         fEvent2 = new TmfEvent(null, fTimestamp2, fSource, fType, fContent2, fReference);
     }
 
index e2a008d5f0ef73cba4229cdaf7252a28378ac1ab..b8a6b157d4c44307c39bb6032c8e004b6b82529f 100644 (file)
@@ -51,7 +51,7 @@ public class TmfSyncSequenceDiagramEventTest {
      * Constructor for the test case
      */
     public TmfSyncSequenceDiagramEventTest() {
-        fContent1 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some content");
+        fContent1 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some content", null);
         fEvent1 = new TmfEvent(null, fTimestamp1, fSource, fType, fContent1, fReference);
     }
 
index 1e57a6642a687dfdf4c2d98226614bc868a746d8..5d65e3bdbe5ff55c0ff2f4665f1a98f0758d0ebf 100644 (file)
@@ -21,16 +21,16 @@ import org.eclipse.linuxtools.tmf.core.event.TmfEventType;
 @SuppressWarnings("javadoc")
 public class TmfEventTypeStub extends TmfEventType {
 
-    private static final ITmfEventField FIELD_1 = new TmfEventField("Field1", null);
-    private static final ITmfEventField FIELD_2 = new TmfEventField("Field2", null);
-    private static final ITmfEventField FIELD_3 = new TmfEventField("Field3", null);
-    private static final ITmfEventField FIELD_4 = new TmfEventField("Field4", null);
-    private static final ITmfEventField FIELD_5 = new TmfEventField("Field5", null);
+    private static final ITmfEventField FIELD_1 = new TmfEventField("Field1", null, null);
+    private static final ITmfEventField FIELD_2 = new TmfEventField("Field2", null, null);
+    private static final ITmfEventField FIELD_3 = new TmfEventField("Field3", null, null);
+    private static final ITmfEventField FIELD_4 = new TmfEventField("Field4", null, null);
+    private static final ITmfEventField FIELD_5 = new TmfEventField("Field5", null, null);
 
     private static final ITmfEventField[] FIELDS = new ITmfEventField[] {
         FIELD_1, FIELD_2, FIELD_3, FIELD_4, FIELD_5 };
 
-    private static ITmfEventField ROOT = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, FIELDS);
+    private static ITmfEventField ROOT = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, null,  FIELDS);
 
     public TmfEventTypeStub() {
         super("UnitTest", "TmfEventTypeStub", ROOT);
index 4a136ab420c09c102036abf58df444b34f7b1ec1..7214299540f732b0781799a08fe0819333222c29 100644 (file)
@@ -106,7 +106,7 @@ public class TmfEventParserStub implements ITmfEventParser {
                 }
                 content.append("]");
 
-                final TmfEventField root = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, content.toString());
+                final TmfEventField root = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, content.toString(), null);
                 final ITmfEvent event = new TmfEvent(fEventStream,
                         new TmfTimestamp(ts, -3, 0),     // millisecs
                         source, fTypes[typeIndex], root, reference.toString());
index 2b8aff967edd05d1b654610b0d4e1f5fc8d146e3..9d8488900b489fee725236e5ccb67816756cbe22 100644 (file)
@@ -93,7 +93,7 @@ public final class CtfTmfEvent extends TmfEvent implements ITmfSourceLookup, ITm
                 new CtfTmfTimestamp(-1),
                 null,
                 null,
-                new TmfEventField("", new CtfTmfEventField[0]), //$NON-NLS-1$
+                new TmfEventField("", null, new CtfTmfEventField[0]), //$NON-NLS-1$
                 NO_STREAM);
         this.sourceCPU = -1;
         this.typeId = -1;
index 6071f9bd0937cce0baac29a9796b56c730b72349..ead52312832ea6d27d177c953761107eb470b711 100644 (file)
@@ -61,7 +61,7 @@ public final class CtfTmfEventFactory {
         int sourceCPU = eventDef.getCPU();
 
         ITmfEventField content = new TmfEventField(
-                ITmfEventField.ROOT_FIELD_ID, parseFields(eventDef));
+                ITmfEventField.ROOT_FIELD_ID, null, parseFields(eventDef));
 
         String reference = fileName == null ? CtfTmfEvent.NO_STREAM : fileName;
 
index eb46ae1e1f4298b4c948d6b02d963a672fcc954e..aa62945166838a4f7b10102a470e3a111c9202a0 100644 (file)
@@ -46,26 +46,6 @@ public class TmfEventField implements ITmfEventField {
     // Constructors
     // ------------------------------------------------------------------------
 
-    /**
-     * Constructor for a structural field
-     *
-     * @param name the event field id
-     * @param fields the list of subfields
-     */
-    public TmfEventField(final String name, final ITmfEventField[] fields) {
-        this(name, null, fields);
-    }
-
-    /**
-     * Constructor for a terminal field (no subfields)
-     *
-     * @param name the event field id
-     * @param value the event field value
-     */
-    public TmfEventField(final String name, final Object value) {
-        this(name, value, null);
-    }
-
     /**
      * Full constructor
      *
@@ -189,10 +169,10 @@ public class TmfEventField implements ITmfEventField {
     public final static ITmfEventField makeRoot(final String[] labels) {
         final ITmfEventField[] fields = new ITmfEventField[labels.length];
         for (int i = 0; i < labels.length; i++) {
-            fields[i] = new TmfEventField(labels[i], null);
+            fields[i] = new TmfEventField(labels[i], null, null);
         }
         // Return a new root field;
-        return new TmfEventField(ITmfEventField.ROOT_FIELD_ID, fields);
+        return new TmfEventField(ITmfEventField.ROOT_FIELD_ID, null, fields);
     }
 
     // ------------------------------------------------------------------------
index 19fec89add7511086ab2504a85bac55cb1e55153..e8a07fa5fa8adcfed7e7c4c424cc3c510790861c 100644 (file)
@@ -95,13 +95,13 @@ public class TmfBaseColumnDataProviderTest {
      * Constructor
      */
     public TmfBaseColumnDataProviderTest() {
-        fContent1 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some content");
+        fContent1 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some content", null);
         fEvent1 = new TmfEvent(null, fTimestamp1, fSource, fType1, fContent1, fReference);
 
-        fContent2 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some other content");
+        fContent2 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some other content", null);
         fEvent2 = new TmfEvent(null, fTimestamp2, fSource, fType2, fContent2, fReference);
 
-        fContent3 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some other different content");
+        fContent3 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some other different content", null);
         fEvent3 = new TmfEvent(null, fTimestamp3, fSource, fType3, fContent3, fReference);
 
         fStatsData = new TmfStatisticsTree();
index dffdaf3c44c1cdcd02d993efd4415c1c76e57976..fe96cbbaeab1ac4559dd8a8ad6c009abf4884dee 100755 (executable)
@@ -86,13 +86,13 @@ public class TmfBaseStatisticsDataTest {
      * Constructor
      */
     public TmfBaseStatisticsDataTest() {
-        fContent1 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some content");
+        fContent1 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some content", null);
         fEvent1 = new TmfEvent(null, fTimestamp1, fSource, fType1, fContent1, fReference);
 
-        fContent2 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some other content");
+        fContent2 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some other content", null);
         fEvent2 = new TmfEvent(null, fTimestamp2, fSource, fType2, fContent2, fReference);
 
-        fContent3 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some other different content");
+        fContent3 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some other different content", null);
         fEvent3 = new TmfEvent(null, fTimestamp3, fSource, fType3, fContent3, fReference);
 
         fStatsTree = new TmfStatisticsTree();
index a270edbc49bbd31082144a7971ff5981d4a25794..19b15110dd758f553e8ed2f7449d589f965c4f12 100755 (executable)
@@ -81,10 +81,10 @@ public class TmfTreeContentProviderTest {
      * Constructor
      */
     public TmfTreeContentProviderTest() {
-        fContent1 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some content");
+        fContent1 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some content", null);
         fEvent1 = new TmfEvent(null, fTimestamp1, fSource, fType1, fContent1, fReference);
 
-        fContent2 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some other content");
+        fContent2 = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, "Some other content", null);
         fEvent2 = new TmfEvent(null, fTimestamp2, fSource, fType2, fContent2, fReference);
 
         fStatsData = new TmfStatisticsTree();
index 17dedf9be6f5142716a6439fca383b5621147af4..c4499cb830dfb53bf1e5fba281a48fa386af06f4 100644 (file)
@@ -95,9 +95,9 @@ public class TmfUml2SDTestTrace implements ITmfEventParser {
 
             // Pre-parse the content
             TmfEventField[] fields = new TmfEventField[3];
-            fields[0] = new TmfEventField("sender", sender);
-            fields[1] = new TmfEventField("receiver", receiver);
-            fields[2] = new TmfEventField("signal", signal);
+            fields[0] = new TmfEventField("sender", sender, null);
+            fields[1] = new TmfEventField("receiver", receiver, null);
+            fields[2] = new TmfEventField("signal", signal, null);
 
             ITmfEventField tmfContent = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, content, fields);
             ITmfEvent tmfEvent = new TmfEvent(fEventStream, new TmfTimestamp(ts, -9), source, tmfEventType, tmfContent, reference);
index f58d8f6cfbf5c72eb231a74eb45c199c813c7c30..391395556eb2fae7108964991554d9d322a2ed3d 100644 (file)
@@ -214,9 +214,9 @@ public class CustomEvent extends TmfEvent {
             String value = fData.get(outputColumn.name);
             if (outputColumn.name.equals(CustomTraceDefinition.TAG_TIMESTAMP) && date != null) {
                 SimpleDateFormat dateFormat = new SimpleDateFormat(fDefinition.timeStampOutputFormat);
-                fColumnData[i++] = new TmfEventField(outputColumn.name, dateFormat.format(date));
+                fColumnData[i++] = new TmfEventField(outputColumn.name, dateFormat.format(date), null);
             } else {
-                fColumnData[i++] = new TmfEventField(outputColumn.name, (value != null ? value : "")); //$NON-NLS-1$
+                fColumnData[i++] = new TmfEventField(outputColumn.name, (value != null ? value : ""), null); //$NON-NLS-1$
             }
         }
         CustomEventContent curContent = (CustomEventContent) getContent();
index e3f0f606434d8cafc8901f1f2f4dd062e4364bad..1ecde7bddbb64b4474d00f5756d8cf104e822235 100644 (file)
@@ -31,7 +31,7 @@ public class CustomEventContent extends TmfEventField {
      *            Event content
      */
     public CustomEventContent(CustomEvent parent, StringBuffer content) {
-        super(ITmfEventField.ROOT_FIELD_ID, content);
+        super(ITmfEventField.ROOT_FIELD_ID, content, null);
     }
 
     /**
index 0646dd674599a93bde7aa003182e984b1109b71b..e94b961d192690cd0c67f6713fcbc9b21a9bf3a4 100644 (file)
@@ -38,9 +38,9 @@ public abstract class CustomEventType extends TmfEventType {
     private static ITmfEventField getRootField(CustomTraceDefinition definition) {
         ITmfEventField[] fields = new ITmfEventField[definition.outputs.size()];
         for (int i = 0; i < fields.length; i++) {
-            fields[i] = new TmfEventField(definition.outputs.get(i).name, null);
+            fields[i] = new TmfEventField(definition.outputs.get(i).name, null, null);
         }
-        ITmfEventField rootField = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, fields);
+        ITmfEventField rootField = new TmfEventField(ITmfEventField.ROOT_FIELD_ID, null, fields);
         return rootField;
     }
 
index 172d9e748ca89f5c22d237ece99d6149a8377bfc..d722c3f6202d5d771c909a7679d3a5f6f1a4b29d 100644 (file)
@@ -1782,11 +1782,11 @@ public class TmfEventsTable extends TmfComponent implements IGotoMarker, IColorS
             final String reference = event.getReference();
             final String content = event.getContent().toString();
             fields = new TmfEventField[] {
-                    new TmfEventField(ITmfEvent.EVENT_FIELD_TIMESTAMP, timestamp),
-                    new TmfEventField(ITmfEvent.EVENT_FIELD_SOURCE, source),
-                    new TmfEventField(ITmfEvent.EVENT_FIELD_TYPE, type),
-                    new TmfEventField(ITmfEvent.EVENT_FIELD_REFERENCE, reference),
-                    new TmfEventField(ITmfEvent.EVENT_FIELD_CONTENT, content)
+                    new TmfEventField(ITmfEvent.EVENT_FIELD_TIMESTAMP, timestamp, null),
+                    new TmfEventField(ITmfEvent.EVENT_FIELD_SOURCE, source, null),
+                    new TmfEventField(ITmfEvent.EVENT_FIELD_TYPE, type, null),
+                    new TmfEventField(ITmfEvent.EVENT_FIELD_REFERENCE, reference, null),
+                    new TmfEventField(ITmfEvent.EVENT_FIELD_CONTENT, content, null)
             };
         }
         return fields;
This page took 0.039835 seconds and 5 git commands to generate.