Tighten remote check in gdb.base/argv0-symlink.exp

Check for gdbserver instead of dejagnu remote.  Unlike what the
comment says, the test actually fails with target remote + gdbserver
(it does pass with extended-remote).  The result is:

 FAIL -> KFAIL with --target_board=native-gdbserver
 KPASS -> PASS with --target_board=native-extended-gdbserver

gdb/testsuite/ChangeLog:
2017-10-12  Pedro Alves  <palves@redhat.com>
	    Simon Marchi  <simon.marchi@polymtl.ca>

	* gdb.base/argv0-symlink.exp: kfail on remote gdbserver,
	instead of on dejagnu remote boards.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 0fa3afb0b64e45cefaba6c531496448d7bc1f9b9..e6a4281166d277c750ebea087c6ab9abaff4db1e 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2017-10-12  Pedro Alves  <palves@redhat.com>
+           Simon Marchi  <simon.marchi@polymtl.ca>
+
+       * gdb.base/argv0-symlink.exp: kfail on remote gdbserver,
+       instead of on dejagnu remote boards.
+
 2017-10-12  Pedro Alves  <palves@redhat.com>
            Simon Marchi <simon.marchi@polymtl.ca>
 

diff --git a/gdb/testsuite/gdb.base/argv0-symlink.exp b/gdb/testsuite/gdb.base/argv0-symlink.exp
index a1248edbe00e5bfe2c1bb590d8806f202eed4943..efac9e0029cb8955716bc808044be3d272f2a800 100644 (file)
--- a/gdb/testsuite/gdb.base/argv0-symlink.exp
+++ b/gdb/testsuite/gdb.base/argv0-symlink.exp
@@ -80,8 +80,9 @@ gdb_test_no_output "set print repeats 10000"
 gdb_test_no_output "set print elements 10000"
 
 if { $has_argv0 } {
-    # gdbserver does not have this issue.
-    if ![is_remote target] {
+    # gdbserver in extended-remote mode does not have this issue.
+    # Plain remote does, however.
+    if {[target_info gdb_protocol] != "extended-remote" || ![target_is_gdbserver]} {
        setup_kfail "*-*-*" gdb/15934
     }
     gdb_test {print argv[0]} "/$dirlink/$filelink\"" $test