Use an array type (lwpid_t[]) for the array of lwp IDs.

gdb/ChangeLog:

	* fbsd-nat.c (fbsd_add_threads): Use array type for `lwps'.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ddf52a3c7177a96709c4d7553fcadcdef01866f2..74506f80a41ed3239a586cf8ce8da98fb6ba5e44 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2017-08-21  John Baldwin  <jhb@FreeBSD.org>
+
+       * fbsd-nat.c (fbsd_add_threads): Use array type for `lwps'.
+
 2017-08-21  Pedro Alves  <palves@redhat.com>
 
        PR gdb/19487

diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c
index 6ba6a01a70122fee9445fa963bd32d5aef1fa70b..80e0eca111ef5766ab1d9d7513d37dba92b8c5d1 100644 (file)
--- a/gdb/fbsd-nat.c
+++ b/gdb/fbsd-nat.c
@@ -632,7 +632,7 @@ fbsd_add_threads (pid_t pid)
   if (nlwps == -1)
     perror_with_name (("ptrace"));
 
-  gdb::unique_xmalloc_ptr<lwpid_t> lwps (XCNEWVEC (lwpid_t, nlwps));
+  gdb::unique_xmalloc_ptr<lwpid_t[]> lwps (XCNEWVEC (lwpid_t, nlwps));
 
   nlwps = ptrace (PT_GETLWPLIST, pid, (caddr_t) lwps.get (), nlwps);
   if (nlwps == -1)
@@ -640,8 +640,7 @@ fbsd_add_threads (pid_t pid)
 
   for (i = 0; i < nlwps; i++)
     {
-      lwpid_t lwp = lwps.get ()[i];
-      ptid_t ptid = ptid_build (pid, lwp, 0);
+      ptid_t ptid = ptid_build (pid, lwps[i], 0);
 
       if (!in_thread_list (ptid))
        {
@@ -650,7 +649,7 @@ fbsd_add_threads (pid_t pid)
 
          /* Don't add exited threads.  Note that this is only called
             when attaching to a multi-threaded process.  */
-         if (ptrace (PT_LWPINFO, lwp, (caddr_t) &pl, sizeof pl) == -1)
+         if (ptrace (PT_LWPINFO, lwps[i], (caddr_t) &pl, sizeof pl) == -1)
            perror_with_name (("ptrace"));
          if (pl.pl_flags & PL_FLAG_EXITED)
            continue;
@@ -658,7 +657,7 @@ fbsd_add_threads (pid_t pid)
          if (debug_fbsd_lwp)
            fprintf_unfiltered (gdb_stdlog,
                                "FLWP: adding thread for LWP %u\n",
-                               lwp);
+                               lwps[i]);
          add_thread (ptid);
        }
     }