[TMF] Don't swallow exception in Batch import "startUpdateTask"
authorMarc-Andre Laperle <marc-andre.laperle@ericsson.com>
Wed, 23 Oct 2013 03:57:04 +0000 (23:57 -0400)
committerMarc-Andre Laperle <marc-andre.laperle@ericsson.com>
Wed, 23 Oct 2013 14:51:59 +0000 (10:51 -0400)
One of the tasks in Batch import swallows exceptions making it much more
difficult to figure out what went wrong. Another one was being printed
to standard output.

Change-Id: Ife9c61dee1e57db4af11986739b712ca43c1f7c9
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/17675
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/wizards/importtrace/BatchImportTraceWizard.java

index 602ed3c56be0ef48c572d67eeb7dbdda90a8af6f..98048a9c52b4cbbab7e42f0f1eae1defbb79c75e 100644 (file)
@@ -8,6 +8,7 @@
  *
  * Contributors:
  *   Matthew Khouzam - Initial API and implementation
+ *   Marc-Andre Laperle - Log some exceptions
  *******************************************************************************/
 
 package org.eclipse.linuxtools.tmf.ui.project.wizards.importtrace;
@@ -204,6 +205,7 @@ public class BatchImportTraceWizard extends ImportTraceWizard {
                 }
             });
         } catch (InvocationTargetException e) {
+            Activator.getDefault().logError(Messages.ImportTraceWizardImportProblem, e);
         } catch (InterruptedException e) {
         }
     }
@@ -484,7 +486,7 @@ public class BatchImportTraceWizard extends ImportTraceWizard {
         } catch (InterruptedException e) {
             return false;
         } catch (InvocationTargetException e) {
-            System.out.println(e.getTargetException());
+            Activator.getDefault().logError(Messages.ImportTraceWizardImportProblem, e);
             return false;
         }
 
This page took 0.027248 seconds and 5 git commands to generate.