ss: Implement ISegment#getLength() as a default method

Change-Id: I0ab887f8bcecdebc1e66773ef50b63af3125090b
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/59880
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

diff --git a/analysis/org.eclipse.tracecompass.analysis.os.linux.core/src/org/eclipse/tracecompass/analysis/os/linux/core/latency/SystemCall.java b/analysis/org.eclipse.tracecompass.analysis.os.linux.core/src/org/eclipse/tracecompass/analysis/os/linux/core/latency/SystemCall.java
index 1067934117ceb1e3a2bcbd4bbdc0d64985ed7e04..9cec0882b790a79390401a572ee036cfd9f71394 100644 (file)
--- a/analysis/org.eclipse.tracecompass.analysis.os.linux.core/src/org/eclipse/tracecompass/analysis/os/linux/core/latency/SystemCall.java
+++ b/analysis/org.eclipse.tracecompass.analysis.os.linux.core/src/org/eclipse/tracecompass/analysis/os/linux/core/latency/SystemCall.java
@@ -99,11 +99,6 @@ public class SystemCall implements ISegment {
         return fEndTime;
     }
 
-    @Override
-    public long getLength() {
-        return fEndTime - fInfo.fStartTime;
-    }
-
     /**
      * Get the name of the system call
      *

diff --git a/statesystem/org.eclipse.tracecompass.segmentstore.core/src/org/eclipse/tracecompass/segmentstore/core/BasicSegment.java b/statesystem/org.eclipse.tracecompass.segmentstore.core/src/org/eclipse/tracecompass/segmentstore/core/BasicSegment.java
index 252b76eaef5c6a91e4018dc176c0007b69fe77a4..c14f95c0c823bb23bfc8d8430fd78e135b4480d8 100644 (file)
--- a/statesystem/org.eclipse.tracecompass.segmentstore.core/src/org/eclipse/tracecompass/segmentstore/core/BasicSegment.java
+++ b/statesystem/org.eclipse.tracecompass.segmentstore.core/src/org/eclipse/tracecompass/segmentstore/core/BasicSegment.java
@@ -61,11 +61,6 @@ public class BasicSegment implements ISegment {
         return fEnd;
     }
 
-    @Override
-    public long getLength() {
-        return (fEnd - fStart);
-    }
-
     @Override
     public int compareTo(@Nullable ISegment o) {
         if (o == null) {

diff --git a/statesystem/org.eclipse.tracecompass.segmentstore.core/src/org/eclipse/tracecompass/segmentstore/core/ISegment.java b/statesystem/org.eclipse.tracecompass.segmentstore.core/src/org/eclipse/tracecompass/segmentstore/core/ISegment.java
index 8b21c4c14fc7c0da0d87d4e1d6c90ab0f2f11de8..e82cf387d8322b42e11f469a546f82695f536627 100644 (file)
--- a/statesystem/org.eclipse.tracecompass.segmentstore.core/src/org/eclipse/tracecompass/segmentstore/core/ISegment.java
+++ b/statesystem/org.eclipse.tracecompass.segmentstore.core/src/org/eclipse/tracecompass/segmentstore/core/ISegment.java
@@ -37,10 +37,11 @@ public interface ISegment extends Serializable, Comparable<ISegment> {
     long getEnd();
 
     /**
-     * The length/duration of the segment. Normally ({@link #getEnd()} -
-     * {@link #getStart()}).
+     * The length/duration of the segment.
      *
      * @return The duration
      */
-    long getLength();
+    default long getLength() {
+        return getEnd() - getStart();
+    }
 }