tmf: Bug 478216: Incorrect text highlighting in event table due to tabs

Use GC.textExtent() instead of GC.stringExtent() to calculate the
matching text background highlight x-coordinates, as this method
supports tab expansion.

Change-Id: I98cfdc7e46e7f10086882650f941fc099544f898
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/56554
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

diff --git a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java
index dd7e3177f40ea8223ee8e5511224689a95df1edc..23aabf2ef88ec54e01f9fd234617b2522c9051e3 100644 (file)
--- a/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java
+++ b/tmf/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java
@@ -745,8 +745,8 @@ public class TmfEventsTable extends TmfComponent implements IGotoMarker, IColorS
                             if (styleRange.data.equals(event.index)) {
                                 int startIndex = styleRange.start;
                                 int endIndex = startIndex + styleRange.length;
-                                int startX = gc.stringExtent(text.substring(0, startIndex)).x;
-                                int endX = gc.stringExtent(text.substring(0, endIndex)).x;
+                                int startX = gc.textExtent(text.substring(0, startIndex)).x;
+                                int endX = gc.textExtent(text.substring(0, endIndex)).x;
                                 gc.setBackground(styleRange.background);
                                 gc.fillRectangle(textBounds.x + startX, textBounds.y, (endX - startX), textBounds.height);
                             }