tmf remote: remove code duplication

Change-Id: Id8ab4d7f328a45130d5fe69a758c27da31181e7a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44777
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

diff --git a/org.eclipse.tracecompass.tmf.remote.ui/src/org/eclipse/tracecompass/internal/tmf/remote/ui/wizards/fetch/preferences/RemoteProfilesPreferencePage.java b/org.eclipse.tracecompass.tmf.remote.ui/src/org/eclipse/tracecompass/internal/tmf/remote/ui/wizards/fetch/preferences/RemoteProfilesPreferencePage.java
index 030f4b588759637518e7564d70cc84e822acedff..02f1f6e375ca962062a7b2d90ce2cbf501d1b4cf 100644 (file)
--- a/org.eclipse.tracecompass.tmf.remote.ui/src/org/eclipse/tracecompass/internal/tmf/remote/ui/wizards/fetch/preferences/RemoteProfilesPreferencePage.java
+++ b/org.eclipse.tracecompass.tmf.remote.ui/src/org/eclipse/tracecompass/internal/tmf/remote/ui/wizards/fetch/preferences/RemoteProfilesPreferencePage.java
@@ -367,17 +367,7 @@ public class RemoteProfilesPreferencePage extends PreferencePage implements IWor
                     return;
                 }
                 for (Object item : selection.toList()) {
-                    if (item instanceof RemoteImportProfileElement) {
-                        fProfiles.remove(item);
-                        fTreeViewer.refresh();
-                        validate();
-                    } else if (item instanceof TracePackageElement) {
-                        TracePackageElement element = (TracePackageElement) item;
-                        TracePackageElement parent = element.getParent();
-                        parent.removeChild(element);
-                        fTreeViewer.refresh(parent);
-                        validate();
-                    }
+                    removeElement(item);
                 }
             }
         };
@@ -394,17 +384,7 @@ public class RemoteProfilesPreferencePage extends PreferencePage implements IWor
                 }
                 setClipboardContents(selection);
                 Object item = selection.getFirstElement();
-                if (item instanceof RemoteImportProfileElement) {
-                    fProfiles.remove(item);
-                    fTreeViewer.refresh();
-                    validate();
-                } else if (item instanceof TracePackageElement) {
-                    TracePackageElement element = (TracePackageElement) item;
-                    TracePackageElement parent = element.getParent();
-                    parent.removeChild(element);
-                    fTreeViewer.refresh(parent);
-                    validate();
-                }
+                removeElement(item);
             }
         };
         fCutAction.setImageDescriptor(PlatformUI.getWorkbench().getSharedImages().getImageDescriptor(ISharedImages.IMG_TOOL_CUT));
@@ -975,6 +955,20 @@ public class RemoteProfilesPreferencePage extends PreferencePage implements IWor
         validate();
     }
 
+    private void removeElement(Object item) {
+        if (item instanceof RemoteImportProfileElement) {
+            fProfiles.remove(item);
+            fTreeViewer.refresh();
+            validate();
+        } else if (item instanceof TracePackageElement) {
+            TracePackageElement element = (TracePackageElement) item;
+            TracePackageElement parent = element.getParent();
+            parent.removeChild(element);
+            fTreeViewer.refresh(parent);
+            validate();
+        }
+    }
+
     private TracePackageElement copyElement(TracePackageElement parent, TracePackageElement element) {
         TracePackageElement copy = null;
         if (element instanceof RemoteImportProfileElement) {
@@ -1188,4 +1182,5 @@ public class RemoteProfilesPreferencePage extends PreferencePage implements IWor
     public String getSelectedProfile() {
         return fSelectedProfileName;
     }
+
 }