tmf: Bug 460032: Fix concurrent update of XML presentation provider

Change-Id: Ie5dbbd7ddaa9737048ecdee4d383e43d094f0681
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41943
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

diff --git a/org.eclipse.tracecompass.tmf.analysis.xml.ui/src/org/eclipse/tracecompass/tmf/analysis/xml/ui/views/timegraph/XmlPresentationProvider.java b/org.eclipse.tracecompass.tmf.analysis.xml.ui/src/org/eclipse/tracecompass/tmf/analysis/xml/ui/views/timegraph/XmlPresentationProvider.java
index 61fef5385b1901fb2102ed14766280f7c5a79d6e..48e94306b257aecb6bf9cc0ffe84de90691aa169 100644 (file)
--- a/org.eclipse.tracecompass.tmf.analysis.xml.ui/src/org/eclipse/tracecompass/tmf/analysis/xml/ui/views/timegraph/XmlPresentationProvider.java
+++ b/org.eclipse.tracecompass.tmf.analysis.xml.ui/src/org/eclipse/tracecompass/tmf/analysis/xml/ui/views/timegraph/XmlPresentationProvider.java
@@ -63,24 +63,13 @@ public class XmlPresentationProvider extends TimeGraphPresentationProvider {
             int value = tcEvent.getValue();
 
             if (entry.getType() == EntryDisplayType.DISPLAY) {
+                // Draw state only if state is already known
                 Integer index = stateIndex.get(value);
-                if (index == null) {
-                    /* Colors won't be refreshed yet, return something known */
-                    index = TRANSPARENT;
-                    stateIndex.put(value, stateValues.size());
-                    StateItem item = new StateItem(calcColor(stateValues.size()), String.valueOf(value));
-                    stateValues.add(item);
-                    Display.getDefault().asyncExec(new Runnable() {
-                        @Override
-                        public void run() {
-                            fireColorSettingsChanged();
-                        }
-                    });
+                if (index != null) {
+                    return index;
                 }
-                return index;
             }
         }
-
         return INVISIBLE;
     }