dlm: Use kmemdup instead of kmalloc and memcpy
authorAmitoj Kaur Chawla <amitoj1606@gmail.com>
Thu, 23 Jun 2016 04:52:01 +0000 (10:22 +0530)
committerDavid Teigland <teigland@redhat.com>
Thu, 23 Jun 2016 16:55:58 +0000 (11:55 -0500)
Replace calls to kmalloc followed by a memcpy with a direct call to
kmemdup.

The Coccinelle semantic patch used to make this change is as follows:
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: David Teigland <teigland@redhat.com>
fs/dlm/lowcomms.c

index 1ab012a27d9f3b209e6d943741a0f9b9c974201d..963016c8f3d12def89c9803eb9d124caa2385dc4 100644 (file)
@@ -1279,10 +1279,9 @@ static void init_local(void)
                if (dlm_our_addr(&sas, i))
                        break;
 
-               addr = kmalloc(sizeof(*addr), GFP_NOFS);
+               addr = kmemdup(&sas, sizeof(*addr), GFP_NOFS);
                if (!addr)
                        break;
-               memcpy(addr, &sas, sizeof(*addr));
                dlm_local_addr[dlm_local_count++] = addr;
        }
 }
This page took 0.026331 seconds and 5 git commands to generate.