dmaengine: dw: move dwc->paused to dwc->flags
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 18 Mar 2016 14:24:51 +0000 (16:24 +0200)
committerVinod Koul <vinod.koul@intel.com>
Wed, 13 Apr 2016 16:06:15 +0000 (21:36 +0530)
We have already dedicated variable for flags, therefore no need to create an
additional storage for that. Convert dwc->paused to use dwc->flags.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/dw/core.c
drivers/dma/dw/regs.h

index 63502241703a850347255d7f755a7ab7d727d1ed..2ee3acc68a61f4db0bc421fa9651e5a5ad57f4a0 100644 (file)
@@ -999,7 +999,7 @@ static int dwc_pause(struct dma_chan *chan)
        while (!(channel_readl(dwc, CFG_LO) & DWC_CFGL_FIFO_EMPTY) && count--)
                udelay(2);
 
-       dwc->paused = true;
+       set_bit(DW_DMA_IS_PAUSED, &dwc->flags);
 
        spin_unlock_irqrestore(&dwc->lock, flags);
 
@@ -1012,7 +1012,7 @@ static inline void dwc_chan_resume(struct dw_dma_chan *dwc)
 
        channel_writel(dwc, CFG_LO, cfglo & ~DWC_CFGL_CH_SUSP);
 
-       dwc->paused = false;
+       clear_bit(DW_DMA_IS_PAUSED, &dwc->flags);
 }
 
 static int dwc_resume(struct dma_chan *chan)
@@ -1020,12 +1020,10 @@ static int dwc_resume(struct dma_chan *chan)
        struct dw_dma_chan      *dwc = to_dw_dma_chan(chan);
        unsigned long           flags;
 
-       if (!dwc->paused)
-               return 0;
-
        spin_lock_irqsave(&dwc->lock, flags);
 
-       dwc_chan_resume(dwc);
+       if (test_bit(DW_DMA_IS_PAUSED, &dwc->flags))
+               dwc_chan_resume(dwc);
 
        spin_unlock_irqrestore(&dwc->lock, flags);
 
@@ -1094,7 +1092,7 @@ dwc_tx_status(struct dma_chan *chan,
        if (ret != DMA_COMPLETE)
                dma_set_residue(txstate, dwc_get_residue(dwc));
 
-       if (dwc->paused && ret == DMA_IN_PROGRESS)
+       if (test_bit(DW_DMA_IS_PAUSED, &dwc->flags) && ret == DMA_IN_PROGRESS)
                return DMA_PAUSED;
 
        return ret;
index feb3a4a7623b3cec654c31af91de18d58c4d950b..94f8f62ff884df543accecc435bd4598ceb8854d 100644 (file)
@@ -216,6 +216,7 @@ enum dw_dma_msize {
 enum dw_dmac_flags {
        DW_DMA_IS_CYCLIC = 0,
        DW_DMA_IS_SOFT_LLP = 1,
+       DW_DMA_IS_PAUSED = 2,
 };
 
 struct dw_dma_chan {
@@ -224,7 +225,6 @@ struct dw_dma_chan {
        u8                              mask;
        u8                              priority;
        enum dma_transfer_direction     direction;
-       bool                            paused;
        bool                            initialized;
 
        /* software emulation of the LLP transfers */
This page took 0.037764 seconds and 5 git commands to generate.