* elfxx-mips.c (allocate_dynrelocs): Correct test for symbol

	defined in a regular file to include common symbols.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 46095f7aac82036990b7ace7b7b55465b8253c56..3b91a8556cca6a6adfe77349a58789f7197cc7af 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2012-12-06  Alan Modra  <amodra@gmail.com>
+
+       * elfxx-mips.c (allocate_dynrelocs): Correct test for symbol
+       defined in a regular file to include common symbols.
+
 2012-12-05  Leif Ekblad  <leif@rdos.net>
 
        * config.bfd: Add x86_64-*-rdos.

diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c
index a4aa125c0ee4e59fa5a1c6b8cb67be2437881d95..403627340503e633ea12bec3aa9e5f4bf1848d80 100644 (file)
--- a/bfd/elfxx-mips.c
+++ b/bfd/elfxx-mips.c
@@ -8568,7 +8568,7 @@ allocate_dynrelocs (struct elf_link_hash_entry *h, void *inf)
   if (! info->relocatable
       && hmips->possibly_dynamic_relocs != 0
       && (h->root.type == bfd_link_hash_defweak
-         || !h->def_regular
+         || (!h->def_regular && !ELF_COMMON_DEF_P (h))
          || info->shared))
     {
       bfd_boolean do_copy = TRUE;