testsuite: diagnose a running GDB in gdb_skip_xml_tests

If GDB is running when gdb_skip_xml_tests is called with
--target_board=native-extended-gdbserer.exp, it fails with:

    (gdb) FAIL: ....exp: set tdesc filename .../trivial.xml (got interactive prompt)
    monitor exit

Diagnose this in gdb_skip_xml_tests to generate a more meaningful error message:

    ERROR: tcl error sourcing ....exp.
    ERROR: GDB must not be running in gdb_skip_xml_tests.
        while executing
    [...]

testsuite/
	* lib/gdb.exp (gdb_skip_xml_tests): Error if GDB is running.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 99cb9fe5e6800cd3c86ad24869b42890e4a189cc..0972db3649c2d840f6e4478a624452829dd3919b 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2017-02-01  Markus Metzger  <markus.t.metzger@intel.com>
+
+       * lib/gdb.exp (gdb_skip_xml_tests): Error if GDB is running.
+
 2017-02-01  Markus Metzger  <markus.t.metzger@intel.com>
 
        * gdb.btrace/enable.exp: Call gdb_exit before

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 48bd7eefbd81f9227cfb7603bfddd2fcd41dd4c8..188484f792f9b63302a0a22feebecc56299c5521 100644 (file)
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -5030,9 +5030,14 @@ proc gdb_skip_bogus_test { msg } {
 # NOTE: This must be called while gdb is *not* running.
 
 gdb_caching_proc gdb_skip_xml_test {
+    global gdb_spawn_id
     global gdb_prompt
     global srcdir
 
+    if { [info exists gdb_spawn_id] } {
+        error "GDB must not be running in gdb_skip_xml_tests."
+    }
+
     set xml_file [gdb_remote_download host "${srcdir}/gdb.xml/trivial.xml"]
 
     gdb_start