changed TmfEvent to ITmfEvent

diff --git a/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/handlers/OpenExperimentHandler.java b/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/handlers/OpenExperimentHandler.java
index 87fdfb830acc8c7dcc4a24dd565985d8598ce9d3..6c3e8172323386900bff32066507b9623fec2c2a 100644 (file)
--- a/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/handlers/OpenExperimentHandler.java
+++ b/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/handlers/OpenExperimentHandler.java
@@ -1,11 +1,11 @@
 /*******************************************************************************
  * Copyright (c) 2009, 2010, 2011 Ericsson
- * 
+ *
  * All rights reserved. This program and the accompanying materials are
  * made available under the terms of the Eclipse Public License v1.0 which
  * accompanies this distribution, and is available at
  * http://www.eclipse.org/legal/epl-v10.html
- * 
+ *
  * Contributors:
  *   Francois Chouinard - Initial API and implementation
  *******************************************************************************/
@@ -26,6 +26,7 @@ import org.eclipse.core.runtime.CoreException;
 import org.eclipse.jface.viewers.ISelection;
 import org.eclipse.jface.viewers.ISelectionProvider;
 import org.eclipse.jface.viewers.TreeSelection;
+import org.eclipse.linuxtools.tmf.core.event.ITmfEvent;
 import org.eclipse.linuxtools.tmf.core.event.TmfEvent;
 import org.eclipse.linuxtools.tmf.core.experiment.TmfExperiment;
 import org.eclipse.linuxtools.tmf.core.signal.TmfExperimentSelectedSignal;
@@ -67,15 +68,17 @@ public class OpenExperimentHandler extends AbstractHandler {
 
         // Check if we are closing down
         IWorkbenchWindow window = PlatformUI.getWorkbench().getActiveWorkbenchWindow();
-        if (window == null)
+        if (window == null) {
             return false;
+        }
 
         // Get the selection
         IWorkbenchPage page = PlatformUI.getWorkbench().getActiveWorkbenchWindow().getActivePage();
         IWorkbenchPart part = page.getActivePart();
         ISelectionProvider selectionProvider = part.getSite().getSelectionProvider();
-        if (selectionProvider == null)
+        if (selectionProvider == null) {
             return false;
+        }
         ISelection selection = selectionProvider.getSelection();
 
         // Make sure there is only one selection and that it is an experiment
@@ -103,8 +106,9 @@ public class OpenExperimentHandler extends AbstractHandler {
 
         // Check if we are closing down
         IWorkbenchWindow window = PlatformUI.getWorkbench().getActiveWorkbenchWindow();
-        if (window == null)
+        if (window == null) {
             return false;
+        }
 
         try {
             IFile bookmarksFile = fExperiment.getProject().getExperimentsFolder().getResource().getFile(BOOKMARKS_HIDDEN_FILE);
@@ -131,8 +135,8 @@ public class OpenExperimentHandler extends AbstractHandler {
             for (int i = 0; i < nbTraces; i++) {
                 TmfTraceElement element = traceEntries.get(i);
                 ITmfTrace trace = element.instantiateTrace();
-                TmfEvent traceEvent = element.instantiateEvent();
-                if (trace == null || traceEvent == null) {
+                ITmfEvent traceEvent = element.instantiateEvent();
+                if ((trace == null) || (traceEvent == null)) {
                     displayErrorMsg(Messages.OpenExperimentHandler_NoTraceType);
                     for (int j = 0; j < i; j++) {
                         traces[j].dispose();
@@ -168,10 +172,10 @@ public class OpenExperimentHandler extends AbstractHandler {
                 IEditorInput editorInput = new TmfEditorInput(file, experiment);
                 IWorkbench wb = PlatformUI.getWorkbench();
                 IWorkbenchPage activePage = wb.getActiveWorkbenchWindow().getActivePage();
-    
+
                 String editorId = TmfEventsEditor.ID;
                 IEditorPart editor = activePage.findEditor(new FileEditorInput(file));
-                if (editor != null && editor instanceof IReusableEditor) {
+                if ((editor != null) && (editor instanceof IReusableEditor)) {
                     activePage.reuseEditor((IReusableEditor) editor, editorInput);
                     activePage.activate(editor);
                 } else {

diff --git a/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/handlers/OpenTraceHandler.java b/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/handlers/OpenTraceHandler.java
index 69b6bba6ec051d148da536eee081e1e4c44ad1ea..740f20e4a92a0115df59c13a5e658e84dfeb5244 100644 (file)
--- a/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/handlers/OpenTraceHandler.java
+++ b/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/handlers/OpenTraceHandler.java
@@ -1,11 +1,11 @@
 /*******************************************************************************
  * Copyright (c) 2009, 2010, 2011 Ericsson
- * 
+ *
  * All rights reserved. This program and the accompanying materials are
  * made available under the terms of the Eclipse Public License v1.0 which
  * accompanies this distribution, and is available at
  * http://www.eclipse.org/legal/epl-v10.html
- * 
+ *
  * Contributors:
  *   Francois Chouinard - Initial API and implementation
  *******************************************************************************/
@@ -26,7 +26,7 @@ import org.eclipse.core.runtime.CoreException;
 import org.eclipse.jface.viewers.ISelection;
 import org.eclipse.jface.viewers.ISelectionProvider;
 import org.eclipse.jface.viewers.TreeSelection;
-import org.eclipse.linuxtools.tmf.core.event.TmfEvent;
+import org.eclipse.linuxtools.tmf.core.event.ITmfEvent;
 import org.eclipse.linuxtools.tmf.core.experiment.TmfExperiment;
 import org.eclipse.linuxtools.tmf.core.signal.TmfExperimentSelectedSignal;
 import org.eclipse.linuxtools.tmf.core.signal.TmfSignalManager;
@@ -73,15 +73,17 @@ public class OpenTraceHandler extends AbstractHandler {
 
         // Check if we are closing down
         IWorkbenchWindow window = PlatformUI.getWorkbench().getActiveWorkbenchWindow();
-        if (window == null)
+        if (window == null) {
             return false;
+        }
 
         // Get the selection
         IWorkbenchPage page = PlatformUI.getWorkbench().getActiveWorkbenchWindow().getActivePage();
         IWorkbenchPart part = page.getActivePart();
         ISelectionProvider selectionProvider = part.getSite().getSelectionProvider();
-        if (selectionProvider == null)
+        if (selectionProvider == null) {
             return false;
+        }
         ISelection selection = selectionProvider.getSelection();
 
         // Make sure there is only one selection and that it is a trace
@@ -109,8 +111,9 @@ public class OpenTraceHandler extends AbstractHandler {
 
         // Check if we are closing down
         IWorkbenchWindow window = PlatformUI.getWorkbench().getActiveWorkbenchWindow();
-        if (window == null)
+        if (window == null) {
             return null;
+        }
 
         // Check that the trace is valid
         if (fTrace == null) {
@@ -128,15 +131,15 @@ public class OpenTraceHandler extends AbstractHandler {
         }
 
         ITmfTrace trace = fTrace.instantiateTrace();
-        TmfEvent traceEvent = fTrace.instantiateEvent();
-        if (trace == null || traceEvent == null) {
+        ITmfEvent traceEvent = fTrace.instantiateEvent();
+        if ((trace == null) || (traceEvent == null)) {
             displayErrorMsg(Messages.OpenTraceHandler_NoTraceType);
             return null;
         }
 
         // Get the editor_id from the extension point
         String editorId = fTrace.getEditorId();
-        boolean usesEditor = editorId != null && editorId.length() > 0;
+        boolean usesEditor = (editorId != null) && (editorId.length() > 0);
 
         try {
             trace.initTrace(fTrace.getName(), fTrace.getLocation().getPath(), traceEvent.getClass());
@@ -184,7 +187,7 @@ public class OpenTraceHandler extends AbstractHandler {
                 IWorkbenchPage activePage = wb.getActiveWorkbenchWindow().getActivePage();
 
                 IEditorPart editor = activePage.findEditor(new FileEditorInput(file));
-                if (editor != null && editor instanceof IReusableEditor) {
+                if ((editor != null) && (editor instanceof IReusableEditor)) {
                     activePage.reuseEditor((IReusableEditor) editor, editorInput);
                     activePage.activate(editor);
                 } else {
@@ -201,7 +204,7 @@ public class OpenTraceHandler extends AbstractHandler {
             ITmfTrace[] traces = new ITmfTrace[] { trace };
             TmfExperiment experiment = new TmfExperiment(traceEvent.getClass(), fTrace.getName(), traces, trace.getIndexPageSize());
             experiment.setBookmarksFile(file);
-    
+
             TmfExperiment.setCurrentExperiment(experiment);
             TmfSignalManager.dispatchSignal(new TmfExperimentSelectedSignal(this, experiment));
             IDE.setDefaultEditor(file, EventsViewEditor.ID);

diff --git a/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/editors/EventsViewEditor.java b/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/editors/EventsViewEditor.java
index 0268dd547929e1cf76b6ee5b250882038b358a69..a4cc1dbefc21d59ec95cdf27730e934dc6b23283 100644 (file)
--- a/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/editors/EventsViewEditor.java
+++ b/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/editors/EventsViewEditor.java
@@ -1,11 +1,11 @@
 /*******************************************************************************
 * Copyright (c) 2012 Ericsson
- * 
+ *
  * All rights reserved. This program and the accompanying materials are
  * made available under the terms of the Eclipse Public License v1.0 which
  * accompanies this distribution, and is available at
  * http://www.eclipse.org/legal/epl-v10.html
- * 
+ *
  * Contributors:
  *   Patrick Tasse - Initial API and implementation
  *******************************************************************************/
@@ -21,6 +21,7 @@ import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IProgressMonitor;
 import org.eclipse.core.runtime.InvalidRegistryObjectException;
 import org.eclipse.linuxtools.internal.tmf.ui.project.handlers.Messages;
+import org.eclipse.linuxtools.tmf.core.event.ITmfEvent;
 import org.eclipse.linuxtools.tmf.core.event.TmfEvent;
 import org.eclipse.linuxtools.tmf.core.experiment.TmfExperiment;
 import org.eclipse.linuxtools.tmf.core.signal.TmfExperimentSelectedSignal;
@@ -46,7 +47,7 @@ import org.eclipse.ui.ide.IGotoMarker;
 import org.eclipse.ui.part.EditorPart;
 
 /**
- * 
+ *
  * This editor is used to open a trace in the Events view
  * and set the trace as the current experiment.
  * It intercepts the IGotoMarker adapter and dispatches
@@ -97,7 +98,7 @@ public class EventsViewEditor extends TmfEditor {
                 throw new PartInitException("Invalid IFileEditorInput: " + input); //$NON-NLS-1$
             }
             TmfExperiment currentExperiment = TmfExperiment.getCurrentExperiment();
-            if (currentExperiment != null && fFile.equals(currentExperiment.getBookmarksFile())) {
+            if ((currentExperiment != null) && fFile.equals(currentExperiment.getBookmarksFile())) {
                 fTrace = currentExperiment;
                 super.setSite(site);
                 super.setInput(input);
@@ -128,8 +129,8 @@ public class EventsViewEditor extends TmfEditor {
                             for (int i = 0; i < nbTraces; i++) {
                                 TmfTraceElement traceElement = traceEntries.get(i);
                                 ITmfTrace trace = traceElement.instantiateTrace();
-                                TmfEvent traceEvent = traceElement.instantiateEvent();
-                                if (trace == null || traceEvent == null) {
+                                ITmfEvent traceEvent = traceElement.instantiateEvent();
+                                if ((trace == null) || (traceEvent == null)) {
                                     for (int j = 0; j < i; j++) {
                                         traces[j].dispose();
                                     }
@@ -162,8 +163,8 @@ public class EventsViewEditor extends TmfEditor {
                             TmfTraceElement traceElement = (TmfTraceElement) projectElement;
                             // Instantiate the experiment trace
                             ITmfTrace trace = traceElement.instantiateTrace();
-                            TmfEvent traceEvent = traceElement.instantiateEvent();
-                            if (trace == null || traceEvent == null) {
+                            ITmfEvent traceEvent = traceElement.instantiateEvent();
+                            if ((trace == null) || (traceEvent == null)) {
                                 throw new PartInitException(Messages.OpenTraceHandler_NoTraceType);
                             }
                             try {
@@ -189,8 +190,8 @@ public class EventsViewEditor extends TmfEditor {
                             TmfTraceElement traceElement = (TmfTraceElement) projectElement;
                             // Instantiate the experiment trace
                             ITmfTrace trace = traceElement.instantiateTrace();
-                            TmfEvent traceEvent = traceElement.instantiateEvent();
-                            if (trace == null || traceEvent == null) {
+                            ITmfEvent traceEvent = traceElement.instantiateEvent();
+                            if ((trace == null) || (traceEvent == null)) {
                                 throw new PartInitException(Messages.OpenTraceHandler_NoTraceType);
                             }
                             try {

diff --git a/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/editors/TmfEventsEditor.java b/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/editors/TmfEventsEditor.java
index 9d26d4bc444428713de75de713d5241f154b45b9..e9f736a52a0df40c5145a3d7b63ddbca14ba36f9 100644 (file)
--- a/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/editors/TmfEventsEditor.java
+++ b/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/editors/TmfEventsEditor.java
@@ -1,11 +1,11 @@
 /*******************************************************************************\r
  * Copyright (c) 2010 Ericsson\r
- * \r
+ *\r
  * All rights reserved. This program and the accompanying materials are\r
  * made available under the terms of the Eclipse Public License v1.0 which\r
  * accompanies this distribution, and is available at\r
  * http://www.eclipse.org/legal/epl-v10.html\r
- * \r
+ *\r
  * Contributors:\r
  *   Patrick Tasse - Initial API and implementation\r
  *******************************************************************************/\r
@@ -34,6 +34,7 @@ import org.eclipse.linuxtools.internal.tmf.ui.parsers.custom.CustomEventsTable;
 import org.eclipse.linuxtools.internal.tmf.ui.parsers.custom.CustomTxtTrace;\r
 import org.eclipse.linuxtools.internal.tmf.ui.parsers.custom.CustomXmlTrace;\r
 import org.eclipse.linuxtools.internal.tmf.ui.project.handlers.Messages;\r
+import org.eclipse.linuxtools.tmf.core.event.ITmfEvent;\r
 import org.eclipse.linuxtools.tmf.core.event.TmfEvent;\r
 import org.eclipse.linuxtools.tmf.core.experiment.TmfExperiment;\r
 import org.eclipse.linuxtools.tmf.core.signal.TmfSignalHandler;\r
@@ -70,7 +71,7 @@ import org.osgi.framework.Bundle;
 public class TmfEventsEditor extends TmfEditor implements ITmfTraceEditor, IReusableEditor, IPropertyListener, IResourceChangeListener {\r
 \r
     public static final String ID = "org.eclipse.linuxtools.tmf.ui.editors.events"; //$NON-NLS-1$\r
-    \r
+\r
     private TmfEventsTable fEventsTable;\r
     private IFile fFile;\r
     @SuppressWarnings("rawtypes")\r
@@ -122,8 +123,8 @@ public class TmfEventsEditor extends TmfEditor implements ITmfTraceEditor, IReus
                             for (int i = 0; i < nbTraces; i++) {\r
                                 TmfTraceElement traceElement = traceEntries.get(i);\r
                                 ITmfTrace trace = traceElement.instantiateTrace();\r
-                                TmfEvent traceEvent = traceElement.instantiateEvent();\r
-                                if (trace == null || traceEvent == null) {\r
+                                ITmfEvent traceEvent = traceElement.instantiateEvent();\r
+                                if ((trace == null) || (traceEvent == null)) {\r
                                     for (int j = 0; j < i; j++) {\r
                                         traces[j].dispose();\r
                                     }\r
@@ -156,8 +157,8 @@ public class TmfEventsEditor extends TmfEditor implements ITmfTraceEditor, IReus
                             TmfTraceElement traceElement = (TmfTraceElement) projectElement;\r
                             // Instantiate the trace\r
                             ITmfTrace trace = traceElement.instantiateTrace();\r
-                            TmfEvent traceEvent = traceElement.instantiateEvent();\r
-                            if (trace == null || traceEvent == null) {\r
+                            ITmfEvent traceEvent = traceElement.instantiateEvent();\r
+                            if ((trace == null) || (traceEvent == null)) {\r
                                 throw new PartInitException(Messages.OpenTraceHandler_NoTraceType);\r
                             }\r
                             try {\r
@@ -179,8 +180,8 @@ public class TmfEventsEditor extends TmfEditor implements ITmfTraceEditor, IReus
                             TmfTraceElement traceElement = (TmfTraceElement) projectElement;\r
                             // Instantiate the trace\r
                             ITmfTrace trace = traceElement.instantiateTrace();\r
-                            TmfEvent traceEvent = traceElement.instantiateEvent();\r
-                            if (trace == null || traceEvent == null) {\r
+                            ITmfEvent traceEvent = traceElement.instantiateEvent();\r
+                            if ((trace == null) || (traceEvent == null)) {\r
                                 throw new PartInitException(Messages.OpenTraceHandler_NoTraceType);\r
                             }\r
                             try {\r
@@ -286,7 +287,7 @@ public class TmfEventsEditor extends TmfEditor implements ITmfTraceEditor, IReus
         }\r
         return eventsTable;\r
     }\r
-    \r
+\r
     private TmfEventsTable getEventsTable(Composite parent, int cacheSize) {\r
         if (fTrace instanceof TmfExperiment) {\r
             return getExperimentEventsTable((TmfExperiment<?>) fTrace, parent, cacheSize);\r
@@ -313,7 +314,7 @@ public class TmfEventsEditor extends TmfEditor implements ITmfTraceEditor, IReus
                         break;\r
                     }\r
                     String eventsTableType = eventsTableTypeCE[0].getAttribute(TmfTraceType.CLASS_ATTR);\r
-                    if (eventsTableType == null || eventsTableType.length() == 0) {\r
+                    if ((eventsTableType == null) || (eventsTableType.length() == 0)) {\r
                         break;\r
                     }\r
                     Bundle bundle = Platform.getBundle(ce.getContributor().getName());\r
@@ -366,7 +367,7 @@ public class TmfEventsEditor extends TmfEditor implements ITmfTraceEditor, IReus
                     return null;\r
                 }\r
                 String traceType = resource.getPersistentProperty(TmfTraceElement.TRACETYPE);\r
-                if (commonTraceType != null && !commonTraceType.equals(traceType)) {\r
+                if ((commonTraceType != null) && !commonTraceType.equals(traceType)) {\r
                     return null;\r
                 }\r
                 commonTraceType = traceType;\r
@@ -387,7 +388,7 @@ public class TmfEventsEditor extends TmfEditor implements ITmfTraceEditor, IReus
                         break;\r
                     }\r
                     String eventsTableType = eventsTableTypeCE[0].getAttribute(TmfTraceType.CLASS_ATTR);\r
-                    if (eventsTableType == null || eventsTableType.length() == 0) {\r
+                    if ((eventsTableType == null) || (eventsTableType.length() == 0)) {\r
                         break;\r
                     }\r
                     Bundle bundle = Platform.getBundle(ce.getContributor().getName());\r
@@ -479,12 +480,12 @@ public class TmfEventsEditor extends TmfEditor implements ITmfTraceEditor, IReus
     public void addBookmark() {\r
        fEventsTable.addBookmark(fFile);\r
     }\r
-    \r
+\r
 \r
     // ------------------------------------------------------------------------\r
     // Signal handlers\r
     // ------------------------------------------------------------------------\r
-    \r
+\r
     @SuppressWarnings("unchecked")\r
     @TmfSignalHandler\r
     public void traceParserUpdated(TmfTraceParserUpdatedSignal signal) {\r
@@ -527,7 +528,7 @@ public class TmfEventsEditor extends TmfEditor implements ITmfTraceEditor, IReus
 \r
     @TmfSignalHandler\r
     public void traceSelected(TmfTraceSelectedSignal signal) {\r
-        if (signal.getSource() != this && signal.getTrace().equals(fTrace)) {\r
+        if ((signal.getSource() != this) && signal.getTrace().equals(fTrace)) {\r
             getSite().getPage().bringToTop(this);\r
         }\r
     }\r

diff --git a/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java b/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java
index e886b3e541716a01b98b5965ea391669a9bcad3b..3c33a4e497d6954f2ea635779e5f345783fbb4da 100644 (file)
--- a/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java
+++ b/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfTraceElement.java
@@ -1,11 +1,11 @@
 /*******************************************************************************
  * Copyright (c) 2010, 2011 Ericsson
- * 
+ *
  * All rights reserved. This program and the accompanying materials are
  * made available under the terms of the Eclipse Public License v1.0 which
  * accompanies this distribution, and is available at
  * http://www.eclipse.org/legal/epl-v10.html
- * 
+ *
  * Contributors:
  *   Francois Chouinard - Initial API and implementation
  *******************************************************************************/
@@ -27,7 +27,7 @@ import org.eclipse.linuxtools.internal.tmf.ui.parsers.custom.CustomTxtTraceDefin
 import org.eclipse.linuxtools.internal.tmf.ui.parsers.custom.CustomXmlEvent;
 import org.eclipse.linuxtools.internal.tmf.ui.parsers.custom.CustomXmlTrace;
 import org.eclipse.linuxtools.internal.tmf.ui.parsers.custom.CustomXmlTraceDefinition;
-import org.eclipse.linuxtools.tmf.core.event.TmfEvent;
+import org.eclipse.linuxtools.tmf.core.event.ITmfEvent;
 import org.eclipse.linuxtools.tmf.core.trace.ITmfTrace;
 import org.eclipse.linuxtools.tmf.ui.editors.TmfEventsEditor;
 import org.eclipse.ui.IActionFilter;
@@ -170,7 +170,7 @@ public class TmfTraceElement extends TmfProjectModelElement implements IActionFi
         return null;
     }
 
-    public TmfEvent instantiateEvent() {
+    public ITmfEvent instantiateEvent() {
         try {
             if (fTraceTypeId != null) {
                 if (fTraceTypeId.startsWith(CustomTxtTrace.class.getCanonicalName())) {
@@ -188,7 +188,7 @@ public class TmfTraceElement extends TmfProjectModelElement implements IActionFi
                     }
                 }
                 IConfigurationElement ce = sfTraceTypeAttributes.get(fTraceTypeId);
-                TmfEvent event = (TmfEvent) ce.createExecutableExtension(TmfTraceType.EVENT_TYPE_ATTR);
+                ITmfEvent event = (ITmfEvent) ce.createExecutableExtension(TmfTraceType.EVENT_TYPE_ATTR);
                 return event;
             }
         } catch (CoreException e) {
@@ -264,17 +264,21 @@ public class TmfTraceElement extends TmfProjectModelElement implements IActionFi
     @Override
     public Object getPropertyValue(Object id) {
 
-        if (sfName.equals(id))
+        if (sfName.equals(id)) {
             return getName();
+        }
 
-        if (sfPath.equals(id))
+        if (sfPath.equals(id)) {
             return getPath().toString();
+        }
 
-        if (sfLocation.equals(id))
+        if (sfLocation.equals(id)) {
             return getLocation().toString();
+        }
 
-        if (sfIsLinked.equals(id))
+        if (sfIsLinked.equals(id)) {
             return Boolean.valueOf(getResource().isLinked()).toString();
+        }
 
         if (sfEventType.equals(id)) {
             if (fTraceTypeId != null) {