gpio: twl4030: Be sure to clamp return value

As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.

This also makes the driver start to return the error code, as the
end of the series make this work.

Cc: Roger Quadros <rogerq@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/gpio/gpio-twl4030.c b/drivers/gpio/gpio-twl4030.c
index 14f40bf64e34f69d845a0d24efe9d433b2d79ad6..f5590514838a6314349c5fe4bd1136d87f35c368 100644 (file)
--- a/drivers/gpio/gpio-twl4030.c
+++ b/drivers/gpio/gpio-twl4030.c
@@ -327,7 +327,7 @@ static int twl_get(struct gpio_chip *chip, unsigned offset)
        else
                status = twl4030_get_gpio_datain(offset);
 
-       ret = (status <= 0) ? 0 : 1;
+       ret = (status < 0) ? status : !!status;
 out:
        mutex_unlock(&priv->mutex);
        return ret;