Fix: return proper exit code on test failure

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>

diff --git a/tests/test.bash b/tests/test.bash
index cc50e71e098c24b00c143ff5deab1227531e11e6..ec3f492ffd1ab32020285243dd63b0ec2a695cd0 100755 (executable)
--- a/tests/test.bash
+++ b/tests/test.bash
@@ -42,20 +42,19 @@ test_dirs=(
 bats_bin="$(pwd)/bats/bin/bats"
 rc=0
 
-if [ -z ${CC+x} ]; then
+if [ -z "${CC+x}" ]; then
   # default to gcc
   export CC=gcc
 fi
 
-for d in ${test_dirs[@]}; do
-  pushd $d
-  $bats_bin $@ .
-  popd
-
+for d in "${test_dirs[@]}"; do
+  pushd "$d"
+  $bats_bin "${@}" .
   if [ $? -ne 0 ]; then
     # latch error, but continue other tests
     rc=1
   fi
+  popd
 done
 
 exit $rc