PR22191, memory leak in dwarf2.c

table->sequences is a linked list before it is replaced by a bfd_alloc
array in sort_line_sequences.

	PR 22191
	* dwarf2.c (decode_line_info): Properly free line sequences on error.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 450217a666cc645b186cde9362dcf3fb4699c5bc..c465462bcaf3981b90cb3fcbefc0716a290c9b5f 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2017-09-24  Alan Modra  <amodra@gmail.com>
+
+       PR 22191
+       * dwarf2.c (decode_line_info): Properly free line sequences on error.
+
 2017-09-24  Alan Modra  <amodra@gmail.com>
 
        PR 22187

diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c
index ec4c311ec7b0b68d7186c22a708ce7ad7a8a1b9f..1566cd84b04e6243c1b751e92d140410bfca7151 100644 (file)
--- a/bfd/dwarf2.c
+++ b/bfd/dwarf2.c
@@ -2476,8 +2476,12 @@ decode_line_info (struct comp_unit *unit, struct dwarf2_debug *stash)
     return table;
 
  fail:
-  if (table->sequences != NULL)
-    free (table->sequences);
+  while (table->sequences != NULL)
+    {
+      struct line_sequence* seq = table->sequences;
+      table->sequences = table->sequences->prev_sequence;
+      free (seq);
+    }
   if (table->files != NULL)
     free (table->files);
   if (table->dirs != NULL)