fbdev: fix snprintf() limit in show_bl_curve()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 24 Aug 2015 19:54:21 +0000 (22:54 +0300)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Tue, 1 Sep 2015 10:52:23 +0000 (13:52 +0300)
The limit should be "PAGE_SIZE - len" instead of PAGE_SIZE.  Also let's
use scnprintf() because snprintf() returns the number of bytes which
would have been printed if there were space and scnprintf() returns the
number of bytes actually printed.

I don't think we are ever going to actually hit this limit in real life.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/core/fbsysfs.c

index 60c3f0a1634111c41f346b0d2af5d32f1955bd28..15755ce1d26c817587f7f600db41963c46e16c7e 100644 (file)
@@ -485,7 +485,7 @@ static ssize_t show_bl_curve(struct device *device,
 
        mutex_lock(&fb_info->bl_curve_mutex);
        for (i = 0; i < FB_BACKLIGHT_LEVELS; i += 8)
-               len += snprintf(&buf[len], PAGE_SIZE, "%8ph\n",
+               len += scnprintf(&buf[len], PAGE_SIZE - len, "%8ph\n",
                                fb_info->bl_curve + i);
        mutex_unlock(&fb_info->bl_curve_mutex);
 
This page took 0.026465 seconds and 5 git commands to generate.