driver core: remove __must_check from device_create_file
authorGreg Kroah-Hartman <gregkh@suse.de>
Wed, 4 Jan 2012 23:05:10 +0000 (15:05 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 4 Jan 2012 23:05:10 +0000 (15:05 -0800)
With the conversion of the sysdev to a real struct device, more drivers
are calling device_create_file, and some of them don't check the return
value, which isn't wise.

But as they happen to be in parts of the kernel where a warning is
considered an error (i.e. powerpc), this breaks the build.  So for now,
remove the marking on the function, which fixes the build problems.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
include/linux/device.h

index 7f9fc1505e94470dfb3ee829e7307249e175f2c3..acf505e4fe94b3bb9a3dbc5ecdaa27d5492b4be9 100644 (file)
@@ -510,8 +510,8 @@ ssize_t device_store_int(struct device *dev, struct device_attribute *attr,
        struct dev_ext_attribute dev_attr_##_name = \
                { __ATTR(_name, _mode, device_show_ulong, device_store_ulong), &(_var) }
 
-extern int __must_check device_create_file(struct device *device,
-                                       const struct device_attribute *entry);
+extern int device_create_file(struct device *device,
+                             const struct device_attribute *entry);
 extern void device_remove_file(struct device *dev,
                               const struct device_attribute *attr);
 extern int __must_check device_create_bin_file(struct device *dev,
This page took 0.028679 seconds and 5 git commands to generate.